From patchwork Thu Oct 19 16:55:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133012 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FEB0431AE; Thu, 19 Oct 2023 18:59:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D869B42E75; Thu, 19 Oct 2023 18:56:43 +0200 (CEST) Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by mails.dpdk.org (Postfix) with ESMTP id 6261C42E1E for ; Thu, 19 Oct 2023 18:56:32 +0200 (CEST) Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3b2e73a17a0so1384825b6e.3 for ; Thu, 19 Oct 2023 09:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697734591; x=1698339391; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=17E02BJvyWe3b1YnbKfBmcVoKuX7MHzWIjoZUPo2aO4=; b=xDwsEpv50U4f+4lWrHjqdQjloOOU8aQd7bwqZkj2qrgxHShuQ7mzVIigCSH3nupKpJ fJ2RQ80P5ohPAr78yCqGJF+ntI8NpFcZa05RMEt3/haI7AGeQXSVCMdA4mFnP14lmZFV MzxXGounSy5LS7THHQ6nQYUc1LnBGQVh7LUiUx+WOVDzK5NKjn2XYnrV60PrkMcv3E5E /NqSv7GCBWhFIetJnhSKRHKKIfkRrwRcp7VKsR0YhUt+TKQGiKXZHLWMyObakmdnFRbz YdLG0WuKI5+5124ehRG2k3EExbX+TwQkFyBHAxCvoG9VGhaBumCq/tLDveKSQY73d3sK Q3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697734591; x=1698339391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=17E02BJvyWe3b1YnbKfBmcVoKuX7MHzWIjoZUPo2aO4=; b=GGesad3a2byO4b/wSrs31NoqtqWCsTwSlLk/66vIxoRwKJrkf/w4Uy7sbd3WhhfpFa aU7JOKHRqMhUd2rM0EjDHgwjQZPNe5/+JTs+ulaX/mlJEvvUxutgwKfHgtJ+xdzHANgg InDz/m5PIZIWGP8DQr5WhQTu484eF/zaztnV3swxjBNB3VjSmn7lyizpELphqlEMooz/ qYm59ZfLb2wVP1Cl1lNmiTbCqEJF3NwjnlNHHOwmsN+w2RZnks4uVX+1ofSvs8oxJpDV ++u4E2sMiCFA4SxHJNmPuenHfpVKVilnbDHPXu8Ub0a0A2t0uKeGzpOmBNDGazRiFRZM 3Wsg== X-Gm-Message-State: AOJu0Yw7DyEYpeiJh7tHhXgMS1+00FS2+3P0aUb2DBdXdNO7aAi92wYB gxxKdh8ty8dd/n31IaZvE1qjgzSdV3RpM11b59OEBw== X-Google-Smtp-Source: AGHT+IEvCxtx9m/WyhOkyFlqcTZDjpJRqLq3ckqWvLFWczQLIVkqU1QicJH9zARrxvU8T3P1TGuBew== X-Received: by 2002:a05:6808:179e:b0:3a7:7d4:4f91 with SMTP id bg30-20020a056808179e00b003a707d44f91mr3356824oib.14.1697734591478; Thu, 19 Oct 2023 09:56:31 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id y22-20020aa79436000000b00672ea40b8a9sm13988pfo.170.2023.10.19.09.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 09:56:30 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Thomas Monjalon , Fan Zhang , Ashish Gupta Subject: [PATCH v3 25/29] compressdev: remove experimental flag Date: Thu, 19 Oct 2023 09:55:54 -0700 Message-Id: <20231019165559.115742-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231019165559.115742-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231019165559.115742-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The compressdev can not hide under the experimental flag. Remove the experimental flag and require ABI to be stable. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 2 +- lib/compressdev/rte_comp.h | 6 ------ lib/compressdev/rte_compressdev.h | 26 -------------------------- lib/compressdev/rte_compressdev_pmd.h | 6 ------ lib/compressdev/version.map | 2 +- 5 files changed, 2 insertions(+), 40 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1534a414f754..a1d4d57107a3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -459,7 +459,7 @@ F: lib/security/ F: doc/guides/prog_guide/rte_security.rst F: app/test/test_security* -Compression API - EXPERIMENTAL +Compression API M: Fan Zhang M: Ashish Gupta T: git://dpdk.org/next/dpdk-next-crypto diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h index bf896d07223c..232564cf5e9a 100644 --- a/lib/compressdev/rte_comp.h +++ b/lib/compressdev/rte_comp.h @@ -499,7 +499,6 @@ struct rte_comp_op { * - On success pointer to mempool * - On failure NULL */ -__rte_experimental struct rte_mempool * rte_comp_op_pool_create(const char *name, unsigned int nb_elts, unsigned int cache_size, @@ -515,7 +514,6 @@ rte_comp_op_pool_create(const char *name, * - On success returns a valid rte_comp_op structure * - On failure returns NULL */ -__rte_experimental struct rte_comp_op * rte_comp_op_alloc(struct rte_mempool *mempool); @@ -532,7 +530,6 @@ rte_comp_op_alloc(struct rte_mempool *mempool); * - nb_ops: Success, the nb_ops requested was allocated * - 0: Not enough entries in the mempool; no ops are retrieved. */ -__rte_experimental int rte_comp_op_bulk_alloc(struct rte_mempool *mempool, struct rte_comp_op **ops, uint16_t nb_ops); @@ -546,7 +543,6 @@ rte_comp_op_bulk_alloc(struct rte_mempool *mempool, * Compress operation pointer allocated from rte_comp_op_alloc() * If op is NULL, no operation is performed. */ -__rte_experimental void rte_comp_op_free(struct rte_comp_op *op); @@ -561,7 +557,6 @@ rte_comp_op_free(struct rte_comp_op *op); * @param nb_ops * Number of operations to free */ -__rte_experimental void rte_comp_op_bulk_free(struct rte_comp_op **ops, uint16_t nb_ops); @@ -574,7 +569,6 @@ rte_comp_op_bulk_free(struct rte_comp_op **ops, uint16_t nb_ops); * @return * The name of this flag, or NULL if it's not a valid feature flag. */ -__rte_experimental const char * rte_comp_get_feature_name(uint64_t flag); diff --git a/lib/compressdev/rte_compressdev.h b/lib/compressdev/rte_compressdev.h index 13a418631893..8cb5db0e3f7d 100644 --- a/lib/compressdev/rte_compressdev.h +++ b/lib/compressdev/rte_compressdev.h @@ -10,10 +10,6 @@ * * RTE Compression Device APIs. * - * @warning - * @b EXPERIMENTAL: - * All functions in this file may be changed or removed without prior notice. - * * Defines comp device APIs for the provisioning of compression operations. */ @@ -54,7 +50,6 @@ struct rte_compressdev_capabilities { #define RTE_COMP_END_OF_CAPABILITIES_LIST() \ { RTE_COMP_ALGO_UNSPECIFIED } -__rte_experimental const struct rte_compressdev_capabilities * rte_compressdev_capability_get(uint8_t dev_id, enum rte_comp_algorithm algo); @@ -94,7 +89,6 @@ rte_compressdev_capability_get(uint8_t dev_id, * @return * The name of this flag, or NULL if it's not a valid feature flag. */ -__rte_experimental const char * rte_compressdev_get_feature_name(uint64_t flag); @@ -133,7 +127,6 @@ struct rte_compressdev_stats { * - Returns compress device identifier on success. * - Return -1 on failure to find named compress device. */ -__rte_experimental int rte_compressdev_get_dev_id(const char *name); @@ -146,7 +139,6 @@ rte_compressdev_get_dev_id(const char *name); * - Returns compress device name. * - Returns NULL if compress device is not present. */ -__rte_experimental const char * rte_compressdev_name_get(uint8_t dev_id); @@ -157,7 +149,6 @@ rte_compressdev_name_get(uint8_t dev_id); * @return * - The total number of usable compress devices. */ -__rte_experimental uint8_t rte_compressdev_count(void); @@ -175,7 +166,6 @@ rte_compressdev_count(void); * @return * Returns number of attached compress devices. */ -__rte_experimental uint8_t rte_compressdev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices); @@ -190,7 +180,6 @@ rte_compressdev_devices_get(const char *driver_name, uint8_t *devices, * a default of zero if the socket could not be determined. * -1 if returned is the dev_id value is out of range. */ -__rte_experimental int rte_compressdev_socket_id(uint8_t dev_id); @@ -221,7 +210,6 @@ struct rte_compressdev_config { * - 0: Success, device configured. * - <0: Error code returned by the driver configuration function. */ -__rte_experimental int rte_compressdev_configure(uint8_t dev_id, struct rte_compressdev_config *config); @@ -240,7 +228,6 @@ rte_compressdev_configure(uint8_t dev_id, * - 0: Success, device started. * - <0: Error code of the driver device start function. */ -__rte_experimental int rte_compressdev_start(uint8_t dev_id); @@ -251,7 +238,6 @@ rte_compressdev_start(uint8_t dev_id); * @param dev_id * Compress device identifier */ -__rte_experimental void rte_compressdev_stop(uint8_t dev_id); @@ -269,7 +255,6 @@ rte_compressdev_stop(uint8_t dev_id); * - 0 on successfully closing device * - <0 on failure to close device */ -__rte_experimental int rte_compressdev_close(uint8_t dev_id); @@ -296,7 +281,6 @@ rte_compressdev_close(uint8_t dev_id); * - 0: Success, queue pair correctly set up. * - <0: Queue pair configuration failed */ -__rte_experimental int rte_compressdev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, uint32_t max_inflight_ops, int socket_id); @@ -309,7 +293,6 @@ rte_compressdev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, * @return * - The number of configured queue pairs. */ -__rte_experimental uint16_t rte_compressdev_queue_pair_count(uint8_t dev_id); @@ -327,7 +310,6 @@ rte_compressdev_queue_pair_count(uint8_t dev_id); * - Zero if successful. * - Non-zero otherwise. */ -__rte_experimental int rte_compressdev_stats_get(uint8_t dev_id, struct rte_compressdev_stats *stats); @@ -337,7 +319,6 @@ rte_compressdev_stats_get(uint8_t dev_id, struct rte_compressdev_stats *stats); * @param dev_id * The identifier of the device. */ -__rte_experimental void rte_compressdev_stats_reset(uint8_t dev_id); @@ -355,7 +336,6 @@ rte_compressdev_stats_reset(uint8_t dev_id); * The element after the last valid element has it's op field set to * RTE_COMP_ALGO_UNSPECIFIED. */ -__rte_experimental void rte_compressdev_info_get(uint8_t dev_id, struct rte_compressdev_info *dev_info); @@ -413,7 +393,6 @@ rte_compressdev_info_get(uint8_t dev_id, struct rte_compressdev_info *dev_info); * of pointers to *rte_comp_op* structures effectively supplied to the * *ops* array. */ -__rte_experimental uint16_t rte_compressdev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, struct rte_comp_op **ops, uint16_t nb_ops); @@ -468,7 +447,6 @@ rte_compressdev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, * comp devices queue is full or if invalid parameters are specified in * a *rte_comp_op*. */ -__rte_experimental uint16_t rte_compressdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, struct rte_comp_op **ops, uint16_t nb_ops); @@ -496,7 +474,6 @@ rte_compressdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, * - Returns -ENOTSUP if comp device does not support the comp transform. * - Returns -ENOMEM if the private stream could not be allocated. */ -__rte_experimental int rte_compressdev_stream_create(uint8_t dev_id, const struct rte_comp_xform *xform, @@ -518,7 +495,6 @@ rte_compressdev_stream_create(uint8_t dev_id, * - Returns -ENOTSUP if comp device does not support STATEFUL operations. * - Returns -EBUSY if can't free stream as there are inflight operations */ -__rte_experimental int rte_compressdev_stream_free(uint8_t dev_id, void *stream); @@ -545,7 +521,6 @@ rte_compressdev_stream_free(uint8_t dev_id, void *stream); * - Returns -ENOTSUP if comp device does not support the comp transform. * - Returns -ENOMEM if the private_xform could not be allocated. */ -__rte_experimental int rte_compressdev_private_xform_create(uint8_t dev_id, const struct rte_comp_xform *xform, @@ -567,7 +542,6 @@ rte_compressdev_private_xform_create(uint8_t dev_id, * - <0 in error cases * - Returns -EINVAL if input parameters are invalid. */ -__rte_experimental int rte_compressdev_private_xform_free(uint8_t dev_id, void *private_xform); diff --git a/lib/compressdev/rte_compressdev_pmd.h b/lib/compressdev/rte_compressdev_pmd.h index ea012908b783..fa233492fe1f 100644 --- a/lib/compressdev/rte_compressdev_pmd.h +++ b/lib/compressdev/rte_compressdev_pmd.h @@ -59,7 +59,6 @@ struct rte_compressdev_global { * @return * - The rte_compressdev structure pointer for the given device identifier. */ -__rte_experimental struct rte_compressdev * rte_compressdev_pmd_get_named_dev(const char *name); @@ -292,7 +291,6 @@ struct rte_compressdev_ops { * @return * - Slot in the rte_dev_devices array for a new device; */ -__rte_experimental struct rte_compressdev * rte_compressdev_pmd_allocate(const char *name, int socket_id); @@ -308,7 +306,6 @@ rte_compressdev_pmd_allocate(const char *name, int socket_id); * @return * - 0 on success, negative on error */ -__rte_experimental int rte_compressdev_pmd_release_device(struct rte_compressdev *dev); @@ -331,7 +328,6 @@ rte_compressdev_pmd_release_device(struct rte_compressdev *dev); * - 0 on success * - errno on failure */ -__rte_experimental int rte_compressdev_pmd_parse_input_args( struct rte_compressdev_pmd_init_params *params, @@ -353,7 +349,6 @@ rte_compressdev_pmd_parse_input_args( * - comp device instance on success * - NULL on creation failure */ -__rte_experimental struct rte_compressdev * rte_compressdev_pmd_create(const char *name, struct rte_device *device, @@ -372,7 +367,6 @@ rte_compressdev_pmd_create(const char *name, * - 0 on success * - errno on failure */ -__rte_experimental int rte_compressdev_pmd_destroy(struct rte_compressdev *dev); diff --git a/lib/compressdev/version.map b/lib/compressdev/version.map index e2a108b6509f..fa891f669b5d 100644 --- a/lib/compressdev/version.map +++ b/lib/compressdev/version.map @@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_24 { global: rte_compressdev_capability_get;