From patchwork Thu Oct 19 16:55:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133008 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2713431AE; Thu, 19 Oct 2023 18:58:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D6BE42E52; Thu, 19 Oct 2023 18:56:39 +0200 (CEST) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by mails.dpdk.org (Postfix) with ESMTP id 1250142E03 for ; Thu, 19 Oct 2023 18:56:28 +0200 (CEST) Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-6c0b8f42409so5546718a34.0 for ; Thu, 19 Oct 2023 09:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697734587; x=1698339387; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RnGRESMpy1ysFXb/72yZioMZHnAOZlTf7cbicfT0L90=; b=Ues7XLs5m5UxanjFUMkM76qHLRE09vJob9Fp5sKciJWACii+o7HnWgP72dUnOUG+2c 8u3KzhDMUXjfSJmcgsTEXxyzewi6wbiNVFauVBbmodz6WUh0d4Y/1tckRnbsniF/3SBW 4ARqOo7Y8RYSJV9dyLcx+Fokl35AfC46jK4QywTfGcrXuE2nSjRi/EeoNyGpFZ1W7caS QhoPqxaAxNCkuOS8u3/56VQ4k6dCVNYLAKChDSsqILrmBD3NBgSR3NGyP6AaoYqAgOgc /8EuT5MFkCfnTj+y0bCDc3YeE6fk02OVYHHEWf5v0XQO00GH6rRnJKDlT1NClp2+xGIB onLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697734587; x=1698339387; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RnGRESMpy1ysFXb/72yZioMZHnAOZlTf7cbicfT0L90=; b=EwUlAS60oSrQJTXoWvM5iShe4SKkBenxhO82EATy/OBl4JcdQA6LAISTnbEuhG9AN0 6R6urqJjtBo2ZyD5MbfaoSyOlepClvCY0AvQrgE7kgwlvXdzz4SoHS+POe7Tcq0A/mQD zvlRvgn6h2CsbilPkd48KwhMZoXK3aEkJRweV4sTFiUdgZMg+jxi+fWjTe/uAaydRrM+ U/mh1ZVNUwE/SpSYZXg/QykYSx7FBUZ1KLb244vW3M1vpROfgdIDFMs5WWLbMhfRxQKP j6BeH6qc9GVQ6CUg/p9ksXkYj1eV8sBJLaWMFPEYzi77rV9R4UItQ1CgcN5kPSAMjmci rsYA== X-Gm-Message-State: AOJu0YzL45WdaNuzdEgOTltbffe+HhbyIXdHcsThzhvmxJf82cHS+see cduWYEesEsRZo/Xy+HmXt9bx86s2jY/2+3X2h4LIqg== X-Google-Smtp-Source: AGHT+IG0RLEKix4bvfaCEKcclbEGtcJ3XOQbyw9ixOPvCSrkcPdfuklUrt7ojn5k1YWJuTqxV7U4zQ== X-Received: by 2002:a05:6830:1114:b0:6bd:b5f7:187a with SMTP id w20-20020a056830111400b006bdb5f7187amr3226277otq.20.1697734587133; Thu, 19 Oct 2023 09:56:27 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id y22-20020aa79436000000b00672ea40b8a9sm13988pfo.170.2023.10.19.09.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 09:56:26 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal Subject: [PATCH v3 21/29] security: remove experimental flag from macsec Date: Thu, 19 Oct 2023 09:55:50 -0700 Message-Id: <20231019165559.115742-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231019165559.115742-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231019165559.115742-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_security API's for macsec were added in 22.11. Therefore remove the experimental tag. There is also one helper function for setting packet metadata that should have been marked internal. Signed-off-by: Stephen Hemminger Acked-by: Akhil Goyal --- lib/security/rte_security.h | 28 +--------------------------- lib/security/version.map | 18 +++++++++--------- 2 files changed, 10 insertions(+), 36 deletions(-) diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index d2d2af23d5d2..ca78627ec7d2 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h @@ -815,7 +815,6 @@ rte_security_session_create(void *instance, * - On success returns 0 * - On failure returns a negative errno value. */ -__rte_experimental int rte_security_session_update(void *instance, void *sess, @@ -851,9 +850,6 @@ int rte_security_session_destroy(void *instance, void *sess); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create MACsec security channel (SC). * * @param instance security instance @@ -865,15 +861,11 @@ rte_security_session_destroy(void *instance, void *sess); * - -ENOMEM if PMD is not capable to create more SC. * - other negative value for other errors. */ -__rte_experimental int rte_security_macsec_sc_create(void *instance, struct rte_security_macsec_sc *conf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Destroy MACsec security channel (SC). * * @param instance security instance @@ -884,15 +876,11 @@ rte_security_macsec_sc_create(void *instance, * - -EINVAL if sc_id is invalid or instance is NULL. * - -EBUSY if sc is being used by some session. */ -__rte_experimental int rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id, enum rte_security_macsec_direction dir); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create MACsec security association (SA). * * @param instance security instance @@ -904,15 +892,11 @@ rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id, * - -ENOMEM if PMD is not capable to create more SAs. * - other negative value for other errors. */ -__rte_experimental int rte_security_macsec_sa_create(void *instance, struct rte_security_macsec_sa *conf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Destroy MACsec security association (SA). * * @param instance security instance @@ -923,7 +907,6 @@ rte_security_macsec_sa_create(void *instance, * - -EINVAL if sa_id is invalid or instance is NULL. * - -EBUSY if sa is being used by some session. */ -__rte_experimental int rte_security_macsec_sa_destroy(void *instance, uint16_t sa_id, enum rte_security_macsec_direction dir); @@ -1059,7 +1042,7 @@ rte_security_session_fast_mdata_set(void *sess, uint64_t fdata) } /** Function to call PMD specific function pointer set_pkt_metadata() */ -__rte_experimental +__rte_internal int __rte_security_set_pkt_metadata(void *instance, void *sess, struct rte_mbuf *m, void *params); @@ -1230,16 +1213,12 @@ struct rte_security_stats { * - On success, return 0 * - On failure, a negative value */ -__rte_experimental int rte_security_session_stats_get(void *instance, void *sess, struct rte_security_stats *stats); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get MACsec SA statistics. * * @param instance security instance @@ -1250,16 +1229,12 @@ rte_security_session_stats_get(void *instance, * - On success, return 0. * - On failure, a negative value. */ -__rte_experimental int rte_security_macsec_sa_stats_get(void *instance, uint16_t sa_id, enum rte_security_macsec_direction dir, struct rte_security_macsec_sa_stats *stats); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get MACsec SC statistics. * * @param instance security instance @@ -1270,7 +1245,6 @@ rte_security_macsec_sa_stats_get(void *instance, * - On success, return 0. * - On failure, a negative value. */ -__rte_experimental int rte_security_macsec_sc_stats_get(void *instance, uint16_t sc_id, enum rte_security_macsec_direction dir, diff --git a/lib/security/version.map b/lib/security/version.map index e07fca33a1e6..487822147fd3 100644 --- a/lib/security/version.map +++ b/lib/security/version.map @@ -6,14 +6,6 @@ DPDK_24 { rte_security_session_create; rte_security_session_destroy; rte_security_session_get_size; - - local: *; -}; - -EXPERIMENTAL { - global: - - __rte_security_set_pkt_metadata; rte_security_dynfield_offset; rte_security_macsec_sa_create; rte_security_macsec_sa_destroy; @@ -23,8 +15,15 @@ EXPERIMENTAL { rte_security_macsec_sc_stats_get; rte_security_session_stats_get; rte_security_session_update; - rte_security_oop_dynfield_offset; + local: *; +}; + +EXPERIMENTAL { + global: + + # Added in 23.11 + rte_security_oop_dynfield_offset; rte_security_rx_inject_configure; rte_security_inb_pkt_rx_inject; }; @@ -32,6 +31,7 @@ EXPERIMENTAL { INTERNAL { global: + __rte_security_set_pkt_metadata; rte_security_dynfield_register; rte_security_oop_dynfield_register; };