From patchwork Thu Oct 19 16:38:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy Miskell X-Patchwork-Id: 132987 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2966431AE; Thu, 19 Oct 2023 18:38:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C3A44021F; Thu, 19 Oct 2023 18:38:53 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A560440150; Thu, 19 Oct 2023 18:38:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697733532; x=1729269532; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=hc9M5gtzIAWVlm02EJGGJtRGMQRI5hkCWeKPN5mewfo=; b=chox2ZKcjRPA+HAYB90pVv4rwEgLyd7SAQCubUvDn027ICNRIGzBkiU/ SjUdLOSLH12Mzny0XveGdyag/DBCZDF8C9s/8X/1qKo+XjTvFb3XQuHQp +MWdbkud2Yj05Z3Q/agWTgSRkT9pne/bu2kO55+ioabDe5Dz1JZFlwLFC F261ab810ZEQ9aI2yC5Y7Jjr6Dk9oD0e4g1ZanYEniSnjEd8ZobDoOyxp UsuOwUeZdz1l4f71rmYdFqGxn1PyDsUDFODVD3fRAie/x1B7858l3Hdkl N0paHKWfN8JJiBhb2dgsbbI9+9rV2JnZibM4XqUiUbUYda6DZonP8+TVd Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="472534093" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="472534093" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 09:38:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="930680124" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="930680124" Received: from wfp43-hdpae.hd.intel.com ([10.127.128.96]) by orsmga005.jf.intel.com with ESMTP; 19 Oct 2023 09:38:49 -0700 From: Timothy Miskell To: qi.z.zhang@intel.com Cc: dev@dpdk.org, Timothy Miskell , stable@dpdk.org Subject: [PATCH] ice: Increase L1 check interval to account for lengthier link time Date: Thu, 19 Oct 2023 16:38:46 +0000 Message-Id: <20231019163846.324098-1-timothy.miskell@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For edge cases where the transceiver is physically inserted first and immediately afterwards the DPDK PF is started the LSC event may occur outside the current setting for the maximum check interval window. This change lengthens the check interval to account for this along with other reported cases where the link event be longer than 1 second. Cc: stable@dpdk.org Reported-by: Timothy Miskell Suggested-by: Timothy Miskell Signed-off-by: Timothy Miskell Reviewed-by: Larry Wang Tested-by: Jonathan Tsai --- .mailmap | 2 ++ drivers/net/ice/ice_ethdev.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 3f5bab26a8..93c09a23ee 100644 --- a/.mailmap +++ b/.mailmap @@ -674,6 +674,7 @@ John Romein John W. Linville Jonas Pfefferle Jonathan Erb +Jonathan Tsai Jon DeVree Jon Loeliger Joongi Kim @@ -1414,6 +1415,7 @@ Tianli Lai Tianyu Li Timmons C. Player Timothy McDaniel +Timothy Miskell Timothy Redaelli Tim Shearer Ting Xu diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 305077e74e..6ef06b9926 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev, static int ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) { -#define CHECK_INTERVAL 100 /* 100ms */ -#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ +#define CHECK_INTERVAL 50 /* 50ms */ +#define MAX_REPEAT_TIME 40 /* 2s (40 * 50ms) in total */ struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_link_status link_status; struct rte_eth_link link, old;