From patchwork Tue Oct 17 08:09:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 132730 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 772724318A; Tue, 17 Oct 2023 10:11:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D07AD42830; Tue, 17 Oct 2023 10:10:39 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2084.outbound.protection.outlook.com [40.107.101.84]) by mails.dpdk.org (Postfix) with ESMTP id 35EFD40269; Tue, 17 Oct 2023 10:10:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NC200ZzEjTSQkBD31YeOzvx3izZ7As/r7wL1zTqcBRUaQ5a9l5mYN3E8qfq8aqpXGvU2pvquBp7TYbuWaAZOE20wIzXlZ7Iiuu7R+uLZ2RGXfwvbyS2FL4oeVoK0We6GT9G1eOjc6v53h3Nn5VgaYl1w64AVEsrohqmKteTVKfmQcD7or7uBTIsIwRBP8CPykMSeKvzf0Rh+TEutZ/9GHq7G283mamVcqdcwM1d/RgkW50uXjXg/fpWeL3IarPz2SyLSJ8RUgx7atL5nose4kW2+8iCM6bDlNP/FJ1ZkZUnspUYasRkjapKMkFAXsxg3OLSqNjrpq2ROI8UIgq42qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ya1C0Mpgtnnlw4riWXps9GJvNZ2Tv93uupThuqAepZY=; b=YUbjfMNw/EEXK8CgVR6grYqbUtblGZ10LT9MZMSSVQ6JfgO05iChEbIM79EwCY2Xi1ZXwORLjep9QvsN0eTyUco/OqbJfKJiro4GUhsRqfiQtGA5Igch0fDwdzuzGz6aSfauJxk3F4qF705shL/5ALAVi1ne0m9WNK2t+YX2WMIh1UEDH2n4etNmJ+/aTQ5DdSzhlrE0KCA8CZXgJMA8YdK1QKYIQ0zt5cUhZgP3XrfSr8xqwtDRyqqYzOycJT29NplpWcZolz7KJAV2iPMdLQqlM4Ar12+2rl/OjcA03EYYqZpcnDAEvvdQ5ohw8E7Umr3w8s4+eCBimK9cqpymwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ya1C0Mpgtnnlw4riWXps9GJvNZ2Tv93uupThuqAepZY=; b=U+jAGfuQCa01Vcwb0usIL1Z4C1eL7BMC3jeI1eoZw59Ul/Nn9nWyRjE5CB3j4LPEWrj7iWxZhS+tDEqYGaij+C3KpR4rWF68AlOy93IncZZlNtbS6Q08Cb6fymCrEkx7TiPLjdDhvQz84slza/Y/c6Adh5LmOqpxxUAZB7DafacIsUlo81T8HQ9RtictJyG+3IfPTOOEQoIh3Dn+SDv9NRUyP9dPkcxtIuPS6HcTfTyDk8BY4Bs0X7+y3A2DiN12S0mabrAdrm+On1k7vSE8rOnG4FEFyh4fc3VzlDcQKcBnrbD80kIO7yBp4i3/WZ4Li5j2bZt9BC0M04bl4/g0EQ== Received: from BL1PR13CA0030.namprd13.prod.outlook.com (2603:10b6:208:256::35) by DS7PR12MB8371.namprd12.prod.outlook.com (2603:10b6:8:e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Tue, 17 Oct 2023 08:10:36 +0000 Received: from MN1PEPF0000F0DE.namprd04.prod.outlook.com (2603:10b6:208:256:cafe::23) by BL1PR13CA0030.outlook.office365.com (2603:10b6:208:256::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.30 via Frontend Transport; Tue, 17 Oct 2023 08:10:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MN1PEPF0000F0DE.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Tue, 17 Oct 2023 08:10:36 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 17 Oct 2023 01:10:19 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 17 Oct 2023 01:10:16 -0700 From: Gregory Etelson To: CC: , =?utf-8?b?wqA=?= , , , Suanming Mou , Matan Azrad , Viacheslav Ovsiienko , Ori Kam Subject: [PATCH v3 10/16] net/mlx5: fix in shared counter and age template action create Date: Tue, 17 Oct 2023 11:09:22 +0300 Message-ID: <20231017080928.30454-11-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017080928.30454-1-getelson@nvidia.com> References: <20230927191046.405282-1-getelson@nvidia.com> <20231017080928.30454-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0DE:EE_|DS7PR12MB8371:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d24aafa-95b6-47cd-270b-08dbcee88afa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Df9xqriHP0jjZh4YNy2EP7oXow2JvtDUO7mfh78S66IK6SEkH/Wi2OgYiaJ/8QAFsjsodN7A9LVnGTLkNjZygs18Q7W1ph3/xtGmbonrSbc0AP/VTGNrqiTgobL2CgTqCY3IH07u08B07z3C40g021eKdj82/tfgszgAFGwGTQ1dkWfjhOgOQ/zmyEVC7IH9yIGZt9WmDQQPAmxLWOiU48ynEPG8HDLG6uclVk2+rl3FVDJ9Xh7r7mRyzFUZAL+vgjfyKxP357qK2SDmiSyXqRauSzkyVYyEnKBMj5pJBC12mCE2dJr4ij/ECtYnuD548xkj5Fg4xaAPwslUuPleYy+r9+M2VDtNX70tfBr0PN/3lFnaZn/4cY3LDIHTone3QVbXSIhdO9cNNOTYMsvRWwkYo9atuIDAOpmfK0DnyUhW8uVtuwDlAlfh3jZyTLzgm3xzyVVyjJJPYAujd4L8RfhaxfNYTbYfuxrzF88e24+1nSgp4YE8T5nlnvmB7XHRel1czXn8w978pNTetlqUgqJxiUzyjfWQxq6LOVhyhxj7qRcL07+8YJT3ychWDVM+bzjjkthJ2khmc/DEI3t7qalUnLS6XTLXqkiqo0u7VnPuGaUL8NroA+Zi/iGmgvFYCMTvLU+NiTfRi8MnbSF8fLTDlbEjVIpVjVCZK2CxDcWjNw6pzmYPzHjVyKxefpkFfzpa7iIQhrk1J2/VyCGynsvjT1ZUFRtK5zOPAO+HtssB1pmCohRawZpVbOa+fpgt X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(376002)(396003)(136003)(346002)(230922051799003)(451199024)(1800799009)(64100799003)(82310400011)(186009)(40470700004)(36840700001)(46966006)(41300700001)(70206006)(316002)(54906003)(6916009)(55016003)(36860700001)(40480700001)(40460700003)(2906002)(36756003)(70586007)(86362001)(356005)(82740400003)(7636003)(4326008)(8936002)(5660300002)(8676002)(450100002)(6666004)(7696005)(336012)(2616005)(107886003)(426003)(16526019)(6286002)(1076003)(26005)(83380400001)(47076005)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 08:10:36.0253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d24aafa-95b6-47cd-270b-08dbcee88afa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0DE.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8371 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Count and age actions in HWS template are translated into the same DR5 action. PMD maintains dedicated variable - `cnt_off`, that points action location in DR5 array. Currnet PMD did not initialize the `cnt_off` variable during shared counter / age actions initialization. Fixes: feb1f2fe2b76 ("net/mlx5: reformat HWS code") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 910d42a5f5..efb2d512b7 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -4680,10 +4680,12 @@ flow_hw_dr_actions_template_handle_shared(const struct rte_flow_action *mask, * Both AGE and COUNT action need counter, the first one fills * the action_types array, and the second only saves the offset. */ - if (*cnt_off == UINT16_MAX) + if (*cnt_off == UINT16_MAX) { + *cnt_off = *curr_off; action_template_set_type(at, action_types, action_src, curr_off, MLX5DR_ACTION_TYP_CTR); + } at->actions_off[action_src] = *cnt_off; break; case RTE_FLOW_ACTION_TYPE_CONNTRACK: