From patchwork Mon Oct 16 18:42:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 132646 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9181943181; Mon, 16 Oct 2023 20:44:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCCEB40ED9; Mon, 16 Oct 2023 20:43:41 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id E72684064E; Mon, 16 Oct 2023 20:43:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HWd7o7R8vv01auN0CT/dgfNrHb3g6yA8+NpdJ2NViakRlv0QY4PwI7x3JgGBpoFryF382RT/6KeO8fwYrSLIGAJB++KrCT5e/f+Upor5k8vBrlj8s/HxgWvvPrlSZWSWMImotjluejZHzCVRg0kGq5rWcChO+im4GfyFD+xOBQrBDiz+KMLJp6Xq0QVkbY29uUYtksfRjwvqkZXHkzYRgI5V+Ov+T4HcW5hulfhHYreNNhm93h6PwzgYZ+CCA7iM4s6LIBEZTFnW6NjxwbTAMciF/niuUuTGye+SDSdXkbxDMn75MvUT++6hzJpuZB1+yfW9AN66inuFJ5QSVHtCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NgThkY0e1k5bikIM/5gluhJS/yBqMXZKtYC5uaMjS1o=; b=oQcjFQ8YaVcAOEX/meTnh+kx4ENlNx61YYfQipaJQC18vzTV8uGfyL0hDFWhy9wsX6rYQVMWSZRHGrJ7BgJLp7/LCvjtSLZTumSCEUJGNaFOvVa/Ps1auleXY8VNya9a2knKf+0VbRHrvKZi5rP+GLQr7uSy2cPpRdwP5SlpT3B/G9y813clKNcoUnaSYH3Lu+MC93a4K6v52TpxGc9ekKr5M5AS3wv0/qCWzMuJyCSEWSvXp4GKR/wCw3WnOovI168C7sehJXkkGzptscanzFO/pEYsk6YEz0xxo7NM+kOtzZBc3JecaN9Pi23VbH3rB9Q18wWhBZvWIwqg9k/g0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NgThkY0e1k5bikIM/5gluhJS/yBqMXZKtYC5uaMjS1o=; b=IQRk4ifu+lFpJZFR0XvR5Q6yCFCoVGMQqs7P0jyZ3bClX5B8iI9jLuVmdnDo9pLIgKWEhHeHI3bDmpxYD5NPUDdARuDA0FpfTROHDfRnECMZ/2h7tDkj4dWARI1mCxkGVN1z5RsomD5mUYwQ9cQEpI4azOT27pNJMxaVpEJDMzq14NCZJ1UdDs4WP6PQOxu5aTIeW3semIKoUcCebEZ4DDTkvXUTFPuk4TQ48dWsvxanMa/qsJHJJzPh/FJ8wy+Y/0af94+Rzb+nLtERdvPMV15FyM8Y/QpAvMTkCYClmq5mHPtJnblxjzieWdMLCIjfDdsuBz0hYZKcu4V69MtH9A== Received: from SJ0PR03CA0344.namprd03.prod.outlook.com (2603:10b6:a03:39c::19) by PH7PR12MB5781.namprd12.prod.outlook.com (2603:10b6:510:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Mon, 16 Oct 2023 18:43:38 +0000 Received: from MWH0EPF000989E5.namprd02.prod.outlook.com (2603:10b6:a03:39c:cafe::72) by SJ0PR03CA0344.outlook.office365.com (2603:10b6:a03:39c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.29 via Frontend Transport; Mon, 16 Oct 2023 18:43:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MWH0EPF000989E5.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Mon, 16 Oct 2023 18:43:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 16 Oct 2023 11:43:22 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 16 Oct 2023 11:43:19 -0700 From: Gregory Etelson To: CC: , =?utf-8?b?wqA=?= , =?utf-8?q?=C2=A0_=2E_=2E_/patches/upstream-pmd-indirect-actions-list/v2/v2-?= =?utf-8?q?0000-cover-letter_=2E_patch?= , , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH v2 10/16] net/mlx5: fix in shared counter and age template action create Date: Mon, 16 Oct 2023 21:42:29 +0300 Message-ID: <20231016184235.200427-10-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231016184235.200427-1-getelson@nvidia.com> References: <20230927191046.405282-1-getelson@nvidia.com> <20231016184235.200427-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E5:EE_|PH7PR12MB5781:EE_ X-MS-Office365-Filtering-Correlation-Id: 10ec064b-333b-4f86-dd4d-08dbce77cfbc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CJQPY8MWxuBWzcIjlB2cuR0hYvOaLfbCn3LpeRoGuL23rm4xHP2HrRjaXMhp5wRZr8vgFUsnMyZ9hncDKAu90ZCnbLsCCnsq12Cg2sB6SLyehD7T5S6xHRifHY65w29sZMnVzZTtsxAYV5++gpZgo3fvKRgnBIRB3I67U6naJTLrQq8pkOYEiW+uEdkVTvD/6UIF26V8OqsGMlusK8myONOWK0LnIfem0lbkUH+6N5k1+zXtYv4qLmPvEt84E8OZdi+j+5/IRJH46Y1/G5o02wQPhPv6RAeczcog3VJPRE5PueBzACl0LLaYCec3mE7b3JBaKn+3lK3rxba1oW2RkStQqfiEw3H+r9f1lNedALJRGviXDUKZlOhSL8BTuik6lc13yIMhRn3edjgQ6c63+NgGDgc0t1K3FIUs+W7EmtcCe1cpG9aU5RjiwXlle879qwPriPLW/HRclvccmhIFYkuaKCVzjwjd+9RAIF7y9Y+F39o/jAffZWHdy6X/zzhio9Se7WCnzCdpa/oDKTR6jg29ndP800O9AtHIFUmCnQ7aGHQYSI55jQavDAvPBw2NxOqyIODl/ePPob1R5LXoguXcW3V26qFidW+l4t0VcgspNXBYVhpdytl39nMhTdm4uGSloSfpuilVqJoigJYhfvBdISGzWGRLo3/E4vN21I5DWpkRBTalRaTtNiRN+i3QycLwiK3rw24tn3V96o3HDt6HHTu2KDW5Y+yTh8Mdx73GFiU1r7OKHSybea9eTl1X X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(396003)(346002)(136003)(376002)(230922051799003)(64100799003)(1800799009)(186009)(82310400011)(451199024)(46966006)(36840700001)(40470700004)(478600001)(70586007)(47076005)(70206006)(6916009)(54906003)(6666004)(26005)(16526019)(107886003)(2616005)(336012)(41300700001)(6286002)(1076003)(316002)(426003)(7696005)(8676002)(8936002)(4326008)(2906002)(450100002)(5660300002)(36756003)(86362001)(7636003)(36860700001)(83380400001)(356005)(82740400003)(40460700003)(55016003)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 18:43:38.3185 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10ec064b-333b-4f86-dd4d-08dbce77cfbc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5781 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Count and age actions in HWS template are translated into the same DR5 action. PMD maintains dedicated variable - `cnt_off`, that points action location in DR5 array. Currnet PMD did not initialize the `cnt_off` variable during shared counter / age actions initialization. Fixes: feb1f2fe2b76 ("net/mlx5: reformat HWS code") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 910d42a5f5..efb2d512b7 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -4680,10 +4680,12 @@ flow_hw_dr_actions_template_handle_shared(const struct rte_flow_action *mask, * Both AGE and COUNT action need counter, the first one fills * the action_types array, and the second only saves the offset. */ - if (*cnt_off == UINT16_MAX) + if (*cnt_off == UINT16_MAX) { + *cnt_off = *curr_off; action_template_set_type(at, action_types, action_src, curr_off, MLX5DR_ACTION_TYP_CTR); + } at->actions_off[action_src] = *cnt_off; break; case RTE_FLOW_ACTION_TYPE_CONNTRACK: