From patchwork Mon Oct 16 18:42:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 132637 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F417D43181; Mon, 16 Oct 2023 20:43:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0F0F40299; Mon, 16 Oct 2023 20:43:09 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2086.outbound.protection.outlook.com [40.107.100.86]) by mails.dpdk.org (Postfix) with ESMTP id D513E40269 for ; Mon, 16 Oct 2023 20:43:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwcoOFIM64lGfH53ngZZAbo9DF5chd5hds8JvUO8U/2gZSJlfDMLJEMyMIluuyQLhAqSMj7eA43QfETcyDH/fvGc7pls+1Qj5bXSYZtCZGDLdRa56b5qGSfrBhzoNSOvmvQ4zPh0afSwpHsfjUc4aEEtlRXm7rfd1PeJEw7M/euKzT0ZkghLWBu+xvd4rtw3RmDL9Q/xMoBAs0j+9YM9z4dEgjL+wYNF9+6B2ddqhDi1xTXG69AWfxQkmZadVVltDflXcJH6Wx90LrCD+DsoonS8svpgAybARSSNV/dzLaLPu7gnvBTgyQCVUDaMVVW445hOkes2LBX9Mtn9SgtUXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MFN9xBubL7vMGWOlF3XPKXk3Hrir//kkRc7zpTo4elE=; b=AbkuWh0cIA1aQ6Q5ysciNGiKRIG9Q+gpCuUt/u129Rd2yGZE94pWATewY0GLNiDcEvPfwZjkkHQjCQ7dcml/wKCAou37CWVOmjlr9h5LIG64R6+lRMyf2WdSJc8IKFABLzWCydjhb6fEjR+nuoWOXaiYwUL+XsnqYWgKd7fmQXncpa0bvPXfCz67ShWTZwWLVkvBQO2qIKVHWkPU/JEohTac9m6nSTt7uQ9hdfqlG5qwi1HuE4DoWgxO8AIHS9LSl31cYQtlefb67G1wI/0JgeB7CxnUIX/Y7XJPzijc6FjKQ4CKqyU/b6EA5OoFVTvUz4POMJ8HbP8qRARR9xa6bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MFN9xBubL7vMGWOlF3XPKXk3Hrir//kkRc7zpTo4elE=; b=KmGOZ9kdsqGfNRhCLhVUp/IhdGC3DNNvEQVmPqaKwmI4XmgaFeyW5Zl9o2rTaK+1n02sVb9c9M5E0gZSDp5QDe2YXMy4k8pVxe0i73h4om/CaGrdagXPvtLQvoCyuF4KKDd65KlO5ilVGUvYCITVm6DdoEyHwe9Xm0j+goHMXPuTYJxXoyN3YPq8L04y6mrecS3wI+ubuEH6S11xsDhPhVc1tOn0ro+rdLhdU0P0ZrfFpiEor7D4B8UhH6NLCqH4C0w5C0UA0oJWOxG80Rz+xE3UzVqVmNfzzoh6CLhqNbpq1fz27oSZO7VWLV6N4HyRmPA2puirAWDXsbe0M9glxw== Received: from SA1P222CA0197.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c4::6) by LV3PR12MB9410.namprd12.prod.outlook.com (2603:10b6:408:212::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 18:43:06 +0000 Received: from SN1PEPF0002636C.namprd02.prod.outlook.com (2603:10b6:806:3c4:cafe::54) by SA1P222CA0197.outlook.office365.com (2603:10b6:806:3c4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36 via Frontend Transport; Mon, 16 Oct 2023 18:43:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002636C.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Mon, 16 Oct 2023 18:43:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 16 Oct 2023 11:42:52 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 16 Oct 2023 11:42:49 -0700 From: Gregory Etelson To: CC: , =?utf-8?b?wqA=?= , =?utf-8?q?=C2=A0_=2E_=2E_/patches/upstream-pmd-indirect-actions-list/v2/v2-?= =?utf-8?q?0000-cover-letter_=2E_patch?= , Hamdan Igbaria , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH v2 01/16] net/mlx5/hws: add support for reformat DevX object Date: Mon, 16 Oct 2023 21:42:20 +0300 Message-ID: <20231016184235.200427-1-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230927191046.405282-1-getelson@nvidia.com> References: <20230927191046.405282-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636C:EE_|LV3PR12MB9410:EE_ X-MS-Office365-Filtering-Correlation-Id: 68838d7d-94b0-4c63-cf4f-08dbce77bc51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GD0o3c0be4ct5kN9wSVPo8SSPX0cSuzBFk4u4SVKalI0S/dT+Tzgu2ViY+2GG6yN1GO+klluqWGMRNc/eVmYUqrUE1uEj1bKDuZj4+i08JzfRamZC3Tly5NAWpkeFz1oxjATYvYD4qi3oDD0pI6iDkI4EbGH5EfOnF4V4biKBUE7tWzwNCDQSSLSixTHbLhAJrRsEIhedBIvXwZHJcVMCiTZg+2hB2dfNDcwpEz/LzpuWEc3DMdfrOM5yfuWSCmVzCj1FqRG7XhI2GiBhmIYHol19ImMaciUks2zujKKmVOjMJHmDO/4BhiO4X5h/98ZvvHHGJnIdLA6AGM2q6ABM3JQ02C+vG3szQ2ihOrcj6PGuanD/mDLfJ7wuHSR0D55edOf18LnRttruyDqLWhQ8mNurbNuDShsA0wtxT1cP4nGfEEQPfK0bcE/InfaomIaQryY2Sa3dNfRAA4fUx1VyFsuanuMz7umkqrXtrmD3oC4zY694KJcvEABr9tiBXhFDWyh0/FeurhyYRv2msZVqWRoxCqA+XqqAPv+MvJJeLnNgFHGR1HvH2d5pGJ/38GkVo6xCBq27p1xim1FvwYU6xA71A8QAoutVi+sdIFTXa1I+0oWz/cVRSzTInUzaWhk8QL6bXQ6sPs2sGGF0eYBf7HkSmKnY77sXqORR9e2iSLv8gsjrEQiUY32+AzKGFsLHCkif428ARE0eFMpPqjPkFzBb1GjeC++JcE8sUtkih6mHzJrw87a7JRyBjAulziO X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(136003)(39860400002)(396003)(230922051799003)(1800799009)(451199024)(82310400011)(186009)(64100799003)(40470700004)(46966006)(36840700001)(47076005)(40460700003)(36860700001)(55016003)(7696005)(6916009)(316002)(54906003)(478600001)(70206006)(70586007)(5660300002)(8936002)(8676002)(4326008)(6666004)(2616005)(86362001)(41300700001)(2906002)(66899024)(40480700001)(82740400003)(16526019)(6286002)(107886003)(1076003)(26005)(336012)(426003)(356005)(83380400001)(7636003)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 18:43:05.7559 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68838d7d-94b0-4c63-cf4f-08dbce77bc51 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9410 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hamdan Igbaria Add support for creation of packet reformat object, via the ALLOC_PACKET_REFORMAT_CONTEXT command. Signed-off-by: Hamdan Igbaria Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h | 39 +++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_cmd.c | 60 ++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_cmd.h | 11 +++++ drivers/net/mlx5/hws/mlx5dr_internal.h | 5 +++ drivers/net/mlx5/hws/mlx5dr_send.c | 5 --- 5 files changed, 115 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 6e181a0eca..4192fff55b 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -1218,6 +1218,8 @@ enum { MLX5_CMD_OP_CREATE_FLOW_GROUP = 0x933, MLX5_CMD_OP_SET_FLOW_TABLE_ENTRY = 0x936, MLX5_CMD_OP_MODIFY_FLOW_TABLE = 0x93c, + MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT = 0x93d, + MLX5_CMD_OP_DEALLOC_PACKET_REFORMAT_CONTEXT = 0x93e, MLX5_CMD_OP_ALLOC_FLOW_COUNTER = 0x939, MLX5_CMD_OP_QUERY_FLOW_COUNTER = 0x93b, MLX5_CMD_OP_CREATE_GENERAL_OBJECT = 0xa00, @@ -5191,6 +5193,43 @@ struct mlx5_ifc_modify_flow_table_out_bits { u8 reserved_at_40[0x60]; }; +struct mlx5_ifc_packet_reformat_context_in_bits { + u8 reformat_type[0x8]; + u8 reserved_at_8[0x4]; + u8 reformat_param_0[0x4]; + u8 reserved_at_16[0x6]; + u8 reformat_data_size[0xa]; + + u8 reformat_param_1[0x8]; + u8 reserved_at_40[0x8]; + u8 reformat_data[6][0x8]; + + u8 more_reformat_data[][0x8]; +}; + +struct mlx5_ifc_alloc_packet_reformat_context_in_bits { + u8 opcode[0x10]; + u8 uid[0x10]; + + u8 reserved_at_20[0x10]; + u8 op_mod[0x10]; + + u8 reserved_at_40[0xa0]; + + u8 packet_reformat_context[]; +}; + +struct mlx5_ifc_alloc_packet_reformat_out_bits { + u8 status[0x8]; + u8 reserved_at_8[0x18]; + + u8 syndrome[0x20]; + + u8 packet_reformat_id[0x20]; + + u8 reserved_at_60[0x20]; +}; + /* CQE format mask. */ #define MLX5E_CQE_FORMAT_MASK 0xc diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 594c59aee3..0ccbaee961 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -780,6 +780,66 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx, return devx_obj; } +struct mlx5dr_devx_obj * +mlx5dr_cmd_packet_reformat_create(struct ibv_context *ctx, + struct mlx5dr_cmd_packet_reformat_create_attr *attr) +{ + uint32_t out[MLX5_ST_SZ_DW(alloc_packet_reformat_out)] = {0}; + size_t insz, cmd_data_sz, cmd_total_sz; + struct mlx5dr_devx_obj *devx_obj; + void *prctx; + void *pdata; + void *in; + + cmd_total_sz = MLX5_ST_SZ_BYTES(alloc_packet_reformat_context_in); + cmd_total_sz += MLX5_ST_SZ_BYTES(packet_reformat_context_in); + cmd_data_sz = MLX5_FLD_SZ_BYTES(packet_reformat_context_in, reformat_data); + insz = align(cmd_total_sz + attr->data_sz - cmd_data_sz, DW_SIZE); + in = simple_calloc(1, insz); + if (!in) { + rte_errno = ENOMEM; + return NULL; + } + + MLX5_SET(alloc_packet_reformat_context_in, in, opcode, + MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT); + + prctx = MLX5_ADDR_OF(alloc_packet_reformat_context_in, in, + packet_reformat_context); + pdata = MLX5_ADDR_OF(packet_reformat_context_in, prctx, reformat_data); + + MLX5_SET(packet_reformat_context_in, prctx, reformat_type, attr->type); + MLX5_SET(packet_reformat_context_in, prctx, reformat_param_0, attr->reformat_param_0); + MLX5_SET(packet_reformat_context_in, prctx, reformat_data_size, attr->data_sz); + memcpy(pdata, attr->data, attr->data_sz); + + devx_obj = simple_malloc(sizeof(*devx_obj)); + if (!devx_obj) { + DR_LOG(ERR, "Failed to allocate memory for packet reformat object"); + rte_errno = ENOMEM; + goto out_free_in; + } + + devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, insz, out, sizeof(out)); + if (!devx_obj->obj) { + DR_LOG(ERR, "Failed to create packet reformat"); + rte_errno = errno; + goto out_free_devx; + } + + devx_obj->id = MLX5_GET(alloc_packet_reformat_out, out, packet_reformat_id); + + simple_free(in); + + return devx_obj; + +out_free_devx: + simple_free(devx_obj); +out_free_in: + simple_free(in); + return NULL; +} + int mlx5dr_cmd_sq_modify_rdy(struct mlx5dr_devx_obj *devx_obj) { uint32_t out[MLX5_ST_SZ_DW(modify_sq_out)] = {0}; diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 8a495db9b3..f45b6c6b07 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -155,6 +155,13 @@ struct mlx5dr_cmd_allow_other_vhca_access_attr { uint8_t access_key[ACCESS_KEY_LEN]; }; +struct mlx5dr_cmd_packet_reformat_create_attr { + uint8_t type; + size_t data_sz; + void *data; + uint8_t reformat_param_0; +}; + struct mlx5dr_cmd_query_ft_caps { uint8_t max_level; uint8_t reparse; @@ -285,6 +292,10 @@ mlx5dr_cmd_forward_tbl_create(struct ibv_context *ctx, void mlx5dr_cmd_forward_tbl_destroy(struct mlx5dr_cmd_forward_tbl *tbl); +struct mlx5dr_devx_obj * +mlx5dr_cmd_packet_reformat_create(struct ibv_context *ctx, + struct mlx5dr_cmd_packet_reformat_create_attr *attr); + struct mlx5dr_devx_obj * mlx5dr_cmd_alias_obj_create(struct ibv_context *ctx, struct mlx5dr_cmd_alias_obj_create_attr *alias_attr); diff --git a/drivers/net/mlx5/hws/mlx5dr_internal.h b/drivers/net/mlx5/hws/mlx5dr_internal.h index c3c077667d..3770d28e62 100644 --- a/drivers/net/mlx5/hws/mlx5dr_internal.h +++ b/drivers/net/mlx5/hws/mlx5dr_internal.h @@ -91,4 +91,9 @@ static inline uint64_t roundup_pow_of_two(uint64_t n) return n == 1 ? 1 : 1ULL << log2above(n); } +static inline unsigned long align(unsigned long val, unsigned long align) +{ + return (val + align - 1) & ~(align - 1); +} + #endif /* MLX5DR_INTERNAL_H_ */ diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index e58fdeb117..622d574bfa 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -668,11 +668,6 @@ static int mlx5dr_send_ring_create_sq_obj(struct mlx5dr_context *ctx, return err; } -static inline unsigned long align(unsigned long val, unsigned long align) -{ - return (val + align - 1) & ~(align - 1); -} - static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, struct mlx5dr_send_engine *queue, struct mlx5dr_send_ring_sq *sq,