From patchwork Mon Oct 16 15:17:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 132636 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E0444317F; Mon, 16 Oct 2023 17:17:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1EA940A6B; Mon, 16 Oct 2023 17:17:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 65EDB40269; Mon, 16 Oct 2023 17:17:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697469443; x=1729005443; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=d95ZXuzORLrjdQtCFMd6Gkz9BPPoXF2k2YNFMz6m73w=; b=ONYeGpTRP6axtiJCk/oWeD2SWClLN/IolONjVIGvnvcryZx8d/QHAby5 NJRuGvQts0I6+oeTq5O936zXItP+q+Lldrqy700tfenSlSFWkilFvagTc sfofS4Z1kNUPDFzLJKZqCk73/guc2bsr+m+8pD48PDk6ZYbP01Fbi2P+c XOBF9EW2Q9hPUYB+MMSnJq+KVLzjkPZ6c0bGAYRSs5ikCgFiBcFeRVNOJ 3HiWkZeq7jTGX1QyFynsE9/elwJ6SIwqggxNiMWYqU/qTmSlXxec92lVr lR0IJkrBqkE5PQsj8qoHhHkhXFCxwns8OvyN4vlC8VjuZUcbsX3tE1Bok Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="389415327" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="389415327" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 08:17:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="3676695" Received: from silpixa00401385.ir.intel.com ([10.237.214.154]) by fmviesa001.fm.intel.com with ESMTP; 16 Oct 2023 08:17:27 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org, Harry van Haaren , Jerin Jacob Subject: [PATCH] event/sw: fix missing device pointer Date: Mon, 16 Oct 2023 16:17:13 +0100 Message-Id: <20231016151713.711965-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org After calling rte_event_dev_info_get() the ".dev" field of the info structure should have a pointer to the underlying device, allowing the user to e.g. get the device name using using rte_dev_name(info.dev). The SW eventdev info structure did not return a correct device pointer, though, instead returning NULL, which caused crashes getting "rte_dev_name". Initializing the dev pointer inside the "eventdev" struct in the device probe function fixes this by ensuring we have a valid pointer to return in info_get calls. Fixes: aaa4a221da26 ("event/sw: add new software-only eventdev driver") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 6d1816b76d..bf166a8cfc 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -1080,6 +1080,7 @@ sw_probe(struct rte_vdev_device *vdev) SW_LOG_ERR("eventdev vdev init() failed"); return -EFAULT; } + dev->dev = &vdev->device; dev->dev_ops = &evdev_sw_ops; dev->enqueue = sw_event_enqueue; dev->enqueue_burst = sw_event_enqueue_burst;