From patchwork Fri Sep 29 02:08:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 132171 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC42B42668; Fri, 29 Sep 2023 04:09:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4A9440697; Fri, 29 Sep 2023 04:08:46 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2098.outbound.protection.outlook.com [40.107.220.98]) by mails.dpdk.org (Postfix) with ESMTP id 0F42E40693 for ; Fri, 29 Sep 2023 04:08:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Onn4gt/s7nakXkdgyURmxbJmTtkSnHaiVVUskLwiyrYObjbHz8xaABrQAb/6YfGkyzn2UkV/hgHRqpHQdgTrKk7xuyXYcqC3mrIQqyMwXqZ5QhgWKzzMeMez64LAleB6mXymqKgq0hyVoFuP7Tu2MTS+CM378aBoiFRlth7Z797qRUzLxO+wHlRGk+v0EpHsc3dB+aEAS9204y0JjlwaSNSuPTQEOqYz6Ndfjm1eBH0k/hZ1y9keL3p+yRDFuuaRWZyw1zIefqXtAyE5rrlhqVV8e9Vtp14Up3xMvxXJrgHuBwiHQxZBKzkAginR4ph4LHNITNBj1M/yHHqDv0u12A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGu7lKbyde53E87VaYe0KZy+PPxSlCmpb0x2wpL9FrU=; b=DG6UuC9Gp5wr7JKUgIlaNk7pGwVVLCwaVpG0bXa4cQFJYZgewl1HPM/SX2OikS3HMHHHRylbCPK7eduzjZKQlhBiS9hY6ul0eDrLtWTK6gi05WMe5a6h40Yc+nqcZuZUj3FctwFNI/SnGk/HFxPmbvKk2jvDDZUSN8mnxy8e9oYOWFEzokqbipkKiPws8WkwQY6Pb9coHQXm0/mkh8gSfZ7wCTwvyPAFcm6gM/yB6ROVUgwtW8sR0+ppfOnwxfgg8gNJ3jMfe2BcuEdE11HyvyeQJ/ANpR9H7j1sbUWPu7GCZFFShJ0Xl3UlgyigSAIA8UtZulWh2iCfTseKSo7KOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGu7lKbyde53E87VaYe0KZy+PPxSlCmpb0x2wpL9FrU=; b=NCAgt+s9D4P3DVkV7fthgzVgYJl5awSctOe95bXSSgbf024583zU2PhzE+W1KRWk1GA7ZGPoJ//Jlv4IZnlU+8lnci5IBDzR+sWJ+t+O9QJ8B6OdOoedZb6vw6ZlHXPB+SWzItv73sDgTvf1cvOsXeus7FgtNHQfnQ3Vexjphn8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CO3PR13MB5687.namprd13.prod.outlook.com (2603:10b6:303:17a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.19; Fri, 29 Sep 2023 02:08:43 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::28c0:63e2:ecd1:9314]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::28c0:63e2:ecd1:9314%4]) with mapi id 15.20.6813.027; Fri, 29 Sep 2023 02:08:42 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Shihong Wang , Chaoyong He Subject: [PATCH v3 5/9] net/nfp: get IPsec Rx/Tx packet statistics Date: Fri, 29 Sep 2023 10:08:06 +0800 Message-Id: <20230929020810.1219391-6-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230929020810.1219391-1-chaoyong.he@corigine.com> References: <20230926024959.207098-1-chaoyong.he@corigine.com> <20230929020810.1219391-1-chaoyong.he@corigine.com> X-ClientProxiedBy: PH8PR07CA0028.namprd07.prod.outlook.com (2603:10b6:510:2cf::23) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|CO3PR13MB5687:EE_ X-MS-Office365-Filtering-Correlation-Id: 3dba38a2-38d2-400b-9485-08dbc091011d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fw8hYjs4AUu7Fv1ItMhlsN2nAneECrHs6AzTpoxnopNy8nIIJY0/nwaWZuaqZj828NOqsukJyFzBhk0QGY0l0nVAgUJR/ssWSVqLsyymXHxI4MKVC0E6QlPrqs057ztohdeBm6aSCGoPYMJAt0HBBAYgu3bTc56fnkThdpXPfMcnfkrBhd9VwnDxuQKkeKBclNJmEvczaq3Zp6OaK0aBcnroBCqLsut0QQkQP5Du+u+Z5DE2Q+9nzsG9xXd+egtoAxj0tmtlbGMBg2wQQT7h2t30snS0s0zo0t4yZKNlo2MB/ba4shRQyRHr1ouPnogL5PIs6ihjvamnujcF6taB/tRVQ836oDdO8WH4cbr/bgHYePREwXNJaLY1MmnolCEHzVBBdUnzEBmUu3DysBeIfCqMZlYi05GpxKGimpLRzTd2fh/0AHtAU7PRugh1QDnrC0YOk7r1d2iyXB0QPn1W0BBoNdic7OXEegXj9w7xrDuRRuDCga9Z06w+tE74UEvb3XCsbgzS57UFFmmJGw21RD6MinQfsRlV4goSfjUcFKy9xCx5NCfBY+NVA1u5s3sFpG10k4zZkXQm9TWlBu0HqUEjTYfHqb73KQo2wZ0JFkCts8oPLRq/x8zTBfBCbct0OafUhdz21SdxL5sm1fOGv8L7qtS7MX3UV69Lq0YaJvo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(396003)(376002)(39830400003)(136003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(2906002)(6916009)(316002)(54906003)(66946007)(66556008)(66476007)(44832011)(8936002)(8676002)(4326008)(41300700001)(5660300002)(2616005)(83380400001)(107886003)(1076003)(26005)(36756003)(86362001)(38100700002)(38350700002)(52116002)(6666004)(478600001)(6486002)(6512007)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4GI91Y815fwIoyJgMxUUtmb6YoI2zivAw3bzr4AuHKbBdkVDoJIgGL/XtDq12QBm0nVL0ZHlGZX1ty5w1JIr3Kw0SQ6kcPkt49IEHdDyRun6x2C28Z3ZODBYKOHQ1gZfN7JS/rT07gQUHR/G1bN/bR7jq0CKgvcY4YDnNxFsrr9gQFmNY0uje7dZuQ4kaHRb0KSPiPEEs1nQ7DWk1Xo3GWPyn/Dfm5h6l59YbCJE/2SmhZRSGhufce87d0/UMyfEys6f+1N7kw4/3Ok9ASxmtG5hJ2uii8cUjPiIs0LNP9jo47vatNQOO8h6JH45W2YaMqHbae419nvxPVW4PeookTiIavS2jcor+QLms/QKEtHSwVbvzSJDbjoWUf7xGHg70YTPkeUMYf94usViiN2zpABBogku9JWB9wIeGdnru0uyaN3OSKSn5PMbv5X10q5BrQ16GpVgtoFih48cy0hAo6xCP3P+CsSjlcmU6HfxsF1cTrFvd5mQk4Bk8GPjT0R3J/MyawKYJLLeV0KCo5ciRNA2YHv3l03L+edyk1w/8pX8dtUeoocG6JtWLqk/AeNO5PxP1RYj+9mrbMSmTPO+VJupmlLaHte7ivJRpJuu5JwP5Jzv8680uHW4i8M2gz6Qt5FZ6dU+4Q9gCFrL/XWZsE4yp71bOksZW6rbMFl+p21uBHsiWc1wiG74qwAM+4tMZSe5a83G1gtpcYK6Ifxlzi8Qa81edRvoKku7WAb2pyvOUntQ4qT71vIMF18LWee7T1rFzfAYZQ2Fu+qmWm7w4T/w4B0rX2B53VyvvvSZTv/Ox0Mn8C0roVBG332otI4NHUPBHymnlzK212/8uPEj9KHlcfzR96JF4kIkQPsrfHaiaZQ+1pn2/VqDc+lnJSFbYREh6ZyTjmoxXly/AYCKpeyTxO96nPsTrDBDqJURJKe5N+bE9xuJzDoYk0Gn2lgDPTkIoVzyeTB1qP7QuRg64oZj5P9JY2wt9kYpRd/4u9e7o+4MZ+ZRWeY+SK8RktnKXskHC37UNfx4a/GzVQFBduFeW+4bpMAz4i23vAXkzKPe9NirBC/8fIGR/WtQkGA2Cbzuw9agGMxeAxx+1fPJPOT4dE8EHyHxL5e7cXajbhnf5DlPuyNtz052FjoBka39DSCxwFG22i7fEP8bNVCOgpYznUwvAYuHh0j0ORKYTlMduNld9UiklJNQAFM09PwuLSJ0kddFkWjBCKKMs+JS6rihgKTU0ht17pNpx4qk1GzvtyHT5JIlyaNOgIplI74+IiSeF+C0T4ASV4tq4+ZcIloNvo6tbJLjVjhon3/6CVzODfMmR6FAj5Y9yF8jP99yDLKkdpYyvXXRgnjpnNenneVB5hNbUmyAqcy3fAfAONjzf1DNOG0dYYYZj/miBvK6VlXMFOxjokyPtw98nHO/PvSq8KSpKLV4gKB2Xgl3CkHLuc+H5HEeFjctZg0gPZq65Wxfwxs/kz2/eIn9r3wnRmyApuBi6YgCGzSEgg/FyXYm4okfIkAKbDW/sa0yllDih/NRCfHCBtid4qrSRzepsa89sRMQcjLfUOInrg5YoroAJIWtc5kKoLG9AbfH6L550KwPDndL4NVIj7ZFwM4RPA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dba38a2-38d2-400b-9485-08dbc091011d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 02:08:42.7340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KBPYHtJA+92MH5mBKzWNvyHlezYoEqfSEnFQiG1rPwBPmRJc7DuGeIeq1bf1Fro3JkvIw0OLfgxYUq5ve7YBbdRQwnEoyeN7bZr4AkQtXv0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5687 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shihong Wang IPsec packet processing is mostly carried out in hardware. The hardware statistics on successful packets and discarded packets. The driver can obtain these statistics by Mailbox. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 149 ++++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 51770def9d..d4292c3b90 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -356,6 +356,154 @@ static const struct rte_security_capability nfp_security_caps[] = { } }; +/* IPsec config message cmd codes */ +enum nfp_ipsec_cfg_msg_cmd_codes { + NFP_IPSEC_CFG_MSG_ADD_SA, /**< Add a new SA */ + NFP_IPSEC_CFG_MSG_INV_SA, /**< Invalidate an existing SA */ + NFP_IPSEC_CFG_MSG_MODIFY_SA, /**< Modify an existing SA */ + NFP_IPSEC_CFG_MSG_GET_SA_STATS, /**< Report SA counters, flags, etc. */ + NFP_IPSEC_CFG_MSG_GET_SEQ_NUMS, /**< Allocate sequence numbers */ + NFP_IPSEC_CFG_MSG_LAST +}; + +enum nfp_ipsec_cfg_msg_rsp_codes { + NFP_IPSEC_CFG_MSG_OK, + NFP_IPSEC_CFG_MSG_FAILED, + NFP_IPSEC_CFG_MSG_SA_VALID, + NFP_IPSEC_CFG_MSG_SA_HASH_ADD_FAILED, + NFP_IPSEC_CFG_MSG_SA_HASH_DEL_FAILED, + NFP_IPSEC_CFG_MSG_SA_INVALID_CMD +}; + +static int +nfp_ipsec_cfg_cmd_issue(struct nfp_net_hw *hw, + struct nfp_ipsec_msg *msg) +{ + int ret; + uint32_t i; + uint32_t msg_size; + + msg_size = RTE_DIM(msg->raw); + msg->rsp = NFP_IPSEC_CFG_MSG_OK; + + for (i = 0; i < msg_size; i++) + nn_cfg_writel(hw, NFP_NET_CFG_MBOX_VAL + 4 * i, msg->raw[i]); + + ret = nfp_net_mbox_reconfig(hw, NFP_NET_CFG_MBOX_CMD_IPSEC); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to IPsec reconfig mbox"); + return ret; + } + + /* + * Not all commands and callers make use of response message data. But + * leave this up to the caller and always read and store the full + * response. One example where the data is needed is for statistics. + */ + for (i = 0; i < msg_size; i++) + msg->raw[i] = nn_cfg_readl(hw, NFP_NET_CFG_MBOX_VAL + 4 * i); + + switch (msg->rsp) { + case NFP_IPSEC_CFG_MSG_OK: + ret = 0; + break; + case NFP_IPSEC_CFG_MSG_SA_INVALID_CMD: + ret = -EINVAL; + break; + case NFP_IPSEC_CFG_MSG_SA_VALID: + ret = -EEXIST; + break; + case NFP_IPSEC_CFG_MSG_FAILED: + /* FALLTHROUGH */ + case NFP_IPSEC_CFG_MSG_SA_HASH_ADD_FAILED: + /* FALLTHROUGH */ + case NFP_IPSEC_CFG_MSG_SA_HASH_DEL_FAILED: + ret = -EIO; + break; + default: + ret = -EDOM; + } + + return ret; +} + +/** + * Get discards packet statistics for each SA + * + * The sa_discard_stats contains the statistics of discards packets + * of an SA. This function calculates the sum total of discarded packets. + * + * @param errors + * The value is SA discards packet sum total + * @param sa_discard_stats + * The struct is SA discards packet Statistics + */ +static void +nfp_get_errorstats(uint64_t *errors, + struct ipsec_discard_stats *sa_discard_stats) +{ + uint32_t i; + uint32_t len; + uint32_t *perror; + + perror = &sa_discard_stats->discards_auth; + len = sizeof(struct ipsec_discard_stats) / sizeof(uint32_t); + + for (i = 0; i < len; i++) + *errors += *perror++; + + *errors -= sa_discard_stats->ipv4_id_counter; +} + +static int +nfp_security_session_get_stats(void *device, + struct rte_security_session *session, + struct rte_security_stats *stats) +{ + int ret; + struct nfp_net_hw *hw; + struct nfp_ipsec_msg msg; + struct rte_eth_dev *eth_dev; + struct ipsec_get_sa_stats *cfg_s; + struct rte_security_ipsec_stats *ips_s; + struct nfp_ipsec_session *priv_session; + enum rte_security_ipsec_sa_direction direction; + + eth_dev = device; + priv_session = SECURITY_GET_SESS_PRIV(session); + memset(&msg, 0, sizeof(msg)); + msg.cmd = NFP_IPSEC_CFG_MSG_GET_SA_STATS; + msg.sa_idx = priv_session->sa_index; + hw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private); + + ret = nfp_ipsec_cfg_cmd_issue(hw, &msg); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to get SA stats"); + return ret; + } + + cfg_s = &msg.cfg_get_stats; + direction = priv_session->ipsec.direction; + memset(stats, 0, sizeof(struct rte_security_stats)); /* Start with zeros */ + stats->protocol = RTE_SECURITY_PROTOCOL_IPSEC; + ips_s = &stats->ipsec; + + /* Only display SA if any counters are non-zero */ + if (cfg_s->lifetime_byte_count != 0 || cfg_s->pkt_count != 0) { + if (direction == RTE_SECURITY_IPSEC_SA_DIR_INGRESS) { + ips_s->ipackets = cfg_s->pkt_count; + ips_s->ibytes = cfg_s->lifetime_byte_count; + nfp_get_errorstats(&ips_s->ierrors, &cfg_s->sa_discard_stats); + } else { + ips_s->opackets = cfg_s->pkt_count; + ips_s->obytes = cfg_s->lifetime_byte_count; + nfp_get_errorstats(&ips_s->oerrors, &cfg_s->sa_discard_stats); + } + } + + return 0; +} + static const struct rte_security_capability * nfp_crypto_capabilities_get(void *device __rte_unused) { @@ -370,6 +518,7 @@ nfp_security_session_get_size(void *device __rte_unused) static const struct rte_security_ops nfp_security_ops = { .session_get_size = nfp_security_session_get_size, + .session_stats_get = nfp_security_session_get_stats, .capabilities_get = nfp_crypto_capabilities_get, };