From patchwork Tue Sep 26 02:49:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 131905 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9010A4263C; Tue, 26 Sep 2023 04:51:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51B6D402E6; Tue, 26 Sep 2023 04:50:44 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2101.outbound.protection.outlook.com [40.107.93.101]) by mails.dpdk.org (Postfix) with ESMTP id 605BF4064A for ; Tue, 26 Sep 2023 04:50:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ACHOMrcsVpQsZrR43ykX1PjKENNKAd724PBDekCvdXLZmR+uyYeazMpyJvhQ/urUql/S7Fib++5ebwUNN+Tk3kpG9Ps0cBOKAyCOoOjveqZQpHnNd/OYClk5EYvHlL90jSivZrlSwSLDs08Vu7rgnwwr7uu1qOvHdboF95kxif8j02jNeXLwUmzBUzxMwd/6MXAlxHkh19Uu84RODh/XQI+/su8zwFeRBwMjy0bscYwHCDn/eQZQZJ9ZvURxS1bLx0Go+MFz8IqijIQvd5+8mHC+V5vGOW+DMynKuZiLm4gjE+v9J8oiaq44BgPLxIqoRw7Y4+XES1Ki5gNxg9olIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGu7lKbyde53E87VaYe0KZy+PPxSlCmpb0x2wpL9FrU=; b=KkZK5XBXNFNi+XnoaiMlTwG9f1QFNpTIYvEs4KTyHpJVWQeshZoG2P3ho2IGNyfASGrX4xdaYmh5vSPQyMnpCa2RVGtpjpXI/a6mC3grsj1PXmd0SWdkNWR70T29jWiL7WnHvotdvgGeICFjETkf3hfbscNH1vP/B7tSy8kLK/fVQUeOsy1KbXgWfRoe4MUtpyrIeEd0rvfJeW6KtUHZ/8AUwvJXvytSkl+LWaUWQkVDRNPngPxRy4uyHrmpeMGvofI9C0PZWF4QvZneS0bU24Upaq578Oa1DMARrrLB0e2mfEWYDOsP9nvPvHaMOvfAgzQ9Bb/eRr56tJJleBB/mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGu7lKbyde53E87VaYe0KZy+PPxSlCmpb0x2wpL9FrU=; b=oivkJND/zhVP5ttLOAqGH8tPL+QbMb2sx1N5dSjciSMbbHCYUWvCz4JGfYt4cmqE8IFvnCukMfpFkvagi7AN6L3jNw4x0QUJ0a0UpIa4zWJihwszUs0lEP95z63X28jteKv3nJDB64UPWyD/FLk61G2k7W+9SG4StL2uM9eLA+o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) by SA3PR13MB6516.namprd13.prod.outlook.com (2603:10b6:806:39c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Tue, 26 Sep 2023 02:50:40 +0000 Received: from PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::b070:92e1:931e:fee7]) by PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::b070:92e1:931e:fee7%4]) with mapi id 15.20.6792.026; Tue, 26 Sep 2023 02:50:40 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Shihong Wang , Chaoyong He Subject: [PATCH v2 06/10] net/nfp: get IPsec Rx/Tx packet statistics Date: Tue, 26 Sep 2023 10:49:55 +0800 Message-Id: <20230926024959.207098-7-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230926024959.207098-1-chaoyong.he@corigine.com> References: <20230925060644.1458598-1-chaoyong.he@corigine.com> <20230926024959.207098-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR05CA0020.namprd05.prod.outlook.com (2603:10b6:a03:c0::33) To PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB5568:EE_|SA3PR13MB6516:EE_ X-MS-Office365-Filtering-Correlation-Id: 81b8a8d8-f8ee-4ef5-d215-08dbbe3b5ec0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nlS6z4Ur4yJISAC2XfQWoA6qKkvgBG9FafYqiDxx+9DRDr2cS5weXWwKwPfBQ+3gW50Q1kEyDFAA9x1TkYThfRxAPT9/izJZnr9dYSOQAG2q4jlJkAi4jdre+yTCxuffY4VF9sxl4bpKJYpOKcEmQiKkx7adzKJTIDzZd1GpOAmJN2DykHRkaI+F0IIaqK6oV9gG1v4xuZWnP6nnI+364MqEhA83T68LB7dTats6xIZ84gRkBcRvwfKkLcEo6LymyMEv9LqiL6/6eYA9Zl+Vf9F1I4K3121rUntq4Mcssl+CnJ0NVE2sX4PBvqSdPAg985UzkPTDz6wrevfVlvU1qpvRvEo7VB4ZJo5xQzrQD2z8v7rolxZWg93Rzt3psM85lkzPtnkyh1Gkk/qAbiXlkt0OiyXUlNGcv0g6y+WAKtMFvSud+RnHVli3r7Dk+A5/B86ECTCYff21l6yHq9CaXMaULlbvvkOSsArAmYH7lN4U8e6b7X3dHZ/lkGB5SNGx5mJB515PdcDxx+RmDtkCtdIdaLmnE4CEFV//YQAhT7cBjKu+cDoUhB1G7GCZPXMgtTuyAs1cJCVD/V2Wg7gLNvhTkpGewYov6UDFQUEZDZGYvluVVlO9tQTRxQP37IHnDsJQPJ6XInMqgVpzY0pEhfuIZ2vytmenqhOAEs6Csm4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR13MB5568.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(136003)(366004)(346002)(396003)(376002)(230922051799003)(1800799009)(451199024)(186009)(4326008)(83380400001)(2616005)(6486002)(6506007)(52116002)(478600001)(6666004)(86362001)(36756003)(38100700002)(1076003)(26005)(66476007)(8936002)(66556008)(6916009)(6512007)(2906002)(38350700002)(66946007)(41300700001)(107886003)(316002)(44832011)(8676002)(5660300002)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kRygr4fHFGJ9gKE8NGnyPrbhVO9fQ52gycIkjip9WSVBHqbQLbzNkzXcynDMqM1yqNgj5dNQuMeP9s+BybBVkTr7e2SJWhEboAMLa8/7esGfGrZZj8LcU5LWxsxoOcVGOXA8Ltn9K+XEqHACnIesLFmMuEzZNRbokeJtMSZoLZw84hrzv+md+JHDh5NjG9E2jltHzMHlPgffoUMfQK/DIogLpmXyeBC8BPc1jLkbB8b/G4THJH6V7ZlGrH1XN6IS3N6m8xOs12/FznU0uLGN83s8JvdA3R6prLME8SWCc3e3VQr0H9SBJjSKnAndsvaazPw8QQfIK+USlsraogdmymbIX6lyY6bC8rFM1cO+hcj/qO7wj4lfRtMfoao65mBqHkoOtdoDxTvpNknsuH/VMRzp0NGAnz2lbiioMXZQQzUZrlEm5t6xb9KqN/gJPrlYD62ScEfYuM8u977E5vG+7/UVUpgMCq6XlHnqPmIBwItMKDR9dXKPzHxbDHXbZTBW3MtwaOb+J0ArJGfdu/cnSvNou0UlOah6ZwtmsDlgPhr718SY2ZFTUuxM/2fmYbEk0YvCS/e03a52kJfpzed2vFGq9tt1R4XlYYYxbFiplj4+MSuIZeDllH1HbeB+8JKBP/YkH26GhWlGRrWqllUHA46GmdGBFT6feonR5BXe7XJSXp//RJKgJFShMyeLJ2zRr0hYgMqadSoAwncadK+yivjCU+nsYbtdL9BZ3Fq1WFE4wlch4nJ5krhgiROBnt0G9Cooi2kMW2qE7rJlJGuutnrsoaan2EWiBqpcNNeA8vc9g8LWH/srI+B7q6gpyNOAw1oTbcz8u+ADJgj/vSGxBlgQVOz96eePg9eCKwZKFdwxC1s8mwrtbvKP/S2ptrmnA7ncg0olUXxgwGVO/S05xRLdC3iLCs0NRwpM61PkjHgNOtrDdfkK8Jv7UBFd/+Y1MBuie3E9drmBj393XwJeZB2AJwtOG7UYB2EehrzSgU0DPjwHqbDtkYoQvdRX9Pdbj9D6SwhBsznffePOAFqhorE8pOhzkSfeS0XGSGoPjYRfAUdgMrJu+79HP80woKoJKvA8thkIOcLWSz1OxTwYgMry9mkwM6GCy+ZjPuqGTCCONYgICeqFUr6KuQyU2rsw3MjAQnURXTtLCCwRKUvZY4HDKMqMuD988+gX1KEA/fjzpR07cRcRnfqIOaDYbFH8hGzTszFWuScFC8Fwze+/PtCXfyslcNtbSku5JkZOBYSNk3z9PWhlqPfma86fR/ErutuHwjGB2Olravb6kuIurvt/Q3LDfm7JiQSDtBLcAF57lsKGmUfZDAOby8cR39G9Ou0hX3D3S5FFuljqGbUksnOYi9V0on7SssEFOp4htPxuqnYjpIDH4IjK4Fyy3DXCx1zjmeFRQp8bfByPoTlSPHOC4My2IoS5uRp1IimwOt7tqVEn27Y+TrU9goHWkogEzyoGpU3kgv7yjYQY9XnvgLc6mtbItWJKtFRQepp+jUAB8iYyILs7mqv3wVZadctdxXhowh8xkeEjbm22P6AFrsofb6GwQ8kNlmzXUN58iS6E6X/i9avJhJzZjZw0BuIR/uekFzqMkf9URdxsAUs+oA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81b8a8d8-f8ee-4ef5-d215-08dbbe3b5ec0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 02:50:40.8064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xtd0+15fYE+e74Xq071qgM0G0AI3BYTIfto6Zm0lzXCfMp2iWVrcMbEgpNrgg/ium/AdDXOdgjAYA05xEgdffIG9IZyTUfgq2pJI42+Za+g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR13MB6516 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shihong Wang IPsec packet processing is mostly carried out in hardware. The hardware statistics on successful packets and discarded packets. The driver can obtain these statistics by Mailbox. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 149 ++++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 51770def9d..d4292c3b90 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -356,6 +356,154 @@ static const struct rte_security_capability nfp_security_caps[] = { } }; +/* IPsec config message cmd codes */ +enum nfp_ipsec_cfg_msg_cmd_codes { + NFP_IPSEC_CFG_MSG_ADD_SA, /**< Add a new SA */ + NFP_IPSEC_CFG_MSG_INV_SA, /**< Invalidate an existing SA */ + NFP_IPSEC_CFG_MSG_MODIFY_SA, /**< Modify an existing SA */ + NFP_IPSEC_CFG_MSG_GET_SA_STATS, /**< Report SA counters, flags, etc. */ + NFP_IPSEC_CFG_MSG_GET_SEQ_NUMS, /**< Allocate sequence numbers */ + NFP_IPSEC_CFG_MSG_LAST +}; + +enum nfp_ipsec_cfg_msg_rsp_codes { + NFP_IPSEC_CFG_MSG_OK, + NFP_IPSEC_CFG_MSG_FAILED, + NFP_IPSEC_CFG_MSG_SA_VALID, + NFP_IPSEC_CFG_MSG_SA_HASH_ADD_FAILED, + NFP_IPSEC_CFG_MSG_SA_HASH_DEL_FAILED, + NFP_IPSEC_CFG_MSG_SA_INVALID_CMD +}; + +static int +nfp_ipsec_cfg_cmd_issue(struct nfp_net_hw *hw, + struct nfp_ipsec_msg *msg) +{ + int ret; + uint32_t i; + uint32_t msg_size; + + msg_size = RTE_DIM(msg->raw); + msg->rsp = NFP_IPSEC_CFG_MSG_OK; + + for (i = 0; i < msg_size; i++) + nn_cfg_writel(hw, NFP_NET_CFG_MBOX_VAL + 4 * i, msg->raw[i]); + + ret = nfp_net_mbox_reconfig(hw, NFP_NET_CFG_MBOX_CMD_IPSEC); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to IPsec reconfig mbox"); + return ret; + } + + /* + * Not all commands and callers make use of response message data. But + * leave this up to the caller and always read and store the full + * response. One example where the data is needed is for statistics. + */ + for (i = 0; i < msg_size; i++) + msg->raw[i] = nn_cfg_readl(hw, NFP_NET_CFG_MBOX_VAL + 4 * i); + + switch (msg->rsp) { + case NFP_IPSEC_CFG_MSG_OK: + ret = 0; + break; + case NFP_IPSEC_CFG_MSG_SA_INVALID_CMD: + ret = -EINVAL; + break; + case NFP_IPSEC_CFG_MSG_SA_VALID: + ret = -EEXIST; + break; + case NFP_IPSEC_CFG_MSG_FAILED: + /* FALLTHROUGH */ + case NFP_IPSEC_CFG_MSG_SA_HASH_ADD_FAILED: + /* FALLTHROUGH */ + case NFP_IPSEC_CFG_MSG_SA_HASH_DEL_FAILED: + ret = -EIO; + break; + default: + ret = -EDOM; + } + + return ret; +} + +/** + * Get discards packet statistics for each SA + * + * The sa_discard_stats contains the statistics of discards packets + * of an SA. This function calculates the sum total of discarded packets. + * + * @param errors + * The value is SA discards packet sum total + * @param sa_discard_stats + * The struct is SA discards packet Statistics + */ +static void +nfp_get_errorstats(uint64_t *errors, + struct ipsec_discard_stats *sa_discard_stats) +{ + uint32_t i; + uint32_t len; + uint32_t *perror; + + perror = &sa_discard_stats->discards_auth; + len = sizeof(struct ipsec_discard_stats) / sizeof(uint32_t); + + for (i = 0; i < len; i++) + *errors += *perror++; + + *errors -= sa_discard_stats->ipv4_id_counter; +} + +static int +nfp_security_session_get_stats(void *device, + struct rte_security_session *session, + struct rte_security_stats *stats) +{ + int ret; + struct nfp_net_hw *hw; + struct nfp_ipsec_msg msg; + struct rte_eth_dev *eth_dev; + struct ipsec_get_sa_stats *cfg_s; + struct rte_security_ipsec_stats *ips_s; + struct nfp_ipsec_session *priv_session; + enum rte_security_ipsec_sa_direction direction; + + eth_dev = device; + priv_session = SECURITY_GET_SESS_PRIV(session); + memset(&msg, 0, sizeof(msg)); + msg.cmd = NFP_IPSEC_CFG_MSG_GET_SA_STATS; + msg.sa_idx = priv_session->sa_index; + hw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private); + + ret = nfp_ipsec_cfg_cmd_issue(hw, &msg); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to get SA stats"); + return ret; + } + + cfg_s = &msg.cfg_get_stats; + direction = priv_session->ipsec.direction; + memset(stats, 0, sizeof(struct rte_security_stats)); /* Start with zeros */ + stats->protocol = RTE_SECURITY_PROTOCOL_IPSEC; + ips_s = &stats->ipsec; + + /* Only display SA if any counters are non-zero */ + if (cfg_s->lifetime_byte_count != 0 || cfg_s->pkt_count != 0) { + if (direction == RTE_SECURITY_IPSEC_SA_DIR_INGRESS) { + ips_s->ipackets = cfg_s->pkt_count; + ips_s->ibytes = cfg_s->lifetime_byte_count; + nfp_get_errorstats(&ips_s->ierrors, &cfg_s->sa_discard_stats); + } else { + ips_s->opackets = cfg_s->pkt_count; + ips_s->obytes = cfg_s->lifetime_byte_count; + nfp_get_errorstats(&ips_s->oerrors, &cfg_s->sa_discard_stats); + } + } + + return 0; +} + static const struct rte_security_capability * nfp_crypto_capabilities_get(void *device __rte_unused) { @@ -370,6 +518,7 @@ nfp_security_session_get_size(void *device __rte_unused) static const struct rte_security_ops nfp_security_ops = { .session_get_size = nfp_security_session_get_size, + .session_stats_get = nfp_security_session_get_stats, .capabilities_get = nfp_crypto_capabilities_get, };