From patchwork Mon Sep 25 06:06:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 131879 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B33FA42633; Mon, 25 Sep 2023 08:08:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DAE040A77; Mon, 25 Sep 2023 08:07:41 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2121.outbound.protection.outlook.com [40.107.244.121]) by mails.dpdk.org (Postfix) with ESMTP id 3233240A77 for ; Mon, 25 Sep 2023 08:07:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mP5E7NpRZ08j0EgUSctSmkW+6+uVrEuhbGX/vGf2TpUi8gqL1qgCCQaeOBZGtzagLjuzdeKhVoZe9IMfb0Nea1wX1n25sIPHuo1cdCJcvOXnqrOS0Kmf2c9g1A59PD+fxkkgqrp3vGjw4B0iuFZSOAGBx+3qSGPSBBFbE4r1HHek/zvzjKYu6840fXUR3dJGDn1PFrqeZTNrqKrkWPIK1dA4iLwO6SSzDXf8BHy8AlOy++mxm7lWKlpWjOfdPy3DbPfaDRFyJQJwF5WOSewY+qSqtZCIgorAHyFYnd8upp24pRBKSmq3mV1L9tebOTuyp9rmRWZFj7YIp0D2jZyjfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGu7lKbyde53E87VaYe0KZy+PPxSlCmpb0x2wpL9FrU=; b=FoU2ht1VbvGk/LYQe0hTDqXtFhZoRiNwKaq4tMq6gh26LXbFMQsIRfEZ4xBB6sSAUkcyFxlSjfSgvfOtUUn6a8aDORCqD7jNNJEwXJmW5XlHuuNZ5WBkPVzhOWn5A1HhjLP9wXxwKsNTGJLE98zTitMR7fowmYE6/w/2tUGIPNGyMg/pfzWRHqq9f5RZREVCBunNa3z1g4q8I1DpGdgvxWkF1g/5pZDnH8vVjeW5Vh2iOUPkjLIYnd7SSn8WZYDpWjnmY/NCjXXaS+96RaxFurX79PxAWgrRSbGMQRenMcNmua77HFSEHvx+Zn9hYahhIrdSd7Z7yLs8ByNS7k4+gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGu7lKbyde53E87VaYe0KZy+PPxSlCmpb0x2wpL9FrU=; b=AztCldf/xPO6Tl/AWyxGXpwzU3AM173aV4CmbVWs0qAwZ/3FJfuALop50uKkwsjtG0kxs7sh65QFERhxy95EX60GC9kqojkgJ9Y0q4qS15R2+jIitJw461QQJzaKS5qzOt1Numd5OWobaifAAUHMaBhULIK4VeUknK3gpIQQZTM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) by DM8PR13MB5080.namprd13.prod.outlook.com (2603:10b6:8:23::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 06:07:38 +0000 Received: from PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::b070:92e1:931e:fee7]) by PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::b070:92e1:931e:fee7%4]) with mapi id 15.20.6792.026; Mon, 25 Sep 2023 06:07:38 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Shihong Wang , Chaoyong He Subject: [PATCH 06/10] net/nfp: get IPsec Rx/Tx packet statistics Date: Mon, 25 Sep 2023 14:06:40 +0800 Message-Id: <20230925060644.1458598-7-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230925060644.1458598-1-chaoyong.he@corigine.com> References: <20230925060644.1458598-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BY5PR04CA0001.namprd04.prod.outlook.com (2603:10b6:a03:1d0::11) To PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB5568:EE_|DM8PR13MB5080:EE_ X-MS-Office365-Filtering-Correlation-Id: f1a2f403-f04a-4745-d662-08dbbd8db7d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xn/yX3LkcEA8Xr+LSvCGawFfJ/7yJwrYukl9O29GfliKH/R2xVXbUzVRvE9qVUclYGOu5phNZjTYhYXyBx22wfmD1XMq8N+kZw7enhkQgxbxatcU9u2Zn0VtK1+DXBXk8h1SfmpZFLyJ1NexLrhz6fEb0uYo8Or25cqtg322R9UZpvayu4civJZTcqHKWd2s+5hVUmaEEaCCiKw593ZY3depoph1AnfRVpi5RkOX7gXXut7Sk3JUUFXgLxJPpjhcxrxc/SoASAF7K2XHgAgbtxhoX6ixPp6cVtypvYS0pT/HidjUlmQCbmIdeXjHQbcaFDkDbs7eFqmXbEi8ByuJDALdAzTi1hMM0MLhd9ie/tMd5GWq9VVWkjraS4vKcTzt8am8DYmK0MNH3tg0/lSovecLJO7nzWcWZ9rWnfjxUr3StgChkKVlLVTRbPYMA5ytF5uSC8g4epypyJKZdQCkoPuzPHCtAqGKM82x5q3XQHS57oEGBC7yzNqavyOPn4+FBgUC+OqZ8TdUsLyEO/GrEW/WP9NBnaomZFcSiDgK9qglS9auj2mg4idoeno9qdX5jEf7eGiXNsbdxbcnFISAhswFKfyE/tvT0hFV8igbOdg8LIlnVwcKWZYCfUHBVjxVybDkD2lwCOfsTVDrvv9e3z5HNsN23EuYPnXXgm2821A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR13MB5568.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(346002)(39830400003)(376002)(136003)(230922051799003)(186009)(1800799009)(451199024)(2906002)(5660300002)(66946007)(66476007)(44832011)(66556008)(54906003)(478600001)(6666004)(6512007)(52116002)(2616005)(107886003)(1076003)(26005)(6486002)(6506007)(8936002)(8676002)(4326008)(316002)(6916009)(41300700001)(83380400001)(38350700002)(86362001)(36756003)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u/i4OrsjxMCdQAWLxX3u3nPFjGaLWXuURWIeap8SfiuDZrjySntIJO93gC2iAnuRWYwIYtOT0WqlXqt/9Tt0AaT6HHis7wP5blrkQBpupe56zMWE0RIHAr8KZU5qXbTfkP1z5pr1PpHV/z1iuOjtHhlmae5PoxEmiC454yrIu0cMP0vYGXQcC21SlTss6dgB/EccQERdL0dT22W1DPJLJFVHStdrEN0E6TLK4zAbtMKBbIjcn1YMg2tGkzx84yMmHxsVPrrw6jZvVBGVbg8r/ruCERavdmeavaXNYOpp3+KtjjZTvSHyDZz5W2TYkXyl46aRwUq0wkTIvHSCeSDAa26zTuDCZl/vEDLCA6eXTXX21cRGMOcOsZRve2x7qLqaV+tV2N4taa0XymAcNeBK6bPXmoIqK+Hx7nFIak7rzRFP6ELNuT2HHG14ZvoMO0iakpuiLKoyaWkQqWKmueDCRx6t7fHaEh+/bPvIZj3wxuj1XufKZpVY9lqw5dZwDkLgotDvjG1dI7Wys96XdueSBhIQdyy+PJj13ZtDuXVFmDHhaWrPA61pfzdNKGPkjpJlxndpzKS9P7uXYKSPf3jF9FAGdvBE6EbOqN3lM63AFK7VOjN6BiSBB/zcIMSd2PHMZJ4ZbCgz19tvHHYM32nD7gl5uoqfH/JHUkyilo7s6b6qpT1g8QiL/oFr8rVqejpDdXdu5G6jDE9lgzAeBVW2dbQ62jDkUpiEYdzaE62JGciUeOxyCTKprtO34fc+9jJ1Az7IvGjK2t6qgzGJRXSbAi7eyA7Pow/RDPWHzQYRiQJlcFrAcFTmCFHO2uQUQUum1klSu2sBKpVt92vZtLql5bIc4n98K7+RMVtyHO6h4eHt/PJQZ90JdABWwWq06DuBnljwkTt/hRLZ5A1JXguIfYtL7Ilh3KchECR+QwjVtP9shqWyDuyS6toye4sm0kgJvaQNS5Q2jUCDo+ctossTik9f615ZzCi8B7ezef9MUybgoH7gIlOkX44aFxUN9+ox0FMTEgV+hMLkM2Ql5r+otahs1DUwtkyd5k4xWKeJT+jfVS1UyN7c84OzycR8eTFiHGELanh1x6O663b55vnQHA4cjcE7zpQGCzcid2HTe8kGHwvU3TXbyaSUixqGiAvGrqsGEbRITsZkCKB3fr1XhPuxj9jKN+wTAykT/UtUpy1czon//8NQ2fbhZ4FV282QF2hm6rtf3h5fULOE2LIvIIJzoEM8F8kF3hpIT95TzuUvjN4ETGFZxN93KFJSLSro70MB/XXL/Gil3EeO/kuq0yVl7jPt0K4JvXQt+hKCik0yWXK7/GMQTFNw354i3o43Uwv1gDDxpHnheu2hdrD14tKRaYQlzLL+yGlIQ7X/X1QG3VWL9pWXDGED4tobRhVXmfCV0Ok9ipfEHvBI0B9N+BoVaD6qrBZYlo3zzdK3X6PDiuC8zO46ubFsEph+/503nqW74dQ0E2OVo4xgnKwp4zDnHJk7UIcK2ZYrMaE/veqKd3ETWhNXBt/PeCAU0fEUpiHIa1y6gDupx9/GeLG798lkGj8FzGgdCIakPZeHCdBDqaCzi4NtSEQBIFXSxugJyFdZukV2taNi74Ds7yjuhA== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1a2f403-f04a-4745-d662-08dbbd8db7d8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 06:07:38.4479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lIIOySnkGgYzeMMJ8609OErM8qEPWPKG8ZVrcdCBuRYsuq/YW4KvRHKdObMUYipurkV0uPhL8brytydu7jy/TwGCry7MVl3WySORgp+fxKM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5080 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shihong Wang IPsec packet processing is mostly carried out in hardware. The hardware statistics on successful packets and discarded packets. The driver can obtain these statistics by Mailbox. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 149 ++++++++++++++++++++++++++++++++++++ 1 file changed, 149 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 51770def9d..d4292c3b90 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -356,6 +356,154 @@ static const struct rte_security_capability nfp_security_caps[] = { } }; +/* IPsec config message cmd codes */ +enum nfp_ipsec_cfg_msg_cmd_codes { + NFP_IPSEC_CFG_MSG_ADD_SA, /**< Add a new SA */ + NFP_IPSEC_CFG_MSG_INV_SA, /**< Invalidate an existing SA */ + NFP_IPSEC_CFG_MSG_MODIFY_SA, /**< Modify an existing SA */ + NFP_IPSEC_CFG_MSG_GET_SA_STATS, /**< Report SA counters, flags, etc. */ + NFP_IPSEC_CFG_MSG_GET_SEQ_NUMS, /**< Allocate sequence numbers */ + NFP_IPSEC_CFG_MSG_LAST +}; + +enum nfp_ipsec_cfg_msg_rsp_codes { + NFP_IPSEC_CFG_MSG_OK, + NFP_IPSEC_CFG_MSG_FAILED, + NFP_IPSEC_CFG_MSG_SA_VALID, + NFP_IPSEC_CFG_MSG_SA_HASH_ADD_FAILED, + NFP_IPSEC_CFG_MSG_SA_HASH_DEL_FAILED, + NFP_IPSEC_CFG_MSG_SA_INVALID_CMD +}; + +static int +nfp_ipsec_cfg_cmd_issue(struct nfp_net_hw *hw, + struct nfp_ipsec_msg *msg) +{ + int ret; + uint32_t i; + uint32_t msg_size; + + msg_size = RTE_DIM(msg->raw); + msg->rsp = NFP_IPSEC_CFG_MSG_OK; + + for (i = 0; i < msg_size; i++) + nn_cfg_writel(hw, NFP_NET_CFG_MBOX_VAL + 4 * i, msg->raw[i]); + + ret = nfp_net_mbox_reconfig(hw, NFP_NET_CFG_MBOX_CMD_IPSEC); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to IPsec reconfig mbox"); + return ret; + } + + /* + * Not all commands and callers make use of response message data. But + * leave this up to the caller and always read and store the full + * response. One example where the data is needed is for statistics. + */ + for (i = 0; i < msg_size; i++) + msg->raw[i] = nn_cfg_readl(hw, NFP_NET_CFG_MBOX_VAL + 4 * i); + + switch (msg->rsp) { + case NFP_IPSEC_CFG_MSG_OK: + ret = 0; + break; + case NFP_IPSEC_CFG_MSG_SA_INVALID_CMD: + ret = -EINVAL; + break; + case NFP_IPSEC_CFG_MSG_SA_VALID: + ret = -EEXIST; + break; + case NFP_IPSEC_CFG_MSG_FAILED: + /* FALLTHROUGH */ + case NFP_IPSEC_CFG_MSG_SA_HASH_ADD_FAILED: + /* FALLTHROUGH */ + case NFP_IPSEC_CFG_MSG_SA_HASH_DEL_FAILED: + ret = -EIO; + break; + default: + ret = -EDOM; + } + + return ret; +} + +/** + * Get discards packet statistics for each SA + * + * The sa_discard_stats contains the statistics of discards packets + * of an SA. This function calculates the sum total of discarded packets. + * + * @param errors + * The value is SA discards packet sum total + * @param sa_discard_stats + * The struct is SA discards packet Statistics + */ +static void +nfp_get_errorstats(uint64_t *errors, + struct ipsec_discard_stats *sa_discard_stats) +{ + uint32_t i; + uint32_t len; + uint32_t *perror; + + perror = &sa_discard_stats->discards_auth; + len = sizeof(struct ipsec_discard_stats) / sizeof(uint32_t); + + for (i = 0; i < len; i++) + *errors += *perror++; + + *errors -= sa_discard_stats->ipv4_id_counter; +} + +static int +nfp_security_session_get_stats(void *device, + struct rte_security_session *session, + struct rte_security_stats *stats) +{ + int ret; + struct nfp_net_hw *hw; + struct nfp_ipsec_msg msg; + struct rte_eth_dev *eth_dev; + struct ipsec_get_sa_stats *cfg_s; + struct rte_security_ipsec_stats *ips_s; + struct nfp_ipsec_session *priv_session; + enum rte_security_ipsec_sa_direction direction; + + eth_dev = device; + priv_session = SECURITY_GET_SESS_PRIV(session); + memset(&msg, 0, sizeof(msg)); + msg.cmd = NFP_IPSEC_CFG_MSG_GET_SA_STATS; + msg.sa_idx = priv_session->sa_index; + hw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private); + + ret = nfp_ipsec_cfg_cmd_issue(hw, &msg); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to get SA stats"); + return ret; + } + + cfg_s = &msg.cfg_get_stats; + direction = priv_session->ipsec.direction; + memset(stats, 0, sizeof(struct rte_security_stats)); /* Start with zeros */ + stats->protocol = RTE_SECURITY_PROTOCOL_IPSEC; + ips_s = &stats->ipsec; + + /* Only display SA if any counters are non-zero */ + if (cfg_s->lifetime_byte_count != 0 || cfg_s->pkt_count != 0) { + if (direction == RTE_SECURITY_IPSEC_SA_DIR_INGRESS) { + ips_s->ipackets = cfg_s->pkt_count; + ips_s->ibytes = cfg_s->lifetime_byte_count; + nfp_get_errorstats(&ips_s->ierrors, &cfg_s->sa_discard_stats); + } else { + ips_s->opackets = cfg_s->pkt_count; + ips_s->obytes = cfg_s->lifetime_byte_count; + nfp_get_errorstats(&ips_s->oerrors, &cfg_s->sa_discard_stats); + } + } + + return 0; +} + static const struct rte_security_capability * nfp_crypto_capabilities_get(void *device __rte_unused) { @@ -370,6 +518,7 @@ nfp_security_session_get_size(void *device __rte_unused) static const struct rte_security_ops nfp_security_ops = { .session_get_size = nfp_security_session_get_size, + .session_stats_get = nfp_security_session_get_stats, .capabilities_get = nfp_crypto_capabilities_get, };