diff mbox series

[v1,1/1] app/mldev: fix file and buffer handling

Message ID 20230920070941.8626-1-syalavarthi@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1,1/1] app/mldev: fix file and buffer handling |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Srikanth Yalavarthi Sept. 20, 2023, 7:09 a.m. UTC 
  Addressed issues reported by klocwork static analysis tool.

Fixes: fccf444cfe05 ("app/mldev: add function for file read")
Cc: stable@dpdk.org

Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 app/test-mldev/test_common.c           | 1 +
 app/test-mldev/test_inference_common.c | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Anup Prabhu Oct. 4, 2023, 11:08 a.m. UTC | #1 
> -----Original Message-----
> From: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Sent: Wednesday, September 20, 2023 12:40 PM
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Anup Prabhu <aprabhu@marvell.com>;
> Prince Takkar <ptakkar@marvell.com>; stable@dpdk.org
> Subject: [PATCH v1 1/1] app/mldev: fix file and buffer handling
> 
> Addressed issues reported by klocwork static analysis tool.
> 
> Fixes: fccf444cfe05 ("app/mldev: add function for file read")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Acked-by: Anup Prabhu <aprabhu@marvell.com>
Shivah Shankar Shankar Narayan Rao Oct. 5, 2023, 9:13 a.m. UTC | #2 
> -----Original Message-----
> From: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Sent: Wednesday, September 20, 2023 12:40 PM
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Anup Prabhu <aprabhu@marvell.com>;
> Prince Takkar <ptakkar@marvell.com>; stable@dpdk.org
> Subject: [PATCH v1 1/1] app/mldev: fix file and buffer handling
> 
> Addressed issues reported by klocwork static analysis tool.
> 
> Fixes: fccf444cfe05 ("app/mldev: add function for file read")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Acked-by: Shivah Shankar S <sshankarnara@marvell.com>
Thomas Monjalon Nov. 14, 2023, 7:36 p.m. UTC | #3 
04/10/2023 13:08, Anup Prabhu:
> From: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > 
> > Addressed issues reported by klocwork static analysis tool.
> > 
> > Fixes: fccf444cfe05 ("app/mldev: add function for file read")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Acked-by: Anup Prabhu <aprabhu@marvell.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test-mldev/test_common.c b/app/test-mldev/test_common.c
index 357a85a312..90e591f205 100644
--- a/app/test-mldev/test_common.c
+++ b/app/test-mldev/test_common.c
@@ -34,6 +34,7 @@  ml_read_file(char *file, size_t *size, char **buffer)
 
 	if (fstat(fd, &file_stat) != 0) {
 		ml_err("fstat failed for file: %s\n", file);
+		close(fd);
 		return -errno;
 	}
 
diff --git a/app/test-mldev/test_inference_common.c b/app/test-mldev/test_inference_common.c
index 418bf38be4..05b221401b 100644
--- a/app/test-mldev/test_inference_common.c
+++ b/app/test-mldev/test_inference_common.c
@@ -653,6 +653,7 @@  ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t
 		ml_err("Invalid input file, size = %zu (expected size = %" PRIu64 ")\n", fsize,
 		       t->model[fid].inp_dsize);
 		ret = -EINVAL;
+		free(buffer);
 		goto error;
 	}
 
@@ -670,6 +671,7 @@  ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t
 			ml_err("Invalid reference file, size = %zu (expected size = %" PRIu64 ")\n",
 			       fsize, t->model[fid].out_dsize);
 			ret = -EINVAL;
+			free(buffer);
 			goto error;
 		}
 	}
@@ -703,8 +705,6 @@  ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t
 		t->model[fid].io_pool = NULL;
 	}
 
-	free(buffer);
-
 	return ret;
 }