From patchwork Mon Sep 18 02:11:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 131523 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B954425C9; Mon, 18 Sep 2023 04:12:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B765406BC; Mon, 18 Sep 2023 04:12:27 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 6EC4D40263 for ; Mon, 18 Sep 2023 04:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695003144; x=1726539144; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CtDp3rMuh8tRasPi5IpP4X3nrcmn5KrvHqa5Em3P+iE=; b=DnvOffBiqtiKbI84vFA1qeIEbC39TLf8DKFD4z7rhYM7OEm4OAEvCGuB lEdwh/XWrUMDM6A735mKCMV0QfwRHs/IziHyYesemAND8XGIO7T7tvQam E0bbR2a6JrWYVwgqJF1G/zJTPYTfnlZ/+vdwfmgjRuNTgURn6tJu2r8yy eG6KVRCpeAH6uiodIuFSxbOlUBogM8q5FO5MeaxDMDIgGZvutL+gxIEof opEDcl9s3cjrH9KYpES6C0sDnFMUsgoXui88vb3ElzdP70NkmAFQ8g+G6 HqTk1d4fSujus+vbq6obCBoqN5TdNUiZ3ktxGVbcA5RUu+l6cir5lv12a g==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="359801693" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="359801693" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 19:11:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="815846869" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="815846869" Received: from dpdk-simei-icelake.sh.intel.com ([10.67.110.167]) by fmsmga004.fm.intel.com with ESMTP; 17 Sep 2023 19:11:20 -0700 From: Simei Su To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, wenjun1.wu@intel.com, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Julianx Grajkowski Subject: [PATCH v4 07/18] common/idpf/base: add necessary check Date: Mon, 18 Sep 2023 10:11:19 +0800 Message-Id: <20230918021130.192982-8-simei.su@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918021130.192982-1-simei.su@intel.com> References: <20230915021730.2681882-1-simei.su@intel.com> <20230918021130.192982-1-simei.su@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add necessary check for payload and message buffer. Signed-off-by: Julianx Grajkowski Signed-off-by: Simei Su Acked-by: Beilei Xing --- .mailmap | 1 + drivers/common/idpf/base/idpf_common.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 75d534c53d..23aed53102 100644 --- a/.mailmap +++ b/.mailmap @@ -1644,3 +1644,4 @@ Zhenning Xiao Josh Hay Madhu Chittim Shailendra Bhatnagar +Julianx Grajkowski diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c index fbf71416fd..9610916aa9 100644 --- a/drivers/common/idpf/base/idpf_common.c +++ b/drivers/common/idpf/base/idpf_common.c @@ -239,8 +239,10 @@ int idpf_clean_arq_element(struct idpf_hw *hw, e->desc.ret_val = msg.status; e->desc.datalen = msg.data_len; if (msg.data_len > 0) { - if (!msg.ctx.indirect.payload) - return -EINVAL; + if (!msg.ctx.indirect.payload || !msg.ctx.indirect.payload->va || + !e->msg_buf) { + return -EFAULT; + } e->buf_len = msg.data_len; msg_data_len = msg.data_len; idpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,