From patchwork Mon Sep 18 02:11:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 131528 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69F37425C9; Mon, 18 Sep 2023 04:13:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EE2540A7A; Mon, 18 Sep 2023 04:12:41 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5EA38402E9 for ; Mon, 18 Sep 2023 04:12:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695003157; x=1726539157; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0oUtMNRvodUI5RAPXgN2bbFUkEaXRfFVfUM/V9UID5Y=; b=oJ7CYZ8vkCxYvd7LsEALXZyScdugXLnB5h8+m/jNlZb9Whz4IY2U46CB rSrjZ3jVsE9QcNJyuSfbmFqk7Eer1MsZnF9vJgEeMv1kA1WdNkABiJBKD 6IRyQwA1Yz2u/zyXvW2cc5SChg9KuvFhy5hgP/ASWDNNY0vHUerjTTjmf 7lmldeayI1BcGCoZflBtHoMH15HnsEo97HpMb9fQp5WjJ0PfYaWXl0FLm xr8yNieEvPCfCkvViK9XrDbqWF9ixj4YEggwEvhRv2WmmQnau1BNDwVgm lIBpqFKihNSFIOC0L8IkFAaiutKSBmJmF0xVqAVLb3yHOWsuWssEi+Hpa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="359801752" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="359801752" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 19:11:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="815846975" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="815846975" Received: from dpdk-simei-icelake.sh.intel.com ([10.67.110.167]) by fmsmga004.fm.intel.com with ESMTP; 17 Sep 2023 19:11:33 -0700 From: Simei Su To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, wenjun1.wu@intel.com, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Pavan Kumar Linga Subject: [PATCH v4 12/18] common/idpf/base: refactor descriptor 'ret val' stripping Date: Mon, 18 Sep 2023 10:11:24 +0800 Message-Id: <20230918021130.192982-13-simei.su@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918021130.192982-1-simei.su@intel.com> References: <20230915021730.2681882-1-simei.su@intel.com> <20230918021130.192982-1-simei.su@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Conditional check is not necessary to strip and get status bits from the descriptor. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su Acked-by: Beilei Xing --- drivers/common/idpf/base/idpf_controlq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c index 7b12dfab18..da5c930578 100644 --- a/drivers/common/idpf/base/idpf_controlq.c +++ b/drivers/common/idpf/base/idpf_controlq.c @@ -426,11 +426,8 @@ static int __idpf_ctlq_clean_sq(struct idpf_ctlq_info *cq, u16 *clean_count, if (!force && !(LE16_TO_CPU(desc->flags) & IDPF_CTLQ_FLAG_DD)) break; - desc_err = LE16_TO_CPU(desc->ret_val); - if (desc_err) { - /* strip off FW internal code */ - desc_err &= 0xff; - } + /* strip off FW internal code */ + desc_err = LE16_TO_CPU(desc->ret_val) & 0xff; msg_status[i] = cq->bi.tx_msg[ntc]; if (!msg_status[i])