build: add pdcp to optional libs
Checks
Commit Message
The pdcp library is disabled when its dependent library "reorder" is not
being built.
../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
As such, it is not a mandatory library, and can be marked as safe to
disable.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/meson.build | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Aug 25, 2023 at 03:18:54PM +0100, Bruce Richardson wrote:
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
On Fri, Aug 25, 2023 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
On Fri, Aug 25, 2023 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
@@ -96,6 +96,7 @@ optional_libs = [
'mldev',
'node',
'pcapng',
+ 'pdcp',
'pdump',
'pipeline',
'port',