From patchwork Fri Aug 11 08:57:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 130123 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3EB843032; Fri, 11 Aug 2023 10:59:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 443184327B; Fri, 11 Aug 2023 10:58:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 013B840E03 for ; Fri, 11 Aug 2023 10:58:37 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AMj86q014471 for ; Fri, 11 Aug 2023 01:58:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=oXmOCeLD2zAZBXG7ac1k2xO2G9xDyMVFsIqqmJonwTs=; b=V4VPalwzEhiLAaLzqIOXprzWMR69gSYc2/g9FSGicwJcLHqARGUwBJp1nUjk88L51rnO MgUb7pSXpmr9L02cFkRnVzmzHy8OXCxzpNj0eAGNU/Ry8iQqWTKN//PlDETtnvbAARqs 3XHHI0L24Jw9ROnn8EVCrSOxtNnVIGWrw52XdZeNc4tTBLptdnVCede69Q4d3E4GnvtN njgAdiEMXPeZyOLMt9kuBwg3TlKYsQ/ScBAd7JixzZaZRKMMi4LkoU14A+DC/3Lii1dC YU8CGCAW4OtG+mYVZoJYqXxCplOMuwpe2oyz2+SHcBY+Ti89Rgs7OeswgJqjIgV9byWn 7A== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8ya1g8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 11 Aug 2023 01:58:37 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 11 Aug 2023 01:58:35 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 11 Aug 2023 01:58:35 -0700 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id C45523F706D; Fri, 11 Aug 2023 01:58:32 -0700 (PDT) From: Nithin Dabilpuram To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , , Akhil Goyal Subject: [PATCH 09/31] common/cnxk: fix leak in error path Date: Fri, 11 Aug 2023 14:27:43 +0530 Message-ID: <20230811085805.441256-9-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230811085805.441256-1-ndabilpuram@marvell.com> References: <20230811085805.441256-1-ndabilpuram@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: NPxWJefJOc6Ozjne4G_Pj7IzYxrvxBLh X-Proofpoint-GUID: NPxWJefJOc6Ozjne4G_Pj7IzYxrvxBLh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Akhil Goyal Fixed resource leak when pthread create fails in dev_init(). Fixes: 1c7a4d37e73d ("common/cnxk: fix mailbox timeout due to deadlock") Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_dev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c index 128b9751e4..18d7981825 100644 --- a/drivers/common/cnxk/roc_dev.c +++ b/drivers/common/cnxk/roc_dev.c @@ -1472,7 +1472,7 @@ dev_init(struct dev *dev, struct plt_pci_device *pci_dev) pf_vf_mbox_thread_main, dev); if (rc != 0) { plt_err("Failed to create thread for VF mbox handling\n"); - goto iounmap; + goto thread_fail; } } @@ -1500,9 +1500,10 @@ dev_init(struct dev *dev, struct plt_pci_device *pci_dev) dev->sync.start_thread = false; pthread_cond_signal(&dev->sync.pfvf_msg_cond); pthread_join(dev->sync.pfvf_msg_thread, NULL); - pthread_mutex_destroy(&dev->sync.mutex); - pthread_cond_destroy(&dev->sync.pfvf_msg_cond); } +thread_fail: + pthread_mutex_destroy(&dev->sync.mutex); + pthread_cond_destroy(&dev->sync.pfvf_msg_cond); iounmap: dev_vf_mbase_put(pci_dev, vf_mbase); mbox_unregister: