From patchwork Fri Aug 11 08:58:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 130142 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD1BE43032; Fri, 11 Aug 2023 11:00:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6E1643279; Fri, 11 Aug 2023 10:59:42 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F212F43284 for ; Fri, 11 Aug 2023 10:59:38 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AN2WVB011282 for ; Fri, 11 Aug 2023 01:59:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=Xo1fgOjk4KVEQ+cVCzNgS4Et5beKg0yiuzQx7JSmiww=; b=Je+4xWgzwzE5CQeapiz2iNIepYCaeUlTXTybV19nSHIwAdyM59UVN5gQPNsfqtXC1KNG 7294IzSVpXuL7MNDjzUcUeioMvrev8GWvzxiYhu5NT2Vb1TXavSJ45tXmYOYlh+aiqTX pBmP+EqDbz+39BM39prlXA8C8Bez0ABZ7blKis24cbm2MpAlGdanxSo0dDWNofzCYJwn LlGLXPAeE2R4Z28iIsjDyPeMEHl4TzYhGiNt2YjgyGAa03VqUmf3odybXhe8IlsaXOoC G50pOo7a40BZQqs87YQ5SxPdCNK74v+XxGuXKhH7nvM54/PIYBKx4SrwYsuicixdTl7F +Q== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8ya1gcd-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 11 Aug 2023 01:59:38 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 11 Aug 2023 01:59:34 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 11 Aug 2023 01:59:34 -0700 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id D7C653F706B; Fri, 11 Aug 2023 01:59:31 -0700 (PDT) From: Nithin Dabilpuram To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , , Akhil Goyal Subject: [PATCH 28/31] net/cnxk: fix uninitialized variable Date: Fri, 11 Aug 2023 14:28:02 +0530 Message-ID: <20230811085805.441256-28-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230811085805.441256-1-ndabilpuram@marvell.com> References: <20230811085805.441256-1-ndabilpuram@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: B5JMj526mKWwb-0usxiOuH2Ms5e7G-LW X-Proofpoint-GUID: B5JMj526mKWwb-0usxiOuH2Ms5e7G-LW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Akhil Goyal shift may be uninitialized in certain case. It is better to initialize. Fixes: 55bfac717c72 ("net/cnxk: support Tx security offload on cn10k") Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_tx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h index 04d02317b1..464cd9b401 100644 --- a/drivers/net/cnxk/cn10k_tx.h +++ b/drivers/net/cnxk/cn10k_tx.h @@ -1999,6 +1999,7 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, uint64x2_t xmask01_w0, xmask23_w0; uint64x2_t xmask01_w1, xmask23_w1; rte_iova_t io_addr = txq->io_addr; + uint8_t lnum, shift = 0, loff = 0; uintptr_t laddr = txq->lmt_base; uint8_t c_lnum, c_shft, c_loff; struct nix_send_hdr_s send_hdr; @@ -2006,7 +2007,6 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, uint64x2_t xtmp128, ytmp128; uint64x2_t xmask01, xmask23; uintptr_t c_laddr = laddr; - uint8_t lnum, shift, loff = 0; rte_iova_t c_io_addr; uint64_t sa_base; union wdata {