From patchwork Fri Aug 11 08:58:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 130138 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D40AC43032; Fri, 11 Aug 2023 11:00:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4502543269; Fri, 11 Aug 2023 10:59:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4E42B4326B for ; Fri, 11 Aug 2023 10:59:36 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AMjx5h001610 for ; Fri, 11 Aug 2023 01:59:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=i6qwqEtAQPxTF3os0jBX4OBoFQ2mquO9ZgjYEbZFl6c=; b=ipd61aUZ/hr1na0EOvvL6dGQQ6JEyoyi5kdEgeMIY+wXliZ5+5t4kBCGw2UaYWEYnb35 Vvwkng9rmkMH+h6f5wTAC5lSEW+XahDfttddN47ObABsxaknBhDHj9lGxXRK0PfVhWeb Di/vEBuVXMmqjQx8DZXwf36ALD/j8wcCQW+XMpdyzg02s0oYXD54j43RI4sG9Upduuhz Drh2jQrfW5ErDf/tOsNRmBkoaZMi/R22XjowSvcrwDm3fM9nIWlt114ms1S/CCIYWw/Z qepLbbozG9pWHTgzHbTzJbLSXujJm/9iiWpkdF8yc5daw/hJICOtZGg/9UFH0NfLcCZU pw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8yp9rbj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 11 Aug 2023 01:59:35 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 11 Aug 2023 01:59:28 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 11 Aug 2023 01:59:28 -0700 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 9ABDB3F706B; Fri, 11 Aug 2023 01:59:25 -0700 (PDT) From: Nithin Dabilpuram To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , , Akhil Goyal Subject: [PATCH 26/31] net/cnxk: fix uninitialized variable Date: Fri, 11 Aug 2023 14:28:00 +0530 Message-ID: <20230811085805.441256-26-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230811085805.441256-1-ndabilpuram@marvell.com> References: <20230811085805.441256-1-ndabilpuram@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: wq0ork7XOP8WDFs9-prbUWEPXNYmEsxT X-Proofpoint-GUID: wq0ork7XOP8WDFs9-prbUWEPXNYmEsxT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Akhil Goyal sa_base may be uninitialized in some remote case. It is better to initialize it. Fixes: 4382a7ccf781 ("net/cnxk: support Rx security offload on cn10k") Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_rx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h index a696427091..55ccf2023c 100644 --- a/drivers/net/cnxk/cn10k_rx.h +++ b/drivers/net/cnxk/cn10k_rx.h @@ -909,8 +909,8 @@ cn10k_nix_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts, struct nix_cqe_hdr_s *cq; struct rte_mbuf *mbuf; uint64_t aura_handle; + uint64_t sa_base = 0; uintptr_t cpth = 0; - uint64_t sa_base; uint16_t lmt_id; uint64_t laddr; @@ -1050,9 +1050,9 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, uint8x16_t f0, f1, f2, f3; uint16_t lmt_id, d_off; uint64_t lbase, laddr; + uintptr_t sa_base = 0; uint16_t packets = 0; uint16_t pkts_left; - uintptr_t sa_base; uint32_t head; uintptr_t cq0;