From patchwork Fri Aug 11 08:57:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 130140 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73FF543032; Fri, 11 Aug 2023 11:00:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0CE043284; Fri, 11 Aug 2023 10:59:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id F1E6743247 for ; Fri, 11 Aug 2023 10:59:37 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AN2WV9011282 for ; Fri, 11 Aug 2023 01:59:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=Eky7WpAHJeLiR91Ny8NQy6sCDTuzQQJPjEyifHXf6Q8=; b=ecws5sQGke6muuXWON0/9kieTDfV3qkzqyDY1YERvcv0omVi0PCuQK1tTarEGQbC3LLK KU01ZMTBWsNAjXqZAwgTNCj3+UpPj2GOzZqUrpbT8XqY8eGs6F9NLUqn3xIVJDZHBcWE pOQPMq+9dakiPZNDBLhge9n2GuShfqgQO0KnWFVqrVN4cw9JmPT9uXlj5PEKT5D0BKJG HaS/PVs7VEAqRcdyEOWWZmqLMNuuAgflXwBMDCDHjTtMdX5NRb77S12yItaHs2mRYES0 N2WS2oT08aAaaas8diNPvJsoRbUFTETcU3WCCcM8WRd0AmMyTiDlz383YtiBK31zx2Zu Yw== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8ya1gcd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 11 Aug 2023 01:59:37 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 11 Aug 2023 01:59:21 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 11 Aug 2023 01:59:21 -0700 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 40F3A3F706A; Fri, 11 Aug 2023 01:59:18 -0700 (PDT) From: Nithin Dabilpuram To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: , , Srujana Challa Subject: [PATCH 24/31] net/cnxk: move MAC address set from init to configure Date: Fri, 11 Aug 2023 14:27:58 +0530 Message-ID: <20230811085805.441256-24-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230811085805.441256-1-ndabilpuram@marvell.com> References: <20230811085805.441256-1-ndabilpuram@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: ldTtkrEqlAoa08zVbuPgRazDLHkYjVfi X-Proofpoint-GUID: ldTtkrEqlAoa08zVbuPgRazDLHkYjVfi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Srujana Challa Channel(rx_chan_base) is not available in the kernel at the time of nix probe. Hence, move the mac address set call from nix_device_init() to nix_device_configure(). This fixes the issue on cn10kb, where traffic was not getting received when promisc is disabled. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cnxk_ethdev.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index bd161ad375..3b2ad5ff7d 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -1301,6 +1301,15 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) goto fail_configure; } + if (!roc_nix_is_vf_or_sdp(nix)) { + /* Sync same MAC address to CGX/RPM table */ + rc = roc_nix_mac_addr_set(nix, dev->mac_addr); + if (rc) { + plt_err("Failed to set mac addr, rc=%d", rc); + goto fail_configure; + } + } + /* Check if ptp is enable in PF owning this VF*/ if (!roc_nix_is_pf(nix) && (!roc_nix_is_sdp(nix))) dev->ptp_en = roc_nix_ptp_is_enable(nix); @@ -1941,15 +1950,6 @@ cnxk_eth_dev_init(struct rte_eth_dev *eth_dev) /* Update the mac address */ memcpy(eth_dev->data->mac_addrs, dev->mac_addr, RTE_ETHER_ADDR_LEN); - if (!roc_nix_is_vf_or_sdp(nix)) { - /* Sync same MAC address to CGX/RPM table */ - rc = roc_nix_mac_addr_set(nix, dev->mac_addr); - if (rc) { - plt_err("Failed to set mac addr, rc=%d", rc); - goto free_mac_addrs; - } - } - /* Union of all capabilities supported by CNXK. * Platform specific capabilities will be * updated later.