app/test: fix include of standard header
Checks
Commit Message
Standard headers, or headers not in the current directory generally,
should be wrapped in "<>" rather than in regular quotes "". Fix one
instance of unistd.h being included using quotes
Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_link_bonding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Friday, 21 July 2023 12.57
>
> Standard headers, or headers not in the current directory generally,
> should be wrapped in "<>" rather than in regular quotes "". Fix one
> instance of unistd.h being included using quotes
>
> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Morten Brørup <mb@smartsharesystems.com>
On 7/21/2023 12:24 PM, Morten Brørup wrote:
>> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
>> Sent: Friday, 21 July 2023 12.57
>>
>> Standard headers, or headers not in the current directory generally,
>> should be wrapped in "<>" rather than in regular quotes "". Fix one
>> instance of unistd.h being included using quotes
>>
>> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
@@ -2,7 +2,7 @@
* Copyright(c) 2010-2014 Intel Corporation
*/
-#include "unistd.h"
+#include <unistd.h>
#include <string.h>
#include <stdarg.h>
#include <stdio.h>