From patchwork Thu Jul 13 22:40:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Malov X-Patchwork-Id: 129534 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 282C142E68; Fri, 14 Jul 2023 00:40:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC76F406B8; Fri, 14 Jul 2023 00:40:12 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id E9D1E40685; Fri, 14 Jul 2023 00:40:10 +0200 (CEST) Received: from localhost.localdomain (unknown [78.109.74.134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id 14E13E0922; Fri, 14 Jul 2023 02:40:10 +0400 (+04) From: Ivan Malov To: dev@dpdk.org Cc: Andrew Rybchenko , Ferruh Yigit , Artemii Morozov , stable@dpdk.org Subject: [PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item parse Date: Fri, 14 Jul 2023 02:40:02 +0400 Message-Id: <20230713224002.5667-1-ivan.malov@arknetworks.am> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Such check is already done at an earlier point, in sfc_flow_parse_pattern(), so remove it from IPv4 item parser. Doing so should fix Coverity issue. Coverity issue: 395526 Fixes: f79ce621e963 ("net/sfc: support IPv4 fragment matching in transfer rules") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Acked-by: Andrew Rybchenko --- drivers/net/sfc/sfc_mae.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c index 63f6536243..60a54fd425 100644 --- a/drivers/net/sfc/sfc_mae.c +++ b/drivers/net/sfc/sfc_mae.c @@ -2331,7 +2331,7 @@ sfc_mae_rule_parse_item_ipv4(const struct rte_flow_item *item, if (ctx_mae->match_spec != ctx_mae->match_spec_action) supp_mask.hdr.fragment_offset = 0; - if (item != NULL && item->last != NULL) { + if (item->last != NULL) { last = item->last; item_dup.last = NULL; }