From patchwork Wed Jul 5 10:15:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 129283 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 585A642DCC; Wed, 5 Jul 2023 12:15:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0164B4021F; Wed, 5 Jul 2023 12:15:35 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id D477E40150 for ; Wed, 5 Jul 2023 12:15:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688552133; x=1720088133; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=2DIn4IgMEUl5QJi8XXlEEQynE0Yl70hnd01Jcfo97cE=; b=dF29eD2kjwYHmltw+tlwFHTpWjt4875kXkkg/fyB+/AaobKBGlvdxxIA BjBspdQzNzvrY/KLydG3GRendOZ0KqsrWjEJ+y4iG/ALfi3ZP5nePxIIG GZqHS/gy06Be4lU/3fG/DRpzgtDkmjJ2lgNlwL8Y7Dc5bO3yT6YeVzxKE nt4uikvlNOPsxKKlcINJQ8gOnAKmKyhTe5p+N3i5EE6ZaPByT62LHEAGy UIcwDYEpiI0yb45/WXpCfjjzgENArA5vBZTzWgovQIl/qYa2x0xkz0TsB 9DgY+9ziHEa4oE7Dh6M8nFmppbS5nDM6xbXydX43ISqYTjVUlFg1akC4H A==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="360779739" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="360779739" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 03:15:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="719169640" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208";a="719169640" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.80]) by orsmga002.jf.intel.com with ESMTP; 05 Jul 2023 03:15:24 -0700 From: Ciara Power To: dev@dpdk.org Cc: gakhil@marvell.com, pablo.de.lara.guarch@intel.com, Ciara Power , marcel.d.cornu@intel.com, Kai Ji Subject: [PATCH] crypto/ipsec_mb: fix jobs array used for burst Date: Wed, 5 Jul 2023 10:15:21 +0000 Message-Id: <20230705101521.1126253-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The jobs variable was global, which meant it was not thread safe. This casued a segmentation fault when running the crypto performance app, using more than one lcore for crypto processing. Moving this to the dequeue function where it is used fixes the issue. Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") Cc: marcel.d.cornu@intel.com Signed-off-by: Ciara Power Acked-by: Kai Ji > --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c index f4322d9af4..f702127f7f 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c @@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data { uint32_t offset; }; -#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM -static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL}; -#endif - /** * Calculate the authentication pre-computes * @@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops, IMB_JOB *job; int retval, processed_jobs = 0; uint16_t i, nb_jobs; + IMB_JOB *jobs[IMB_MAX_BURST_SIZE] = {NULL}; if (unlikely(nb_ops == 0 || mb_mgr == NULL)) return 0;