[v2,1/2] doc: add policy for adding vendor PMD specific examples

Message ID 20230705095626.31177-1-hemant.agrawal@nxp.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers
Series [v2,1/2] doc: add policy for adding vendor PMD specific examples |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Hemant Agrawal July 5, 2023, 9:56 a.m. UTC
  This patch update the dpdk sample app policy to support
vendor PMD specific test examples in the respective drivers
sub-directory in examples.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 doc/guides/sample_app_ug/intro.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)
  

Comments

Jerin Jacob July 6, 2023, 5 a.m. UTC | #1
On Wed, Jul 5, 2023 at 3:26 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> This patch update the dpdk sample app policy to support
> vendor PMD specific test examples in the respective drivers
> sub-directory in examples.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  doc/guides/sample_app_ug/intro.rst | 12 ++++++++++++


Policy docs are getting added to contributors section. Please move to that area.
Example: http://patches.dpdk.org/project/dpdk/patch/20230518132139.1350234-1-jerinj@marvell.com/


>  1 file changed, 12 insertions(+)
>
> diff --git a/doc/guides/sample_app_ug/intro.rst b/doc/guides/sample_app_ug/intro.rst
> index e765f1fd6b..279aecdfda 100644
> --- a/doc/guides/sample_app_ug/intro.rst
> +++ b/doc/guides/sample_app_ug/intro.rst
> @@ -94,3 +94,15 @@ examples are highlighted below.
>  There are many more examples shown in the following chapters. Each of the
>  documented sample applications show how to compile, configure and run the
>  application as well as explaining the main functionality of the code.
> +
> +Driver specific Sample Application
> +----------------------------------
> +
> +There are cases where existing sample applications may not be suitable to test
> +a new driver contribution. In such cases a new driver specific sample application
> +can be added to specific drivers sub-directory in the examples folder with prior
> +approval from DPDK technical board. e.g.
> +
> +* :doc:`NTB Sample Application<ntb>`: The NTB Sample Application,
> +  or ``ntb`` application demonstrates how to use NTB rawdev driver for
> +  packet based processing between two systems..
> --
> 2.17.1
>
  
Stephen Hemminger Oct. 31, 2023, 8:02 p.m. UTC | #2
On Thu, 6 Jul 2023 10:30:14 +0530
Jerin Jacob <jerinjacobk@gmail.com> wrote:

> From: Jerin Jacob <jerinjacobk@gmail.com>
> To: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: thomas@monjalon.net, dev@dpdk.org, stephen@networkplumber.org
> Subject: Re: [v2 1/2] doc: add policy for adding vendor PMD specific examples
> Date: Thu, 6 Jul 2023 10:30:14 +0530
> 
> On Wed, Jul 5, 2023 at 3:26 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >
> > This patch update the dpdk sample app policy to support
> > vendor PMD specific test examples in the respective drivers
> > sub-directory in examples.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> >  doc/guides/sample_app_ug/intro.rst | 12 ++++++++++++  
> 
> 
> Policy docs are getting added to contributors section. Please move to that area.
> Example: http://patches.dpdk.org/project/dpdk/patch/20230518132139.1350234-1-jerinj@marvell.com/

This particular patch is not so much about policy for future devices.
Instead, it looks like help for the user to tell them that not all examples will
work on their hardware.
  

Patch

diff --git a/doc/guides/sample_app_ug/intro.rst b/doc/guides/sample_app_ug/intro.rst
index e765f1fd6b..279aecdfda 100644
--- a/doc/guides/sample_app_ug/intro.rst
+++ b/doc/guides/sample_app_ug/intro.rst
@@ -94,3 +94,15 @@  examples are highlighted below.
 There are many more examples shown in the following chapters. Each of the
 documented sample applications show how to compile, configure and run the
 application as well as explaining the main functionality of the code.
+
+Driver specific Sample Application
+----------------------------------
+
+There are cases where existing sample applications may not be suitable to test
+a new driver contribution. In such cases a new driver specific sample application
+can be added to specific drivers sub-directory in the examples folder with prior
+approval from DPDK technical board. e.g.
+
+* :doc:`NTB Sample Application<ntb>`: The NTB Sample Application,
+  or ``ntb`` application demonstrates how to use NTB rawdev driver for
+  packet based processing between two systems..