From patchwork Fri Jun 30 06:33:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bing Zhao X-Patchwork-Id: 129134 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 778EC42D73; Fri, 30 Jun 2023 08:34:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF5F2406B5; Fri, 30 Jun 2023 08:34:02 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2085.outbound.protection.outlook.com [40.107.94.85]) by mails.dpdk.org (Postfix) with ESMTP id 52E994021F for ; Fri, 30 Jun 2023 08:34:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XnyM9wU40fphCFIHV7Ly8vIjcrQPSTEmb+ELdJ6dpj1OO+s+x85gYtjnQB27LLubgSL6458RtBV4FhTo61lC4gkAh/SF3FNfGaZ+r0mlNEeuypEwyft5AXoxEXuKQGypfbeYv6p7IQG2/jP31dSBhgDyeAi4xhwNylM1rkNlwOHFSE5OdrXEt9aB17xpKvNHDhHtyV7Ge8xi0IMD8K+HrUvifvAyS8ATQzjSm3RJtjmp4et7FvZnCJmbIFDDLtDSLfrSRMsxzTws8rLtpoCbOLB/GevoHJWwBGigPXsh2JTLFmnzFkmD45cOPye8+Ae9bf4wPNpEk+ph0v/lckFaHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pEXpg7T/zvy8TAw7gjAPrMjLCw0zJ66aLKxNpTX1IYM=; b=dWBzF6IpQDZe6hluXfdzbEpQCkupYzUStbAbWSm+ltDDkFUuAxblWAT2sU74u0Gfd+XXa/VSgQF2FeuZVpI3/d2tv1wsuuO4XlHRC6aKyiXRMdDcezW/tbyzg29JyMW6Pmb3uqcDNugN6gGN8RhS5NUi4Os8Qs0Jm3tT9MynlVZTJROng5Q1wHUYBeDag7GifPoIQNqtS8qNdGsuwphwb+GlRMy6mcvKGxdHZOdOsWVlZVgZhOy8B4cCO/8A2Zh3NzAazpr/2IUdM4Lpr/ESWfuk0aMKxYlbc0ajcoGP8c3Quw/aTmMRg+6Bl7ToqEuhXjvYxPox2YvcUbL5TWLb1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pEXpg7T/zvy8TAw7gjAPrMjLCw0zJ66aLKxNpTX1IYM=; b=XKbu/rKrsyz8qKITEinhJZyD+8ugB+lXNxb1/e2w3EpE8C8hWjlliM8dLXkLaQPZaibfz3C8Qm9cLEyGaZSeYlIZka1OYvdLvUlc2pr1Ler+1eqAAV3rScr/Nfo2SXOK6wSGysih+TDKsn+jSxSwPMoAh59aCRW3oYUu1e7HCsrdDbCpsKr2ip6XnLdJCsxZx+rqqzx4eaS/Z9tPwlQHfyTOAVUk1IdDRvucacV6d/MwOsqhKgmKWpWepSYm8dvRyKrvV58iMVWFOAJIds0H1dRsMKWnWqcNYqNQu1BdX5mkKawhx0wAydRLLO/hFsk56pSYAfZneehYkTvw5Lhfmg== Received: from MW4PR03CA0126.namprd03.prod.outlook.com (2603:10b6:303:8c::11) by BY5PR12MB5014.namprd12.prod.outlook.com (2603:10b6:a03:1c4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Fri, 30 Jun 2023 06:33:59 +0000 Received: from CO1NAM11FT058.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::d2) by MW4PR03CA0126.outlook.office365.com (2603:10b6:303:8c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Fri, 30 Jun 2023 06:33:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT058.mail.protection.outlook.com (10.13.174.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.49 via Frontend Transport; Fri, 30 Jun 2023 06:33:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023 23:33:47 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun 2023 23:33:45 -0700 From: Bing Zhao To: , , , , CC: , Subject: [PATCH 4/7] net/mlx5: fix the return value of vport action Date: Fri, 30 Jun 2023 09:33:29 +0300 Message-ID: <20230630063329.432508-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT058:EE_|BY5PR12MB5014:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e03f03a-c614-4468-1453-08db7933fca4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5fYjO5v2pOlg4HcZk5mBXIGE5xnBCBa08Vh6hKOUZazETHK6G7tX/ct4PPpVJPGNSkly2Gh7h/fQYuAg8SGaAwPb5xmXobD7KadQ3nBRTfcq14rfMUZZG0ETiqzestUTxzXmUP6m42Bun2TgWndxVnE8UJuw+hVwq4d6YcR3VmA4NZJE7OTk3ahyHW1J8KCiP+Zmp1I1HzxFaDP2u3nIN6077uZlYoPt1h+eb+fxlXuqvvvJvqo6eRRyNGEi7GxfZ78AfD0pFPN3jgVL7I1U1UYrQq3RRWfTa+fCiPREhLyKs3TMlo2uujY68n/fT/OZ1HWFm4PmvAMR46rUknO885pWpGThvXhCBvQM3FzRq3BmzGDBeO4NS+DoPB/o/PMOd/dV9pWu8a9JAV4hcvxIn4nxcTZZrUFgJhNX4ZjgbOXKjeJbyedgQfM4/gMODk6dQnKg1xQTy+yyiLR/0lSeB+cBT7I/fkrOe/FpKsu3CX8IiNTADSkgvLBnIMvOn0hGcVMd3roR/ziXnMCM3ss8p1fHGWTTXQ9rmS6nJOBpwHuzhIUMrh+YBK7m4DOV/Uh7ameioUkaerzd1XAYFBJqwE3DfbF0zZxjxfrxP6m8+xraMmlLioum8khpAFqJWCLazC2fLruW9dVI8qFpRbCFeUZJDh6YLkk9uH1OX5ley/UkRJadw60GeTK6lBoKpI4ZGtQnFfHIfuIjSCGiGE7s5A6tbNBNzN0/MExU2VGrGFsgf2VgU9u/lu9Eo6dbud1U X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(7636003)(6286002)(4744005)(7696005)(6666004)(2906002)(82310400005)(82740400003)(47076005)(83380400001)(16526019)(107886003)(356005)(1076003)(2616005)(426003)(336012)(86362001)(40480700001)(36860700001)(55016003)(41300700001)(110136005)(54906003)(186003)(478600001)(70206006)(6636002)(36756003)(70586007)(4326008)(316002)(26005)(5660300002)(8936002)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 06:33:59.1024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e03f03a-c614-4468-1453-08db7933fca4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT058.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB5014 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The "rte_flow_error" should be set in case a invalid pointer access to the message member. Fixes: 1939eb6f660c ("net/mlx5: support flow port action with HWS") Cc: dsosnowski@nvidia.com Signed-off-by: Bing Zhao Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 6683bcbc7f..87584c1e94 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7830,7 +7830,8 @@ flow_hw_configure(struct rte_eth_dev *dev, if (is_proxy) { ret = flow_hw_create_vport_actions(priv); if (ret) { - rte_errno = -ret; + rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, "Failed to create vport actions."); goto err; } ret = flow_hw_create_ctrl_tables(dev);