[v4,8/9] build: make fragmentation library optional
Checks
Commit Message
This library is not essential for most DPDK uses, so mark it as optional
in the build config.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
app/test/meson.build | 6 ++++--
lib/meson.build | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
Comments
23/06/2023 16:07, Bruce Richardson пишет:
> This library is not essential for most DPDK uses, so mark it as optional
> in the build config.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> app/test/meson.build | 6 ++++--
> lib/meson.build | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 0a971997a5..2e447e3402 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -56,7 +56,6 @@ test_sources = files(
> 'test_hash_perf.c',
> 'test_hash_readwrite_lf_perf.c',
> 'test_interrupts.c',
> - 'test_ipfrag.c',
> 'test_ipsec.c',
> 'test_ipsec_sad.c',
> 'test_ipsec_perf.c',
> @@ -173,7 +172,6 @@ fast_tests = [
> ['func_reentrancy_autotest', false, true],
> ['hash_autotest', true, true],
> ['interrupt_autotest', true, true],
> - ['ipfrag_autotest', false, true],
> ['lcores_autotest', true, true],
> ['logs_autotest', true, true],
> ['lpm_autotest', true, true],
> @@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH')
> test_sources += 'test_graph_perf.c'
> perf_test_names += 'graph_perf_autotest'
> endif
> +if dpdk_conf.has('RTE_LIB_IP_FRAG')
> + test_sources += 'test_ipfrag.c'
> + fast_tests += [['ipfrag_autotest', false, true]]
AFAIK, there is a new patch in flight to add new ip_frag perf autotest:
http://patchwork.dpdk.org/project/dpdk/patch/20230602170147.4828-2-pbhagavatula@marvell.com/
Probably need to be synced with these changes too..
> +endif
> if dpdk_conf.has('RTE_LIB_METRICS')
> test_sources += ['test_metrics.c']
> fast_tests += [['metrics_autotest', true, true]]
> diff --git a/lib/meson.build b/lib/meson.build
> index 757c1a63e9..ea351b236a 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -83,6 +83,7 @@ optional_libs = [
> 'gro',
> 'gso',
> 'kni',
> + 'ip_frag',
> 'jobstats',
> 'latencystats',
> 'member',
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
On Tue, Jun 27, 2023 at 10:32:55AM +0100, Konstantin Ananyev wrote:
> 23/06/2023 16:07, Bruce Richardson пишет:
> > This library is not essential for most DPDK uses, so mark it as optional
> > in the build config.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> > app/test/meson.build | 6 ++++--
> > lib/meson.build | 1 +
> > 2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/meson.build b/app/test/meson.build
> > index 0a971997a5..2e447e3402 100644
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > @@ -56,7 +56,6 @@ test_sources = files(
> > 'test_hash_perf.c',
> > 'test_hash_readwrite_lf_perf.c',
> > 'test_interrupts.c',
> > - 'test_ipfrag.c',
> > 'test_ipsec.c',
> > 'test_ipsec_sad.c',
> > 'test_ipsec_perf.c',
> > @@ -173,7 +172,6 @@ fast_tests = [
> > ['func_reentrancy_autotest', false, true],
> > ['hash_autotest', true, true],
> > ['interrupt_autotest', true, true],
> > - ['ipfrag_autotest', false, true],
> > ['lcores_autotest', true, true],
> > ['logs_autotest', true, true],
> > ['lpm_autotest', true, true],
> > @@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH')
> > test_sources += 'test_graph_perf.c'
> > perf_test_names += 'graph_perf_autotest'
> > endif
> > +if dpdk_conf.has('RTE_LIB_IP_FRAG')
> > + test_sources += 'test_ipfrag.c'
> > + fast_tests += [['ipfrag_autotest', false, true]]
>
> AFAIK, there is a new patch in flight to add new ip_frag perf autotest:
> http://patchwork.dpdk.org/project/dpdk/patch/20230602170147.4828-2-pbhagavatula@marvell.com/
> Probably need to be synced with these changes too..
>
Yep, it would.
I'm working on and off in the background to try and improve the way we
manage dependencies for tests, as right now it's a bit of mess, if I'm
honest. It's very condition-based and error prone.
@@ -56,7 +56,6 @@ test_sources = files(
'test_hash_perf.c',
'test_hash_readwrite_lf_perf.c',
'test_interrupts.c',
- 'test_ipfrag.c',
'test_ipsec.c',
'test_ipsec_sad.c',
'test_ipsec_perf.c',
@@ -173,7 +172,6 @@ fast_tests = [
['func_reentrancy_autotest', false, true],
['hash_autotest', true, true],
['interrupt_autotest', true, true],
- ['ipfrag_autotest', false, true],
['lcores_autotest', true, true],
['logs_autotest', true, true],
['lpm_autotest', true, true],
@@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH')
test_sources += 'test_graph_perf.c'
perf_test_names += 'graph_perf_autotest'
endif
+if dpdk_conf.has('RTE_LIB_IP_FRAG')
+ test_sources += 'test_ipfrag.c'
+ fast_tests += [['ipfrag_autotest', false, true]]
+endif
if dpdk_conf.has('RTE_LIB_METRICS')
test_sources += ['test_metrics.c']
fast_tests += [['metrics_autotest', true, true]]
@@ -83,6 +83,7 @@ optional_libs = [
'gro',
'gso',
'kni',
+ 'ip_frag',
'jobstats',
'latencystats',
'member',