diff mbox series

crypto/openssl: fix SM2 for older openssl version

Message ID 20230615080318.3360041-1-ciara.power@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypto/openssl: fix SM2 for older openssl version |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-unit-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Power, Ciara June 15, 2023, 8:03 a.m. UTC 
  Currently when configuring the session for SM2 asym on OpenSSL PMD using
an older OpenSSL version than 3.0, an error returns,
showing a failure status for tests.

This should skip tests, as the SM2 support is for OpenSSL version 3.0+.

Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Cc: gmuthukrishn@marvell.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ji, Kai June 15, 2023, 2:45 p.m. UTC | #1 
Acked-by: Kai Ji <kai.ji@intel.com<mailto:kai.ji@intel.com>>
Gowrishankar Muthukrishnan June 16, 2023, 3:54 a.m. UTC | #2 
Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Thanks,
Gowrishankar

> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Thursday, June 15, 2023 1:33 PM
> To: dev@dpdk.org
> Cc: Ciara Power <ciara.power@intel.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>; Kai Ji <kai.ji@intel.com>
> Subject: [EXT] [PATCH] crypto/openssl: fix SM2 for older openssl version
> 
> External Email
> 
> ----------------------------------------------------------------------
> Currently when configuring the session for SM2 asym on OpenSSL PMD using an
> older OpenSSL version than 3.0, an error returns, showing a failure status for
> tests.
> 
> This should skip tests, as the SM2 support is for OpenSSL version 3.0+.
> 
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
> Cc: gmuthukrishn@marvell.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> index fe38e4ebd8..9497da41ef 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> @@ -1324,6 +1324,9 @@ static int openssl_set_asym_session_parameters(
>  			OSSL_PARAM_free(asym_session->u.sm2.params);
> 
>  		return -1;
> +#else
> +		OPENSSL_LOG(WARNING, "SM2 unsupported for OpenSSL
> Version < 3.0");
> +		return -ENOTSUP;
>  #endif
>  	}
>  	default:
> --
> 2.25.1
Akhil Goyal June 16, 2023, 7:32 a.m. UTC | #3 
> Currently when configuring the session for SM2 asym on OpenSSL PMD using
> an older OpenSSL version than 3.0, an error returns,
> showing a failure status for tests.
> 
> This should skip tests, as the SM2 support is for OpenSSL version 3.0+.
> 
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
> Cc: gmuthukrishn@marvell.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index fe38e4ebd8..9497da41ef 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -1324,6 +1324,9 @@  static int openssl_set_asym_session_parameters(
 			OSSL_PARAM_free(asym_session->u.sm2.params);
 
 		return -1;
+#else
+		OPENSSL_LOG(WARNING, "SM2 unsupported for OpenSSL Version < 3.0");
+		return -ENOTSUP;
 #endif
 	}
 	default: