From patchwork Thu Jun 1 22:23:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denis Pryazhennikov X-Patchwork-Id: 127936 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6A5642C08; Fri, 2 Jun 2023 00:24:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 995B9427E9; Fri, 2 Jun 2023 00:23:58 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 8FEA640693 for ; Fri, 2 Jun 2023 00:23:56 +0200 (CEST) Received: from localhost.localdomain (unknown [37.252.90.53]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA512) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id E78C6E126C; Fri, 2 Jun 2023 02:23:55 +0400 (+04) From: Denis Pryazhennikov To: dev@dpdk.org Cc: Ferruh Yigit , Andrew Rybchenko , Ivan Malov , Andy Moreton Subject: [PATCH 1/3] net/sfc: split link update function Date: Fri, 2 Jun 2023 02:23:47 +0400 Message-Id: <20230601222349.28965-2-denis.pryazhennikov@arknetworks.am> X-Mailer: git-send-email 2.37.0 (Apple Git-136) In-Reply-To: <20230601222349.28965-1-denis.pryazhennikov@arknetworks.am> References: <20230601222349.28965-1-denis.pryazhennikov@arknetworks.am> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Separate the original link update function into two functions: state retrieval and update. This improves code clarity and maintainability. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 320043145495..6d41eb000345 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -248,28 +248,38 @@ sfc_dev_start(struct rte_eth_dev *dev) return -rc; } -static int -sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) +static void +sfc_dev_get_rte_link(struct rte_eth_dev *dev, int wait_to_complete, + struct rte_eth_link *link) { struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev); - struct rte_eth_link current_link; - int ret; - sfc_log_init(sa, "entry"); + SFC_ASSERT(link != NULL); if (sa->state != SFC_ETHDEV_STARTED) { - sfc_port_link_mode_to_info(EFX_LINK_UNKNOWN, ¤t_link); + sfc_port_link_mode_to_info(EFX_LINK_UNKNOWN, link); } else if (wait_to_complete) { efx_link_mode_t link_mode; if (efx_port_poll(sa->nic, &link_mode) != 0) link_mode = EFX_LINK_UNKNOWN; - sfc_port_link_mode_to_info(link_mode, ¤t_link); - + sfc_port_link_mode_to_info(link_mode, link); } else { sfc_ev_mgmt_qpoll(sa); - rte_eth_linkstatus_get(dev, ¤t_link); + rte_eth_linkstatus_get(dev, link); } +} + +static int +sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) +{ + struct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev); + struct rte_eth_link current_link; + int ret; + + sfc_log_init(sa, "entry"); + + sfc_dev_get_rte_link(dev, wait_to_complete, ¤t_link); ret = rte_eth_linkstatus_set(dev, ¤t_link); if (ret == 0)