From patchwork Thu May 18 16:45:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127037 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D0FE42B34; Thu, 18 May 2023 18:47:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D055842F86; Thu, 18 May 2023 18:46:09 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id ED19642DBC for ; Thu, 18 May 2023 18:46:06 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-64d18d7738dso678514b3a.3 for ; Thu, 18 May 2023 09:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684428366; x=1687020366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ox2/1DyBdWFGOTpbAGYHhFIlWAE+SizGnBjAsFKISvE=; b=gJOGAZ+HBRlsSzX7Zb0a+w8sPhObWf8RPS/quHRwZ48PSQoj79mdtS/23PIiOnLY+q X+rZ6AJsrs4xLPr4hVML65PKvEJ+MyGb+HBYkqAXc30Js1G5R3toQI2ELxB2uSAoRTYC z3jMkvZ5X3KBpKg2oSDPBiKbNGQze+3Q2PhL61G1/IIRfi6tDtam5+nLR5bTMfpSXimE FwM8ewiA/TsEWyhp/k5CDafTgcOrK4ZQgXfi6yDcmzC1hU7IsGr8hbGa6Wv3OgbkiTPS i7o+wdBOv9r450FOe54ZttyLNmHyrUO7ruRLTQ6KdRXyF6r5JJbO105OX/VlJOZsnI4f eY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684428366; x=1687020366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ox2/1DyBdWFGOTpbAGYHhFIlWAE+SizGnBjAsFKISvE=; b=d37mNDdU3LjFiouwwdjQ0BkEO5a0vju5kJFd/UgJjiGwX9kkAQDacoX+aMcAGd3Tyr InOcMz7jjYpGIRdWnI86dXgNIqszdETzTSeLvfvPjw0+dOYJOAcAmI0lBx8WXKOKk/7a /AZzSNGVQqWrnA816E6AE4AzM+vFqfLAxwsDb2ssEJu+2Y47Hamp1sNif+0ANLim/XOK RJWJvb+sP67gRkq9ZGh9ntH9ML4L+iKsgs93+xE4bRLxuhmNmHJN9mwCdO/2MTiZ01p1 e+6PG6t3/Rio860JzzXminYfqkZgtUFIhNaJTnFy+lSNYB6I2GKAzhEgag9nYFPlElNX bMJA== X-Gm-Message-State: AC+VfDyUsnMpqx8q2h6zfbUSOqvwgk4NyRS10cDtLC58lCk//v1daBTR tD5lAi2H8uG4p7sn3mhFYGVgtOpBcPF0vvVgopmkF+JO X-Google-Smtp-Source: ACHHUZ6ykESyNHUtEasjGo1ZRHIHBF/2Fz3YYZkK3PZxy0zJ3gBLfiMK1xIbP+0I1sczUH4gAigXJQ== X-Received: by 2002:a05:6a00:138f:b0:64a:a1ba:50fd with SMTP id t15-20020a056a00138f00b0064aa1ba50fdmr5585448pfg.22.1684428365976; Thu, 18 May 2023 09:46:05 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j7-20020a62e907000000b005e0699464e3sm1513579pfh.206.2023.05.18.09.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 09:46:04 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v2 14/19] cnxk: replace term sanity Date: Thu, 18 May 2023 09:45:41 -0700 Message-Id: <20230518164546.108105-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230518164546.108105-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> <20230518164546.108105-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c | 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index 4e88ad1beb71..d837e2247634 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -527,7 +527,7 @@ roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix) node->flags &= ~NIX_TM_NODE_ENABLED; } - /* Verify sanity of all tx queues */ + /* Verify all tx queues */ for (i = 0; i < sq_cnt; i++) { sq = nix->sqs[i]; if (!sq) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 20637fbf657c..08e193e6118c 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -341,7 +341,7 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size, char name[PLT_MEMZONE_NAMESIZE]; const struct plt_memzone *mz; - /* Sanity check */ + /* argument checks */ if (!lf || !block_size || !block_count || !pool || !aura || !aura_handle) return NPA_ERR_PARAM; @@ -769,7 +769,7 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) uint8_t aura_sz; int rc; - /* Sanity checks */ + /* Input checks */ if (!lf || !base || !mbox) return NPA_ERR_PARAM; diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 1cae3084e184..8fdc3d5a9a96 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -633,7 +633,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid, struct rte_mempool *lpb_pool = mp; struct rte_mempool *spb_pool = NULL; - /* Sanity checks */ + /* input checks */ if (rx_conf->rx_deferred_start == 1) { plt_err("Deferred Rx start is not supported"); goto fail; @@ -1195,7 +1195,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) rc = -EINVAL; - /* Sanity checks */ + /* baseline checks */ if (rte_eal_has_hugepages() == 0) { plt_err("Huge page is not configured"); goto fail_configure;