From patchwork Thu May 18 15:16:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiming Yang X-Patchwork-Id: 126998 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E678342AF1; Thu, 18 May 2023 17:34:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9558042D40; Thu, 18 May 2023 17:34:29 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 0D02642D3D for ; Thu, 18 May 2023 17:34:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684424067; x=1715960067; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j2RayQRvfgwrkGYv1bvlbpB6m/K8gp02WOTn2xZt9Wc=; b=AjHF6ZgIQOCx1thcrEk/DNtbUqGC5vAol9PD526st4icew97MXgKZ3vo oRYZqjgk3CAA43XFvxmsKun+yuj9J8dF6xrIOiIlcbZE+sIXp6ond+Q0d xXVfTGQRzQ+ZYbRGfgoEUB7zDY4iau1TilZ6FkV2C7LaNYD43qs124tY9 gPdo9pjjPKvMNDip9cdcHu/b3DZMMZJZk5uQqI2/n0jIvEcoeYnj+SEBx Byva96xOyFe6khGkHpKZABJPGqDpAnWwf/Vhl6YKow6DNobaEw0Elrxtk /1U9TCy+AiFuDxNN3TwUbUv1ZbEV0xdK4aLl11iB7z+WCQPuudfYkN2QG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="341527647" X-IronPort-AV: E=Sophos;i="5.99,285,1677571200"; d="scan'208";a="341527647" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 08:34:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="705235058" X-IronPort-AV: E=Sophos;i="5.99,285,1677571200"; d="scan'208";a="705235058" Received: from dpdk-qiming3.sh.intel.com ([10.67.111.4]) by fmsmga007.fm.intel.com with ESMTP; 18 May 2023 08:34:25 -0700 From: Qiming Yang To: dev@dpdk.org Cc: qi.z.zhang@intel.com, Qiming Yang , Dave Ertman Subject: [PATCH v2 04/20] net/ice/base: fix incorrect defines for DCBx Date: Thu, 18 May 2023 15:16:22 +0000 Message-Id: <20230518151638.1207021-5-qiming.yang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230518151638.1207021-1-qiming.yang@intel.com> References: <20230427062001.478032-1-qiming.yang@intel.com> <20230518151638.1207021-1-qiming.yang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In all cases but one, CEE mode is defined as 0x01 and IEEE mode is defined as 0x02. in past these values were swapped. This is causing the DCB information sent from the FW agent to be parsed with incorrect structures and resulting in incorrect values. Change the defines to match what they are in the rest of the kernel. Fixes: 97e32e8d4870 ("net/ice/base: complete pending LLDP MIB") Signed-off-by: Dave Ertman Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h index 65cba9ab37..8df6ca41e9 100644 --- a/drivers/net/ice/base/ice_adminq_cmd.h +++ b/drivers/net/ice/base/ice_adminq_cmd.h @@ -2002,8 +2002,8 @@ struct ice_aqc_lldp_get_mib { #define ICE_AQ_LLDP_DCBX_S 6 #define ICE_AQ_LLDP_DCBX_M (0x3 << ICE_AQ_LLDP_DCBX_S) #define ICE_AQ_LLDP_DCBX_NA 0 -#define ICE_AQ_LLDP_DCBX_IEEE 1 -#define ICE_AQ_LLDP_DCBX_CEE 2 +#define ICE_AQ_LLDP_DCBX_CEE 1 +#define ICE_AQ_LLDP_DCBX_IEEE 2 /* The following bytes are reserved for the Get LLDP MIB command (0x0A00) * and in the LLDP MIB Change Event (0x0A01). They are valid for the * Get LLDP MIB (0x0A00) response only.