From patchwork Tue May 16 11:25:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 126884 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5D2E42B22; Tue, 16 May 2023 13:26:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A87142D2F; Tue, 16 May 2023 13:26:42 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) by mails.dpdk.org (Postfix) with ESMTP id 032EF42D16 for ; Tue, 16 May 2023 13:26:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqHoxN2LkdjvjC85jlspWr1EvieLEgISLAtpwiXB7iAi/YzY9E3n2wCtJZA1xqC5Kph+S+HxzmrlZk7DVmKxsSYO9pZKWS7bNueXoMxcPPMib23DuWuWXbQzzqMhtWUEgxcPnT2A4btXjXWB1nOT6HehpH8+OB5wPJAefeFf10sIoM4eeJO8Yi/z4IcJEhA2+JWRt2AOi2EAk4bl5WEnwDTyqPQq+NgjIlDTDZ4ZrPFp71lynjs5or8n/rR8VW3ob4JDHkHZ4lJQ73vtbjGGUg8kY+U64ahTIfGTVHPvzUjBVDyeqwJw3sfsehw2Q9QXom6I4QDHMsyQq5cmNB6JhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZBmguldfwXRVJtd72veYASdz+CS3L27Qre/9V9MlNE=; b=l1ugrmUWQrbd5hxUpY+EYxkM1rSdCsnUlmLM7kmA4mkzd1GlZZRauhj7wnO1Aq7nBkyXYjM0/ScpbqmgOOm74obM9ZCwvuobJDSs0FC7uXk6cIfBQTD2hLfxC9nCPFg8kQ/E4Ng+/xNwmUgkXsY3/6u1EMSdtTmcHVVq0BfCvRLEYA+pWYdWIRsv2iGRNvyPsh/kkzJhzoIpeAaDMSQD2gGThZJz8t37gqCf6w0Z+0GXlvQ3wAa5MB8rzP5IrsPCB/x372tYKprBPIbNvDSKriW0YgXhWz8VbG0mkL/QwtirfBTQpwC7luqCsZph7fla9JBo/yqB08SjIVcchL1sBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZBmguldfwXRVJtd72veYASdz+CS3L27Qre/9V9MlNE=; b=F8lwfEkSoKM9yiMm+hVglwcLluHP7MB6TIz98z5tVMOarb/yiXy3Uc5doClA1pzLi4q5WwKCHu8ptbPeJnd4XLuULB20iIw9bxJUNrKIJaPiAGy5EttsgxBFXdVB+0YwHuAPustIZz2mfnXevJdAN6STBdXmAUfSMbGG88iGj/cbzGfMfICNgRUWWOpahuw4kvUfdEahbydPmKXHStI99YYUFo0Tvc46cKdJnyh8Coo+YAbIdyj87m/f5dl1pqV8SJUqxP8rOW6siQKboE2y5kZi2wpcthZt7Jei/CsawC0C2L5H5mSisDTBdh5omD0TfvVODPaQd8P+NhBEyma3XA== Received: from DS7PR05CA0055.namprd05.prod.outlook.com (2603:10b6:8:2f::15) by PH7PR12MB6540.namprd12.prod.outlook.com (2603:10b6:510:213::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 11:26:31 +0000 Received: from DM6NAM11FT087.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::e2) by DS7PR05CA0055.outlook.office365.com (2603:10b6:8:2f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 11:26:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT087.mail.protection.outlook.com (10.13.172.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 11:26:30 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 16 May 2023 04:26:14 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 16 May 2023 04:26:10 -0700 From: Tal Shnaiderman To: CC: , , , , , Subject: [PATCH v2 1/3] net/mlx5: support multi-packet RQ on Windows Date: Tue, 16 May 2023 14:25:46 +0300 Message-ID: <20230516112548.6848-2-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20230516112548.6848-1-talshn@nvidia.com> References: <20230516112548.6848-1-talshn@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT087:EE_|PH7PR12MB6540:EE_ X-MS-Office365-Filtering-Correlation-Id: bd37623a-72ac-4c64-8d2b-08db56006586 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gsed8SnIAkv7XcmIDrGxDTautyMRvzYT33ezecBDTvLQtEJZIehy3iNIxEUitTpF0gzH30XYki6izjxM7N4ZCoeKWkWiFlNZQ2LGsEL2pcU51iA1Tz8H3Lw1U39584Zuxg7AMkORtIlGOd8FRYlmaxrTZyXOirKKTi8UokMq/NcEN72RfaJ//avxQ6KSHfLeHBlQRvGg5y3esjynBh4Ig+jO3rs0LthcFvY5tIB/KuNidd+zS+GCuxzpCixlBBl1ImpuQwUh4W/mJrdoq4yJ7IisPsyRM5nZ9WNg+JDHN9VUxpK8Xo8pDXBEFoaDn4Mg7KjqJmpXSJfThl+ioThMYB80zaKI9CZ/fJaM1e4sd1HqMT+t1DT3gIQ53KWuNbQFwydiyZzajQBOXtPimEd6weDqLPWI4hjQc0BN8DB1XQKH5/JMW/AYGa8cBSr/q1mj2M2u4oeXDhovQQJ3/f1xrbeimKy4EmglPtq5WPGpGdV0UrI3QCNLWKShRPPhk+oZX6OAX5cBewLlLq5Fqde9zhTdyVMeqZijRswNl32TnQJ/iyRRw9+RqPvtSNLlDW7siBgrN5ZpQpVVOzToeMXE3cRjhNk7bcIJUCfP+YvktV2jPgH41vu3JDUs6CLLUhmZwtNNSm1wK2Iroi4FUhkuT3NnfY3a2eHlyKL1Wn0qK4171sOHV3WK8O7WXKEhe07EXH87ihdsmIRTwEZEpmyNLXjWyKv20rSHwhvWXdvVWrjeTW2yvbf7EQHRPSBVg/kB X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199021)(40470700004)(36840700001)(46966006)(16526019)(36860700001)(6286002)(4326008)(6916009)(70206006)(70586007)(356005)(7636003)(107886003)(26005)(186003)(86362001)(82740400003)(1076003)(83380400001)(6666004)(7696005)(426003)(82310400005)(336012)(47076005)(316002)(2616005)(478600001)(40460700003)(36756003)(54906003)(5660300002)(40480700001)(2906002)(55016003)(41300700001)(8936002)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 11:26:30.4956 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd37623a-72ac-4c64-8d2b-08db56006586 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT087.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6540 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Multi-Packet RQ can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted to receive multiple packets on the buffer. Add support for multi-packet RQ on Windows. The feature is disabled by default and can by enabled by setting mprq_en=1 in the PMD specific arguments. Signed-off-by: Tal Shnaiderman Tested-by: Pier Damouny Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/common/mlx5/windows/mlx5_win_defs.h | 8 +++++++- drivers/net/mlx5/windows/mlx5_os.c | 26 ++++++++++++++++++++++++++ 4 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index d0907fcd49..096bd1d520 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1076,6 +1076,9 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, general_obj_types) & MLX5_GENERAL_OBJ_TYPES_CAP_CONN_TRACK_OFFLOAD); attr->rq_delay_drop = MLX5_GET(cmd_hca_cap, hcattr, rq_delay_drop); + attr->striding_rq = MLX5_GET(cmd_hca_cap, hcattr, striding_rq); + attr->ext_stride_num_range = + MLX5_GET(cmd_hca_cap, hcattr, ext_stride_num_range); attr->max_flow_counter_15_0 = MLX5_GET(cmd_hca_cap, hcattr, max_flow_counter_15_0); attr->max_flow_counter_31_16 = MLX5_GET(cmd_hca_cap, hcattr, diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index ce173bc36a..9e7992b1c6 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -282,6 +282,8 @@ struct mlx5_hca_attr { uint32_t crypto_wrapped_import_method:1; uint16_t esw_mgr_vport_id; /* E-Switch Mgr vport ID . */ uint16_t max_wqe_sz_sq; + uint32_t striding_rq:1; + uint32_t ext_stride_num_range:1; uint32_t set_reg_c:8; uint32_t nic_flow_table:1; uint32_t modify_outer_ip_ecn:1; diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/common/mlx5/windows/mlx5_win_defs.h index 65da820c5e..885114655f 100644 --- a/drivers/common/mlx5/windows/mlx5_win_defs.h +++ b/drivers/common/mlx5/windows/mlx5_win_defs.h @@ -270,4 +270,10 @@ enum { MLX5_MATCH_INNER_HEADERS = RTE_BIT32(2), }; -#endif /* MLX5_WIN_DEFS_H */ +#define MLX5_MIN_SINGLE_WQE_LOG_NUM_STRIDES 9 +#define MLX5_MAX_SINGLE_WQE_LOG_NUM_STRIDES 16 +#define MLX5_MIN_SINGLE_STRIDE_LOG_NUM_BYTES 6 +#define MLX5_MAX_SINGLE_STRIDE_LOG_NUM_BYTES 13 +#define MLX5_EXT_MIN_SINGLE_WQE_LOG_NUM_STRIDES 3 +#define IB_QPT_RAW_PACKET 8 +#endif /* __MLX5_WIN_DEFS_H__ */ diff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c index f401264b61..0caa8931e4 100644 --- a/drivers/net/mlx5/windows/mlx5_os.c +++ b/drivers/net/mlx5/windows/mlx5_os.c @@ -187,6 +187,32 @@ mlx5_os_capabilities_prepare(struct mlx5_dev_ctx_shared *sh) if (sh->dev_cap.tso) sh->dev_cap.tso_max_payload_sz = 1 << hca_attr->max_lso_cap; DRV_LOG(DEBUG, "Counters are not supported."); + if (hca_attr->striding_rq) { + sh->dev_cap.mprq.enabled = 1; + sh->dev_cap.mprq.log_min_stride_size = + MLX5_MIN_SINGLE_STRIDE_LOG_NUM_BYTES; + sh->dev_cap.mprq.log_max_stride_size = + MLX5_MAX_SINGLE_STRIDE_LOG_NUM_BYTES; + if (hca_attr->ext_stride_num_range) + sh->dev_cap.mprq.log_min_stride_num = + MLX5_EXT_MIN_SINGLE_WQE_LOG_NUM_STRIDES; + else + sh->dev_cap.mprq.log_min_stride_num = + MLX5_MIN_SINGLE_WQE_LOG_NUM_STRIDES; + sh->dev_cap.mprq.log_max_stride_num = + MLX5_MAX_SINGLE_WQE_LOG_NUM_STRIDES; + DRV_LOG(DEBUG, "\tmin_single_stride_log_num_of_bytes: %u", + sh->dev_cap.mprq.log_min_stride_size); + DRV_LOG(DEBUG, "\tmax_single_stride_log_num_of_bytes: %u", + sh->dev_cap.mprq.log_max_stride_size); + DRV_LOG(DEBUG, "\tmin_single_wqe_log_num_of_strides: %u", + sh->dev_cap.mprq.log_min_stride_num); + DRV_LOG(DEBUG, "\tmax_single_wqe_log_num_of_strides: %u", + sh->dev_cap.mprq.log_max_stride_num); + DRV_LOG(DEBUG, "\tmin_stride_wqe_log_size: %u", + sh->dev_cap.mprq.log_min_stride_wqe_size); + DRV_LOG(DEBUG, "Device supports Multi-Packet RQ."); + } if (hca_attr->rss_ind_tbl_cap) { /* * DPDK doesn't support larger/variable indirection tables.