From patchwork Tue Feb 21 06:49:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124268 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C7E341CF8; Tue, 21 Feb 2023 07:50:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8287C43187; Tue, 21 Feb 2023 07:49:58 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2105.outbound.protection.outlook.com [40.107.101.105]) by mails.dpdk.org (Postfix) with ESMTP id DA8B743175; Tue, 21 Feb 2023 07:49:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WrjnexAHZyUeS04bY4GgwQKFaJXO/nmddnScgkZXeVz97+T0iIZ62Ajh2c7OZOIOZ23VxdNr9ihrNAaa3wNVSr5cPp+kDuRrTY8F7oGohHI2aCduIfoo7WjnbM4ZKOCQndzGeBkKZZXJHb2KSawm1P2NFCXWP5fb5NgBy4R81/WGR2Qf6vokz2YT7cch2Yy13fu4uvFjxv/gUpjP0gJ2HwtP6vOrD9yfygoYusDwPGZvwHlfD+DKIo3gO0l1u5ECOpBgl5r7Mn2LsqX9BkoGgCDHi6rwSZypAWm36QKyqz06As9ZCyHYtBzRQubePWbKtZ3TjKEqbO4wsgbjXXf3xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mUbK7qEJe7YmsUgmARIlhm733z4mUE0GY+ypuD3mb/4=; b=kgkayh31A01nFC6NpP6bKMA9XA9vyO2UeCrBwVPIpKELNPeLSSpCjJPwO5ovIKTYEcFxl6pKn2ImGLMk8UF8+XkjyO2Xz/KOcoLE4Oa2rPUa5TJLGjY6NPaTid0Fb9mjnj7Ap7UgNJVozeDedl7o2mMRRGqWjU1Yq9TcsVFK0ux0p9YUzjJhiAP+jfBEbEOHLFW0FaOSsLLO6X59Pv7vWQTOdj24T7cHCr3jy/iR4uIQeBRV5yme7D0ehtM/Y5GbgSq1FdJMJpiRPL2s+YSiVqRvIp87mgI4OaK9MWZ6CPtSkAs49GK6uQ1VZtrP2bOhITEQuVSRl0fJCY9ev+5DuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mUbK7qEJe7YmsUgmARIlhm733z4mUE0GY+ypuD3mb/4=; b=fodq8ctcGwaI2mGWrT8fgar/GY/hje/5WMxjwgdwEyHpizRH2LmS2jA6x6KDGubhBSVonZrWlsEMdNaQw6lWteEbnbbEoh7cfzoJ4M2Nr+PcTHH8Pfsuftg9Nqo2Ul6HLMjwELwzfPi0vijYJOpQ44WZQGNocDcQAwYKdDuEkgE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5455.namprd13.prod.outlook.com (2603:10b6:510:139::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 06:49:55 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 06:49:55 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH 3/6] net/nfp: fix the set IPv6 flow action Date: Tue, 21 Feb 2023 14:49:27 +0800 Message-Id: <20230221064930.3399-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221064930.3399-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR02CA0049.apcprd02.prod.outlook.com (2603:1096:4:196::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5455:EE_ X-MS-Office365-Filtering-Correlation-Id: 04cd3afc-293c-41d3-2b71-08db13d7d6c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nXbwIaFahthfTeNDynWMo8uc9Y9wjN7KsTXyYJoONZdhDDGz83IfDyEj4ZADZtCPQsajTZaIU4IrmaE1gL3p+p3uqWdAAxpHHOBhX/x+wQwEZ81lBIZZrx2ltVbs1YbnFd+iQXmLahZN0bsXIvzq4kReO2y40bqt0mhnTb3vZKLJlIUarVKu9cKZWGMRWfIm+XE+IYjZ/G9aaQp84F3LYDT5IgbUjbaqv4mPKMpLLqlNIpML69skrlvCxNlvjWCiUZDFtBxycnM2tN/TQuvBuKPg7QsJ1+0zV/I6+xp5z1bb55ZziD70axgJlyST1f/hV5Buc1EBP07kfHWymbFdK8dydTIe5wUagEsRjMhmgeK+vFKTh/jFDwQjpfg/Sq5QV6bdJu/hqeH4I0jCpsqtrxCQyUmOK9DksbIAx0vriGKANDu3Kr1l5Qj3hWLnPuNGB/FKs1WbqoQDPmTnmm/bpCr3IFgNqt94yvnpxEiPX7aGSPbocbAKQNIS8FsZPQfj2MLVEB6Dh+wSjtLoXp89dVJlS1F4ZLX0keSSbuX6THOrDbCKwrSDKsZRpANRRebZzZI/cMcCwNxKbNqZmvXlBfrWVeYE2+bB4vhQgFkKc/PurAgdE6EHg31TbmIPxosO2WZugYj0KaMkGoN7BlJ3Oxlzp7T5GabsuMM+THBsH9RkRDNv6j4uZPHivp6Uv0piSm8Vde0MbK0s/YMPtSk6Hg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39840400004)(376002)(136003)(396003)(346002)(451199018)(6512007)(41300700001)(450100002)(2616005)(66556008)(66946007)(316002)(8676002)(4326008)(5660300002)(8936002)(6666004)(6916009)(66476007)(26005)(478600001)(52116002)(6486002)(6506007)(186003)(83380400001)(36756003)(1076003)(86362001)(44832011)(2906002)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?28HqtM3DhlJzthrIgRaMJ55yyfoI?= =?utf-8?q?Y1/j4rJ26Y54sAEFCniSB/5RajjcXBQl3lk6t/ZZ6AP1xmBtWIsB+5KXbL4Y4tvM1?= =?utf-8?q?xTxZYLyzpXWwGb5yTSwj4wEKlCw6Qw4fQQSXFnTQVCyYFgaNt1Iohg+hOppm4adKy?= =?utf-8?q?0VBXRXpo2WQxOM44ejFSmEtkN7oENmm6MU5Q+mCcc8Zpu53Tb7KyHp/zi+oNQiW1d?= =?utf-8?q?ts/U3YFWwUSdVHxZSV1U20VL6ZyalOU5DT382Z3MeyukePQzDKp3u1MMVgbfLsZFt?= =?utf-8?q?TWYltuWd5GYvK+ZPb+zDC4jjziRua27nvysRRZCgnLSOZpSbkuqeQC1Eem38yZ+Bj?= =?utf-8?q?kqDwSTKyCcS1KE9+rBJrkZ3uNTeHVXmnTI6q9JJjsQBzpUU7HwrSBzqFvXqEXCIRs?= =?utf-8?q?yMJ+tf8SWk2S7HpLbpjlxHXb66alyslYkLXbaVlu5d9G23vTP/yIQEUlZKLEep/qH?= =?utf-8?q?IadSsOl1AxG8Mnj3rY9Fb/okW40UPj3HMCI7UMPDznNfgXTsM5f9S9j7mGBhnkLm6?= =?utf-8?q?EDJ7s43mXYWeJnm2CdfF5MEZKCbUKFVqNgX+QaqQSGR7D+cVLiYlN5CqhdwM9NTvQ?= =?utf-8?q?AqxtGPuuuyktiKgxn004WEC1DS56kJ6nDM/WZ9TGq6dtoIZSvr6qLAB4zn+ybWG+L?= =?utf-8?q?mTUjDZkskCzerPB5OhXeAWQ7LVlCMSALuAUBF2y/Q6HmP5wiew8ExIQ3l/xEqxO8w?= =?utf-8?q?B9eIK1Z9IUGB1+wr6XqLzAHf1yzLAUYnBvykyKExGquwNMa/fX8Z1JuKuuxKp9WwT?= =?utf-8?q?NiWyjUZwYAO0irSPHXP0dL9zyPS9QckizXMyzU5r3hu+RbHwCkrHp3TRL/gpPldAQ?= =?utf-8?q?xBA/Z9m6RpqG0vOV5UVQFAh7waJPbBe0v7O/2KSTporG/rL5zX501kruHEXurpZuL?= =?utf-8?q?e3DpTSegP705H74iCuczxbqSe7hTunesI+KfEsWTPTEnx1fEsN0fMttE3XGI6dFyZ?= =?utf-8?q?OV47T1aY5CQj1wDL8F2gUxy5SvfjPwWmyQ9ZfSzZ7jkSproBFvf83s1mw0alBlGb9?= =?utf-8?q?qdVRtdFeyfed4Og9vTsisWGqfQuVlDrPzNaQECuQpLUXr6NZV6RW5GWIMOX5o/etb?= =?utf-8?q?4ezhHi+iFCbBqAoZ1GEgKbSC5MWhTKarKlYesmiUYn5v/a/9dXP1rrwrfVBdb3y4A?= =?utf-8?q?eRWmL2Db7fBNWTrAZmlbZMEYdt5GtM2Lb7S3nB1/ZHuKyLnCTfy/RgSw3irmrsjI5?= =?utf-8?q?CPJSW3S7hDTKdPaKavEbYhsJUQ3QjKlSzUxmoNtuf8nADMa4TcChpk2tM118i4m5e?= =?utf-8?q?aLH9m3bIigaI0eY0eYkovLCoKHp094VFlGr0HeVRaAFKdbfQtMF4zUFvoCt8qwf35?= =?utf-8?q?hKLC6YaElyuApj4ObdvcvIEbqWd0FYYeNV5svGDAinAcyLEVZ3Ee9Agtgti+qI6Sl?= =?utf-8?q?Q/YeysPHIQJV7oAHDlINhYuiqVBLS8WEvuSAyH0BiIMXSbIOYP194ii4H4Y5a6sF4?= =?utf-8?q?82qx6Xfh92KrRSmqtfPe+itxl71DynK+D0xSEX6JvbZuGsJnqWw4SRl3uVxRwOb8P?= =?utf-8?q?kVHLU0OImRvZB1fKkfPTomq7x5827ef0Bw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04cd3afc-293c-41d3-2b71-08db13d7d6c7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 06:49:54.9092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DweVke0t7dvq1yIKFT0WTcyp+HDWZXzhTyEBY+DYIMR5ENA6yAEwqJXhDahqoN5t9S9dxWW4W0++UAR6lcFOcTQugoexrk+fv/KlrRcdGak= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5455 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv6 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv6 address as expected. Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action") Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 39493ce98d..a4561b08e8 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2163,8 +2163,10 @@ nfp_flow_action_set_ipv6(char *act_data, set_ip->head.len_lw = act_size >> NFP_FL_LW_SIZ; set_ip->reserved = 0; - for (i = 0; i < 4; i++) - set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i]; + for (i = 0; i < 4; i++) { + set_ip->ipv6[i].exact = *(const rte_be32_t *)&set_ipv6->ipv6_addr[i * 4]; + set_ip->ipv6[i].mask = RTE_BE32(0xffffffff); + } } static void