From patchwork Tue Feb 21 05:52:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124260 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F09B041CF8; Tue, 21 Feb 2023 06:52:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 751C143184; Tue, 21 Feb 2023 06:52:45 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2129.outbound.protection.outlook.com [40.107.94.129]) by mails.dpdk.org (Postfix) with ESMTP id 5B5E043184; Tue, 21 Feb 2023 06:52:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ipSnSYh1pr7DfvGbraW6YR+Mh4bY4fsWUFy2St9iwkIeyZ1rzHiUFaBlR0EchDn2SyKgT+CsCH+LO+eoYwuuiu4NYuM3NULZ+bTEOK7JPy1n3b426PpiZre1S/LcjZHyACuYDjgDnO8LnQx04ny8OlIhKwqBjI5Yyp6KcT2VcQQuxfvwH9QROQ8htUGxyfupsyisCTZ+3KJIJjDp7kjfuja4DTbeLSq3eQqLEVRLa27QmIjtVKZLzC2/3dL3mewAxLelpmFAp0zvbT0QJYraLoS4S9+gR6Cv7AmwLgpEv7ST9PWfXoEgYm0vtCn6tvg0L/cnmEavS9ThYZ75LIS/IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQJo6Rgl1nycSssmrVppAVElZlufoFN6V1/WvEEhfIM=; b=klOCiKxw1CNR3fG0Xw+3C8JeRhyRhivSrR+yldQ2aAWEm2Rp3XAB5rKFr67dodWL/Yhw9f1YZZ9r0lLQ33pk2uR0iSwxHlcZGKG4ERr1k6Z+e3jXMsHK2FaloygJSB/IOmJZBI24nMmxIPqUvb7AVhes89OyuDNHKKsFwQ8bj+jGmqQTQm1knvk5dK4MDpG6sCraOdJ2dibMFeeRe0V/G2Q595Ylca5d9gXhfp610FN8sYjd8SYUnZbVHznyKxPlpvXjXXQ7dYsP75oZo9vG7vkCfpVuSeB0Y2pEloR1hIOD1OaSKwK3I4NefbNrOmwnMg3OZyYC0yKMl0cPGvBBjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQJo6Rgl1nycSssmrVppAVElZlufoFN6V1/WvEEhfIM=; b=gwKbKEL+qNJtxCvI5B1jHKLWmCORLahqrKaRmezbtwBV2EjfBT2o1w75Sl/Kvva7pu1WVLZ0CFauDHuJB5PRtlylhN1nF02iEdMMZMEwNwZ4W6TeGiJqWqdqOhQ0nSpHIisVqJKxGkCgBsmDb3Nl9Td5SggpMwQW7j1BJpSJ1VY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SN4PR13MB5661.namprd13.prod.outlook.com (2603:10b6:806:21c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Tue, 21 Feb 2023 05:52:41 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 05:52:41 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , louis.peens@corigine.com, stable@dpdk.org, Chaoyong He Subject: [PATCH 2/2] net/nfp: fix getting wrong RSS configuration Date: Tue, 21 Feb 2023 13:52:22 +0800 Message-Id: <20230221055222.38289-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221055222.38289-1-chaoyong.he@corigine.com> References: <20230221055222.38289-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR05CA0084.namprd05.prod.outlook.com (2603:10b6:a03:e0::25) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SN4PR13MB5661:EE_ X-MS-Office365-Filtering-Correlation-Id: a28f79c0-992c-471c-d894-08db13cfd811 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8xpu2L+RQrRpsOkcENs9YcKBYY9lECkppOv1I6PEacnpQBkZWnJDzyWD9M+/3952soh2Ju8R9Kwt64GcmbuJbi3uTOiFDKo8VGzAUGIShMZA/pYkydoQoPXwWnQojQd9f/itSsA8up35U16JG3XxoiYNLI2XDDBhFgdY7gRWvFJD1b3xRj7hOk6ezZpO2mDqwCxWwxWCVXgzr1wD42Rf/f4JKPI5knASetmENhhru0GqhsI/aMZtASMrXOAfaZ+SRO66oFT/6lpuZys/PIZvtyT+4x95mOaALGy7nnlVnAXf+GPPJzWJTgP48PPph4WBqCr6vehDbP0lfo4LzgA7XMUIPQnMnYnawNosUtSOJ+sSMG6FQYOhk33v9ouUnMoqQPoDuZ1rCWD33BxuypIKYU1xy+BSiazMnuc0wN8EM9RNIjGeapH/b9yO5QFF62IoIvT2pMVB1jcdC5LFZNYXAXp5ES/oXY046WHHu0gc/WqaSpQ8sd72Mh7mA1hBjeuAn6SfJLkUd+74RdWhqBi/+/UpTvFxjY3PtZonUFEHD5a+LzZZ0c3A0haZqwykf3kBklE4+fnKgbNc44MfOOnY8fDXg1atb1FPOxR1F/S78HhIjuVv+B8R7lj0MoQsJChZUDmGBQio/KhIoFYQei3DmC1t70rO6JZhnHXezmBmDVk5ixTWzh8SclXESh7i7voijDOKni/PriDx5g7xQswz4OeuOXG1IldgkuFKk/3w+Ib2KjCpmbw7eugpS1gcBy7F X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39840400004)(376002)(346002)(396003)(136003)(366004)(451199018)(5660300002)(8936002)(44832011)(4326008)(450100002)(6916009)(8676002)(2906002)(66556008)(66946007)(66476007)(316002)(54906003)(6486002)(478600001)(107886003)(52116002)(6666004)(1076003)(186003)(6512007)(26005)(41300700001)(6506007)(86362001)(36756003)(2616005)(83380400001)(38350700002)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?93EpcdHsURbVyySay3edqiSmloHf?= =?utf-8?q?rsqHbJRZK9kEy+aa4kOwnxwRyDCKcinuUflBCAeT908F2lJ/f4kwUQTLPePVNcbHv?= =?utf-8?q?plt1+d1NUWrhAcD18jOVf/xnqacw0K9XWfGfGcPmBUZzsnZ8Dq/6cpfVelvCJ71Mk?= =?utf-8?q?cxo41EsiuPQUAtyZtol4Taalv52O2PZ7wyvAhRSTh9pl8+qw6Q1am9PH/w9T8tPE9?= =?utf-8?q?l2RuZ7PnOM4qNSvkw875/TFwN+BPa9KHP3ZAQwmfXVQilCUev3A5e+xzP4ATkUx7g?= =?utf-8?q?MAd5S7Zom22VUM6y9aHOp5jH/P0vnXRIWXke6z/Izh2a2M+m0quT2/7TNndUx0/85?= =?utf-8?q?P8KLrDor3p5I/p5wJfWbBqqaJd7iyRC5ueCTh37SxdI9f73gSag3m6wOLK4V2PW6u?= =?utf-8?q?57YaHElZTwzzjyK11ueB8ZBjUt5efRCozERw/xLnsxYR69XvIAmoBtASreKALQiKq?= =?utf-8?q?nwZTc1JB9/6cKYwzHlYG8IEPk1r2TwTEGuONZjF668ediiF+huBO+iLlNJ2ZyhZl7?= =?utf-8?q?9zxLbOUCtRiWN3kPan946nYF9iobILqOqdRuezBT0CbwMmwvwkkrQm1jgqXL3dtbJ?= =?utf-8?q?haLnzedD1s7DDvqz9Z3Uvakno1YYKg8h+WFSQuLvVVXUHCxWog0lCIeRE4CfAG2HQ?= =?utf-8?q?T+vh4rgJwmS2qn8ZHNN0/ZFGTyFj6UFUNgG1/RnxFlw9GGrzhj2xc9oRv5sux1AIC?= =?utf-8?q?yDEzbonAa8k1yuxD7WTWEHXOR120TAeNdUrj/91dRgXnl2EoqUlBlDJ+SNgBxvyL3?= =?utf-8?q?qoZij5DOrzikR9iaWgh2sjf2e6yA4xqWS0MH1m+gxLnC8rC2QLcXnW+1nkgML4JUm?= =?utf-8?q?evPZZjxFHPHGFrdaMu30cy469Vzu1bRnc0/IgnWqOPTc2UfdM9SrFv7dhWNGF6H5x?= =?utf-8?q?Mwb8SYxKKglgmeRyH+u3XbWbjs8E2SL4wJ4cmhblqIHPwUA/Ql8IuEIFZNgPtum1V?= =?utf-8?q?PjrrGe0kQbEIU5+gHjjsozYmeGeZqRKVBbQ76bwfhYShlDcYD9PRZO7OT8uuf+/VV?= =?utf-8?q?XBl2uZC+NaL3Rlo1TfHac+mNTE9nO1xBhc4sgRKvHl6W+CSMYvs9OWp8LDVEuK9Pf?= =?utf-8?q?nsdOp+Vk2rXjo9CWdTt6aVg+PqXz8GIHQMMfxGwQURXW8EDo4+BhJbLO/owge1cR2?= =?utf-8?q?/jPKvg6ox945Oh5ttGY0m4xfCtx3EGLs+/+Zjz4bkZgChqEtehmSO5qiKiaNcQHru?= =?utf-8?q?vMY+IsYEifJC8hyO0rgD3CQ85a/ye769aQnVPiHPhuEzyyFCscv0ngbsRM4XMk0Yx?= =?utf-8?q?aQjDtTPcCs11pQgkQVC926GOvTgt1si5l0mLkANSzQw7Vb7uUzNiSydp+smD4NCQt?= =?utf-8?q?FkAKcZ5iVUBc/I1rxcJAmzTEfwTj4bG7RvRLA0ryWH9W180WZ3vH87geFdlUqWLXk?= =?utf-8?q?7q46lXzMfTctfAO+Nddm9BmIuQNwUCSKjqitqnmDJ70iHj3ma5rZ5H7t5KbwPdMs4?= =?utf-8?q?akGGz7uvDPJlgvCtQ+r6FFGiK1IeUpCQ/sL7n9dJtQUiL0jh7rbqcs4CyBnojB3Ft?= =?utf-8?q?SilqgYM3WKliGPZdTCSd8vVun10rn1mvzw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: a28f79c0-992c-471c-d894-08db13cfd811 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 05:52:41.1169 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e2ad2NNyQ+glV5ChokYnHvBFOa6djoqdazML5pRa/3VXECO5ocoAGGrEUJvIyMRM2eL0jFJlgY0iOBIe6+O0ZhMeDsqDJnlgtBLBHdYAec0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5661 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu "NFP_NET_CFG_RSS_IPV4" and "NFP_NET_CFG_RSS_IPV6" represent that firmware will calculate RSS base on l3 rather than udp or tcp information from packets. So the logic of return RSS configuration in driver is wrong. Modify code to return the right configuration. Fixes: 934e4c60fbff ("nfp: add RSS") Cc: louis.peens@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c index cfc38db65a..a025c67e3b 100644 --- a/drivers/net/nfp/nfp_common.c +++ b/drivers/net/nfp/nfp_common.c @@ -1420,7 +1420,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, cfg_rss_ctrl = nn_cfg_readl(hw, NFP_NET_CFG_RSS_CTRL); if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4) - rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS_NONFRAG_IPV4_UDP; + rss_hf |= RTE_ETH_RSS_IPV4; if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4_TCP) rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_TCP; @@ -1435,7 +1435,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, rss_hf |= RTE_ETH_RSS_NONFRAG_IPV6_UDP; if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6) - rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_UDP | RTE_ETH_RSS_NONFRAG_IPV6_UDP; + rss_hf |= RTE_ETH_RSS_IPV6; if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV4_SCTP) rss_hf |= RTE_ETH_RSS_NONFRAG_IPV4_SCTP;