[v7,11/21] net/cpfl: support write back based on ITR expire
Checks
Commit Message
Enable write back on ITR expire, then packets can be received one by
Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
drivers/net/cpfl/cpfl_ethdev.c | 45 +++++++++++++++++++++++++++++++++-
drivers/net/cpfl/cpfl_ethdev.h | 2 ++
2 files changed, 46 insertions(+), 1 deletion(-)
Comments
On 2/16/2023 12:30 AM, Mingxia Liu wrote:
> Enable write back on ITR expire, then packets can be received one by
>
Can you please describe this commit more?
I can see a wrapper to 'idpf_vport_irq_map_config()' is called, what is
configured related to the IRQ? What ITR stands for, etc...
Ok, more commit msg will be given next version.
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, February 28, 2023 5:50 AM
> To: Liu, Mingxia <mingxia.liu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Zhang, Yuying <yuying.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v7 11/21] net/cpfl: support write back based on ITR expire
>
> On 2/16/2023 12:30 AM, Mingxia Liu wrote:
> > Enable write back on ITR expire, then packets can be received one by
> >
>
> Can you please describe this commit more?
>
> I can see a wrapper to 'idpf_vport_irq_map_config()' is called, what is
> configured related to the IRQ? What ITR stands for, etc...
@@ -212,6 +212,15 @@ cpfl_dev_configure(struct rte_eth_dev *dev)
return 0;
}
+static int
+cpfl_config_rx_queues_irqs(struct rte_eth_dev *dev)
+{
+ struct idpf_vport *vport = dev->data->dev_private;
+ uint16_t nb_rx_queues = dev->data->nb_rx_queues;
+
+ return idpf_vport_irq_map_config(vport, nb_rx_queues);
+}
+
static int
cpfl_start_queues(struct rte_eth_dev *dev)
{
@@ -249,12 +258,37 @@ static int
cpfl_dev_start(struct rte_eth_dev *dev)
{
struct idpf_vport *vport = dev->data->dev_private;
+ struct idpf_adapter *base = vport->adapter;
+ struct cpfl_adapter_ext *adapter = CPFL_ADAPTER_TO_EXT(base);
+ uint16_t num_allocated_vectors = base->caps.num_allocated_vectors;
+ uint16_t req_vecs_num;
int ret;
+ req_vecs_num = CPFL_DFLT_Q_VEC_NUM;
+ if (req_vecs_num + adapter->used_vecs_num > num_allocated_vectors) {
+ PMD_DRV_LOG(ERR, "The accumulated request vectors' number should be less than %d",
+ num_allocated_vectors);
+ ret = -EINVAL;
+ goto err_vec;
+ }
+
+ ret = idpf_vc_vectors_alloc(vport, req_vecs_num);
+ if (ret != 0) {
+ PMD_DRV_LOG(ERR, "Failed to allocate interrupt vectors");
+ goto err_vec;
+ }
+ adapter->used_vecs_num += req_vecs_num;
+
+ ret = cpfl_config_rx_queues_irqs(dev);
+ if (ret != 0) {
+ PMD_DRV_LOG(ERR, "Failed to configure irqs");
+ goto err_irq;
+ }
+
ret = cpfl_start_queues(dev);
if (ret != 0) {
PMD_DRV_LOG(ERR, "Failed to start queues");
- return ret;
+ goto err_startq;
}
cpfl_set_rx_function(dev);
@@ -272,6 +306,11 @@ cpfl_dev_start(struct rte_eth_dev *dev)
err_vport:
cpfl_stop_queues(dev);
+err_startq:
+ idpf_vport_irq_unmap_config(vport, dev->data->nb_rx_queues);
+err_irq:
+ idpf_vc_vectors_dealloc(vport);
+err_vec:
return ret;
}
@@ -287,6 +326,10 @@ cpfl_dev_stop(struct rte_eth_dev *dev)
cpfl_stop_queues(dev);
+ idpf_vport_irq_unmap_config(vport, dev->data->nb_rx_queues);
+
+ idpf_vc_vectors_dealloc(vport);
+
vport->stopped = 1;
return 0;
@@ -24,6 +24,8 @@
#define CPFL_INVALID_VPORT_IDX 0xffff
+#define CPFL_DFLT_Q_VEC_NUM 1
+
#define CPFL_MIN_BUF_SIZE 1024
#define CPFL_MAX_FRAME_SIZE 9728
#define CPFL_DEFAULT_MTU RTE_ETHER_MTU