From patchwork Wed Feb 15 17:09:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 123974 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C712C41CA8; Wed, 15 Feb 2023 18:14:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD05F42D7E; Wed, 15 Feb 2023 18:13:18 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B2C0B42D13 for ; Wed, 15 Feb 2023 18:13:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676481183; x=1708017183; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mNFSGqbehYmU02eRdsRqR0mBaJqr3TzrBAEbBzFc5Zk=; b=bCt8twlvz47Z59yyS55smQDLyQ7N2pVuS/KJmHeNtBcr7aqAgZTBu9Fh LrnBlzKyvDqE5zxnjqfRKVTTRqRn/odGr0XvMbb2hm4xgTatdTLEg26Ur d0rg+oT3Ml9FNQFfsFEsgj+NpHQ+Nxe7pT3GG5UVz89SdgNvzE2TfuR2z a4YevM+v9enyjWjhfN7j2vfiPMJjt0Aqo6A2a2s2roSW0wGffZAB/HP4Y /Z3iVkiMT447RP7y0D7uhsvGSiI/ArsE8QNUiIjmxvzIt0WovwpVkavA8 CBKZz6d1XoH3EJM8iy9b/lZKatfvJsQcZilU4BUQ3m9bp7PN+T9qeCtS8 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="332789842" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="332789842" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 09:10:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="758489678" X-IronPort-AV: E=Sophos;i="5.97,300,1669104000"; d="scan'208";a="758489678" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by FMSMGA003.fm.intel.com with ESMTP; 15 Feb 2023 09:10:00 -0800 From: Hernan Vargas To: dev@dpdk.org, maxime.coquelin@redhat.com, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas Subject: [PATCH v2 13/16] test/bbdev: remove iteration count check Date: Wed, 15 Feb 2023 09:09:46 -0800 Message-Id: <20230215170949.60569-14-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230215170949.60569-1-hernan.vargas@intel.com> References: <20230215170949.60569-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To make the test compatible with devices that do not support early termination, the iteration count assert can be removed. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 2ce1c7e7d3..5259404ff6 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -2288,7 +2288,7 @@ validate_op_so_chain(struct rte_bbdev_op_data *op, static int validate_dec_op(struct rte_bbdev_dec_op **ops, const uint16_t n, - struct rte_bbdev_dec_op *ref_op, const int vector_mask) + struct rte_bbdev_dec_op *ref_op) { unsigned int i; int ret; @@ -2299,17 +2299,12 @@ validate_dec_op(struct rte_bbdev_dec_op **ops, const uint16_t n, struct rte_bbdev_op_turbo_dec *ops_td; struct rte_bbdev_op_data *hard_output; struct rte_bbdev_op_data *soft_output; - struct rte_bbdev_op_turbo_dec *ref_td = &ref_op->turbo_dec; for (i = 0; i < n; ++i) { ops_td = &ops[i]->turbo_dec; hard_output = &ops_td->hard_output; soft_output = &ops_td->soft_output; - if (vector_mask & TEST_BBDEV_VF_EXPECTED_ITER_COUNT) - TEST_ASSERT(ops_td->iter_count <= ref_td->iter_count, - "Returned iter_count (%d) > expected iter_count (%d)", - ops_td->iter_count, ref_td->iter_count); ret = check_dec_status_and_ordering(ops[i], i, ref_op->status); TEST_ASSERT_SUCCESS(ret, "Checking status and ordering for decoder failed"); @@ -3058,8 +3053,7 @@ dequeue_event_callback(uint16_t dev_id, if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC) { struct rte_bbdev_dec_op *ref_op = tp->op_params->ref_dec_op; - ret = validate_dec_op(tp->dec_ops, num_ops, ref_op, - tp->op_params->vector_mask); + ret = validate_dec_op(tp->dec_ops, num_ops, ref_op); /* get the max of iter_count for all dequeued ops */ for (i = 0; i < num_ops; ++i) tp->iter_count = RTE_MAX( @@ -3660,8 +3654,7 @@ throughput_pmd_lcore_dec(void *arg) } if (test_vector.op_type != RTE_BBDEV_OP_NONE) { - ret = validate_dec_op(ops_deq, num_ops, ref_op, - tp->op_params->vector_mask); + ret = validate_dec_op(ops_deq, num_ops, ref_op); TEST_ASSERT_SUCCESS(ret, "Validation failed!"); } @@ -4649,7 +4642,7 @@ throughput_test(struct active_device *ad, static int latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs, struct rte_bbdev_dec_op *ref_op, - int vector_mask, uint16_t dev_id, uint16_t queue_id, + uint16_t dev_id, uint16_t queue_id, const uint16_t num_to_process, uint16_t burst_sz, uint64_t *total_time, uint64_t *min_time, uint64_t *max_time, bool disable_et) { @@ -4709,8 +4702,7 @@ latency_test_dec(struct rte_mempool *mempool, *total_time += last_time; if (test_vector.op_type != RTE_BBDEV_OP_NONE) { - ret = validate_dec_op(ops_deq, burst_sz, ref_op, - vector_mask); + ret = validate_dec_op(ops_deq, burst_sz, ref_op); TEST_ASSERT_SUCCESS(ret, "Validation failed!"); } @@ -5065,9 +5057,9 @@ validation_latency_test(struct active_device *ad, if (op_type == RTE_BBDEV_OP_TURBO_DEC) iter = latency_test_dec(op_params->mp, bufs, - op_params->ref_dec_op, op_params->vector_mask, - ad->dev_id, queue_id, num_to_process, - burst_sz, &total_time, &min_time, &max_time, latency_flag); + op_params->ref_dec_op, ad->dev_id, queue_id, + num_to_process, burst_sz, &total_time, + &min_time, &max_time, latency_flag); else if (op_type == RTE_BBDEV_OP_LDPC_ENC) iter = latency_test_ldpc_enc(op_params->mp, bufs, op_params->ref_enc_op, ad->dev_id, queue_id,