From patchwork Tue Feb 7 15:17:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 123293 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 170F041C30; Tue, 7 Feb 2023 16:20:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B0AB42FC0; Tue, 7 Feb 2023 16:19:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 64FC342DC6 for ; Tue, 7 Feb 2023 16:18:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675783136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=inc0Gq+0xtpY6cld4VG1xw0a+xvFzl3wGKQGCbx8DCQ=; b=CWyGsqPAayvGEbrodcv2ECREv1RAQFzK+mdvqN7RXINgocB6TGVVAMwdVtGQ+4ZTIu/7kn PYXCgII/LSoun//fbA4XXTwoqaqW6cSk17Yxl2FJ5OrMkFvtIkE4o1+THyB0Cg4eM4yiDY kutAsTBgR7LOSlIRgFTHzbnFOZ6kcEQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-DXLw4xRBNAKFS4MR2MQOAg-1; Tue, 07 Feb 2023 10:18:50 -0500 X-MC-Unique: DXLw4xRBNAKFS4MR2MQOAg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B590182402A; Tue, 7 Feb 2023 15:18:18 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69BEB140EBF4; Tue, 7 Feb 2023 15:18:17 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, eperezma@redhat.com, stephen@networkplumber.org Cc: Maxime Coquelin Subject: [PATCH v2 15/21] net/virtio-user: get max number of queue pairs from device Date: Tue, 7 Feb 2023 16:17:41 +0100 Message-Id: <20230207151747.245808-16-maxime.coquelin@redhat.com> In-Reply-To: <20230207151747.245808-1-maxime.coquelin@redhat.com> References: <20230207151747.245808-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When supported by the backend (only vDPA for now), this patch gets the maximum number of queue pairs supported by the device by querying it in its config space. This is required for adding backend control queue support, as is index equals the maximum number of queues supported by the device as described by the Virtio specification. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez --- .../net/virtio/virtio_user/virtio_user_dev.c | 93 ++++++++++++++----- drivers/net/virtio/virtio_user_ethdev.c | 7 -- 2 files changed, 71 insertions(+), 29 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c index 809c9ef442..a3584e7735 100644 --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c @@ -253,6 +253,50 @@ int virtio_user_stop_device(struct virtio_user_dev *dev) return -1; } +static int +virtio_user_dev_init_max_queue_pairs(struct virtio_user_dev *dev, uint32_t user_max_qp) +{ + int ret; + + if (!(dev->device_features & (1ULL << VIRTIO_NET_F_MQ))) { + dev->max_queue_pairs = 1; + return 0; + } + + if (!dev->ops->get_config) { + dev->max_queue_pairs = user_max_qp; + return 0; + } + + ret = dev->ops->get_config(dev, (uint8_t *)&dev->max_queue_pairs, + offsetof(struct virtio_net_config, max_virtqueue_pairs), + sizeof(uint16_t)); + if (ret) { + /* + * We need to know the max queue pair from the device so that + * the control queue gets the right index. + */ + dev->max_queue_pairs = 1; + PMD_DRV_LOG(ERR, "(%s) Failed to get max queue pairs from device", dev->path); + + return ret; + } + + if (dev->max_queue_pairs > VIRTIO_MAX_VIRTQUEUE_PAIRS) { + /* + * If the device supports control queue, the control queue + * index is max_virtqueue_pairs * 2. Disable MQ if it happens. + */ + PMD_DRV_LOG(ERR, "(%s) Device advertises too many queues (%u, max supported %u)", + dev->path, dev->max_queue_pairs, VIRTIO_MAX_VIRTQUEUE_PAIRS); + dev->max_queue_pairs = 1; + + return -1; + } + + return 0; +} + int virtio_user_dev_set_mac(struct virtio_user_dev *dev) { @@ -511,24 +555,7 @@ virtio_user_dev_setup(struct virtio_user_dev *dev) return -1; } - if (virtio_user_dev_init_notify(dev) < 0) { - PMD_INIT_LOG(ERR, "(%s) Failed to init notifiers", dev->path); - goto destroy; - } - - if (virtio_user_fill_intr_handle(dev) < 0) { - PMD_INIT_LOG(ERR, "(%s) Failed to init interrupt handler", dev->path); - goto uninit; - } - return 0; - -uninit: - virtio_user_dev_uninit_notify(dev); -destroy: - dev->ops->destroy(dev); - - return -1; } /* Use below macro to filter features from vhost backend */ @@ -570,7 +597,6 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues, } dev->started = 0; - dev->max_queue_pairs = queues; dev->queue_pairs = 1; /* mq disabled by default */ dev->queue_size = queue_size; dev->is_server = server; @@ -591,23 +617,39 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues, if (dev->ops->set_owner(dev) < 0) { PMD_INIT_LOG(ERR, "(%s) Failed to set backend owner", dev->path); - return -1; + goto destroy; } if (dev->ops->get_backend_features(&backend_features) < 0) { PMD_INIT_LOG(ERR, "(%s) Failed to get backend features", dev->path); - return -1; + goto destroy; } dev->unsupported_features = ~(VIRTIO_USER_SUPPORTED_FEATURES | backend_features); if (dev->ops->get_features(dev, &dev->device_features) < 0) { PMD_INIT_LOG(ERR, "(%s) Failed to get device features", dev->path); - return -1; + goto destroy; } virtio_user_dev_init_mac(dev, mac); + if (virtio_user_dev_init_max_queue_pairs(dev, queues)) + dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ); + + if (dev->max_queue_pairs > 1) + cq = 1; + + if (virtio_user_dev_init_notify(dev) < 0) { + PMD_INIT_LOG(ERR, "(%s) Failed to init notifiers", dev->path); + goto destroy; + } + + if (virtio_user_fill_intr_handle(dev) < 0) { + PMD_INIT_LOG(ERR, "(%s) Failed to init interrupt handler", dev->path); + goto notify_uninit; + } + if (!mrg_rxbuf) dev->unsupported_features |= (1ull << VIRTIO_NET_F_MRG_RXBUF); @@ -651,11 +693,18 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, uint16_t queues, if (rte_errno != ENOTSUP) { PMD_INIT_LOG(ERR, "(%s) Failed to register mem event callback", dev->path); - return -1; + goto notify_uninit; } } return 0; + +notify_uninit: + virtio_user_dev_uninit_notify(dev); +destroy: + dev->ops->destroy(dev); + + return -1; } void diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 6ad5896378..6c3e875793 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -595,8 +595,6 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) VIRTIO_USER_ARG_CQ_NUM); goto end; } - } else if (queues > 1) { - cq = 1; } if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PACKED_VQ) == 1) { @@ -617,11 +615,6 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) } } - if (queues > 1 && cq == 0) { - PMD_INIT_LOG(ERR, "multi-q requires ctrl-q"); - goto end; - } - if (queues > VIRTIO_MAX_VIRTQUEUE_PAIRS) { PMD_INIT_LOG(ERR, "arg %s %" PRIu64 " exceeds the limit %u", VIRTIO_USER_ARG_QUEUES_NUM, queues,