From patchwork Fri Feb 3 03:13:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 122987 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5F3941BB6; Fri, 3 Feb 2023 04:14:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 997C24014F; Fri, 3 Feb 2023 04:14:19 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2108.outbound.protection.outlook.com [40.107.96.108]) by mails.dpdk.org (Postfix) with ESMTP id 8BE0840141 for ; Fri, 3 Feb 2023 04:14:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pcnhg0f/ZQuYTQrEM8uggCmtXukVhLbszd04jHDMZrqWCmIgDascHfstqKr3w5VFP8QrC7gd6lJOfC0wFB8DUGn6gV/IGK8PEX1C/fUacEwCTM1OtAibJ+jt9wrGFPpqTQPzqYLpxluIpfyQZwAFaLSxi6q2oOvcuSn1lz4gAd0ANG5DpSa+TXZEUcdCDus7xw88koUOGSwa8aChLfMcdl4pPz6Qc/UDUgIHjpxJY/hAt9Nl6PvSLyBuBLBFv1wBM8EDLL13GlZ4/uWM4b8b4nA9spXOl4VJtAQamRO2Q3434RbbFqLM7G5gAtX9eZhlKXmTvGvFp83qWb8/3+6wFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EXegHqXJjwBCR/dppxrrgqOBNCr4WqJ3876KcevoZh0=; b=dpibn1EfUpQQbeu/x+1pTITd3yGYXZsfrmzp+3+873bLum47SpSGKFW1CCA/XUPC7HR1tUKP3ARH1uPWTI/Wne95ylAWJlJ7i0rvn4sSZppojuizNEKBwQASbqjL1k45rAPc4qrObmRT7caygJn27DVoh/K56zTylqFsgYY2P8TOxDFmgACFY6YGPp0Rhu/dtjKq1Rs1ZBGfcdeW0SaQ41S62n7WKvldPb21ihxo8RU/qaVk+Jn6MSFyvAQ0T+hHcqsHIxyay7WtemI9WY+hTJNXyWh3RBYhC35oBcuNvgb5Wr3QWqdPpatfK00t+NZCjEKJFJCZuhyPBAeiZO96SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EXegHqXJjwBCR/dppxrrgqOBNCr4WqJ3876KcevoZh0=; b=XaglY4yGeDE26iVl4FQEfOI3NscuEegURdCuVo/+RVdtJvfXedslUdO1Cz+ZVVG3zWunXwc0UkQ9v6c6Bw/ze6dg8yM9jlB40jCt7Lz1NyXusB73t7Cdv7vR6LJmUZkl5FQVnofja+aWVUeOJ9rMid8HNvEmuaC2Av3hXv3aULA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SJ0PR13MB6150.namprd13.prod.outlook.com (2603:10b6:a03:4e0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Fri, 3 Feb 2023 03:14:14 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%4]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 03:14:14 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Zerun Fu , Chaoyong He Subject: [PATCH] net/nfp: refresh function comment Date: Fri, 3 Feb 2023 11:13:53 +0800 Message-Id: <20230203031353.7749-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 X-ClientProxiedBy: SI1PR02CA0025.apcprd02.prod.outlook.com (2603:1096:4:1f4::13) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SJ0PR13MB6150:EE_ X-MS-Office365-Filtering-Correlation-Id: bed1037c-c797-4e58-2deb-08db0594ba44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bYa5Mwealfo9K7WHd/3r0f8uKORtmUZcPuGNkZuqMloaqWGckZuHQDQF516I+ReWW4Nx8bvwYoiQ7WRZiRSLbjDdI4XeSS3Iibw8yI7xhc5/kwlmvq4geGUXGBULKLau7WAUrsDH6bqwGhi6Pg2VNLDtJC+bBGFcOVgqIpR3V8VaebMyNXlDAWHZ31K2y11N+d4dGovIyo8L0gRlupcpOyL/Q0JL49ba0PwKCIv8frIgKacO53sUZCRxt+xEswYcmU27l4TuE76RrFPhqETX0kz/dW+PHT71scqOUa5DNsJNQqzensMPPgq9gWox/VG1Kh/Zw5egxt58lSoTZiUqh9tDqXVcEBQqy7pR1jpYkeXS3aCcRrZtxcfAoJpR6hcMMuUZHQfV+tGv37giXlcVC2Wb7IDw9HM4kBh0utSRGYJRYvckkey+iENIM+MTFUZOiES8H9d5X/+UlNRcD94Qd+1SlLRDsuzKCVxIBvCcCkvORD+3oXeSBgk3WVSWVHC0+S8Y2hERZGXxOGRKvSN+yGbkcOnkqhg/dqKhcZWRmSSb/L3H3CfOx//Boc+Yyn9K8kfuADM89p05ne68MpyxxUcTnfy/GVVibK0X9t3RPkO3XlZDkzvfEHOD1Ox2Y1WgzV1BKOE7D/HgxxbFlc+QqPa6U3ZNBzK45/tcYCm4N+GbeMLluimiv3o/zgaLmnm3nrMSOKS6dUzMAIisQPNJ9F+sLjdQONdra0iIKG6nJeX/G5y/WvRcOJGgE3jH393Q X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39840400004)(366004)(136003)(396003)(376002)(451199018)(5660300002)(8936002)(41300700001)(38350700002)(36756003)(86362001)(44832011)(38100700002)(478600001)(2906002)(2616005)(6486002)(52116002)(6506007)(26005)(1076003)(6512007)(186003)(6666004)(107886003)(316002)(4326008)(6916009)(8676002)(83380400001)(66556008)(66946007)(66476007)(54906003)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?f7Ks9I2bMQeG/fGrJsQ7OQLVkXsq?= =?utf-8?q?YuLdmahSbrdqSVFRvAvwsiUWjlhxpzp/gyZr7E0DAV/bpI6o3zz+01/gVpkTeZP06?= =?utf-8?q?91SjEjM5yGIsfR4f8QrhtGLqFFUzR3vo1UVOk5QfJghdUs+EcGD9oyFK3t0HNzbi7?= =?utf-8?q?H1u9Uh5ZLubb6D95P6l7CCUGTI2xk64LiuC7wqBz1oPVx3CDneLdegtRG890jbSdl?= =?utf-8?q?8RVIlqrX8zc4JHp04ec8zQPUmCYNWQhFfiRN22vlMe+9StWcwqXpgHMp4GkX1ZnG8?= =?utf-8?q?ZFh6vXmjCqSfFu7esImv5w30q7RWf4Rmi5Y7G4T3+AghcPadxcmNyQTSg49BUXeWm?= =?utf-8?q?Vjb4HjhzEZb5CBhcPjATvtserVWx+6AvDMTILZ0dES2I/G6fdS7y2+QKo8TbKi373?= =?utf-8?q?9y1T1hCz8vZNv3c7QbMRCx35HePm6+xfW+iCfJiv2mEewx5qO9Nh5O/xZJ0BU01at?= =?utf-8?q?5bFe4KOySnyRcp/nm+uhKsdw3wQtHWvDS+N274cSfM5FlU1lZ50RRL1sJ+U0S/Ea0?= =?utf-8?q?v4PG3IIb06zMHIGOlj48L1x+gBHaanY9vAc77anTy5469qpLsTTCTxkT8ONSQ1zOT?= =?utf-8?q?IOrTd6jB8Tkem6bH6FAi1tTnd6IOx8J2ivef4N5Dlk7lrSm+s2lo47vut2AbfFcQp?= =?utf-8?q?pdyCGsBs8Bt1XB2jvHhwNnkng0lK3aGV+pdmxlP8djbrnVHuabPB4K2iOdsb4QK/Q?= =?utf-8?q?TCXcQRxlhAmcAyz3q3BgZUwNa89/NItc6nHJphJzB3OLJ31thtpeTYYJ2ENoiLmpb?= =?utf-8?q?iFL2pAIVj+PyNuyJEgMKxrMfSEZkQlf3r2sFaR4V/+SGohpEwSBBYby08otgF2fgM?= =?utf-8?q?IvD2uPa8T6kYObtNmAcfJTD4x2SMXCqFa8/ZfTDkOj1tSLmpZBIAV5DByfS6650EV?= =?utf-8?q?IaXHWb8lKrx7LCBkrZl52QZo5Dwy2qccD0DQiWs42A4jVBLKlaosxVkEgWpZb7cP/?= =?utf-8?q?CgS7ejUJDFvKh/FR16hkaSNdN1+jI5BCqr7NCtfKKmH52sJtE/MTJUAGBXaMuheR2?= =?utf-8?q?RJQKVi52jcnjJEmQrUGDpo4N6Xks9K6KQjQzOiDFvI0wqwAB5N+v9QaYQ1Pn66sWR?= =?utf-8?q?/fdp6GfTMRUh8ewMzppoCg4a+ZsOStS2KVDj9Dl2Ir5BBer1g3ikNpMu5Du2WTASH?= =?utf-8?q?B/nQ2tiRsfRyeMLZ8ynXKRqrFXfbOilzbGCldboDgmyIeFi5/MqXw7TmQ4QCmiXBU?= =?utf-8?q?xN49F6x7IBPcbHrN0U9L1eq2BIBIzNhke11rA2ePjKCN3xp+BGlTEFYlwbXdeArOj?= =?utf-8?q?M22KUC0AN4OIexMuFi+7dVQDIvG91+CiiyHFszvFdUnbKG+9GQIUN2n1REkFSiGwi?= =?utf-8?q?nNi0KZevFKNd7J1jDXSrr6GdtdUNEmr2DSENXSeIHLi4fbeOK1OQMr5Zj16v7SHJg?= =?utf-8?q?jimmcR6dLWB21wyZC1BE6cfVMJsSbpVzquSZFcuE5FwAnOTkoIaWuJnLgdgh+oJlh?= =?utf-8?q?WOoL17xoHabBjkSp1sJbTptN4osN9h39ASLq0ZwuaWutCu5yMYsC/3T1pMFtkFF+q?= =?utf-8?q?fIusrPyrfKYnlYYpMBxz8rWwMMrrMDWr+Q=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: bed1037c-c797-4e58-2deb-08db0594ba44 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 03:14:14.3729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1VQZG1Os2cvIJ1aZT8xDQK8YcLPJ1RJTA48zY+Ic0cdXM4Hqi9bfUMedz+FZ5cCiyZK54tiQH0HHev0ge5CHyNcn4yfhtH1HmEnUEoODmuE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB6150 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Zerun Fu Fix sections where the documentation have gone out of sync with the function names. While at it add documentation for functions to make it clear on what device they operate on. Signed-off-by: Zerun Fu Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.c | 10 ++++++++++ drivers/net/nfp/nfp_rxtx.h | 10 +++++----- drivers/net/nfp/nfpcore/nfp_nffw.c | 2 +- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index b8c874d315..20a5c20975 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -1033,6 +1033,14 @@ nfp_net_nfdk_free_tx_desc(struct nfp_net_txq *txq) (free_desc - NFDK_TX_DESC_STOP_CNT) : 0; } +/* + * nfp_net_nfdk_txq_full() - Check if the TX queue free descriptors + * is below tx_free_threshold for firmware of nfdk + * + * @txq: TX queue to check + * + * This function uses the host copy* of read/write pointers. + */ static inline uint32_t nfp_net_nfdk_txq_full(struct nfp_net_txq *txq) { @@ -1092,6 +1100,7 @@ nfp_net_nfdk_tx_maybe_close_block(struct nfp_net_txq *txq, struct rte_mbuf *pkt) return nop_slots; } +/* nfp_net_nfdk_tx_cksum() - Set TX CSUM offload flags in TX descriptor of nfdk */ static inline uint64_t nfp_net_nfdk_tx_cksum(struct nfp_net_txq *txq, struct rte_mbuf *mb, uint64_t flags) @@ -1114,6 +1123,7 @@ nfp_net_nfdk_tx_cksum(struct nfp_net_txq *txq, struct rte_mbuf *mb, return flags; } +/* nfp_net_nfdk_tx_tso() - Set TX descriptor for TSO of nfdk */ static inline uint64_t nfp_net_nfdk_tx_tso(struct nfp_net_txq *txq, struct rte_mbuf *mb) { diff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h index ced05fde90..6dfce090f3 100644 --- a/drivers/net/nfp/nfp_rxtx.h +++ b/drivers/net/nfp/nfp_rxtx.h @@ -347,12 +347,12 @@ nfp_net_nfd3_free_tx_desc(struct nfp_net_txq *txq) } /* - * nfp_net_nfd3_txq_full - Check if the TX queue free descriptors - * is below tx_free_threshold + * nfp_net_nfd3_txq_full() - Check if the TX queue free descriptors + * is below tx_free_threshold for firmware of nfd3 * * @txq: TX queue to check * - * This function uses the host copy* of read/write pointers + * This function uses the host copy* of read/write pointers. */ static inline uint32_t nfp_net_nfd3_txq_full(struct nfp_net_txq *txq) @@ -388,7 +388,7 @@ nfp_net_rx_cksum(struct nfp_net_rxq *rxq, struct nfp_net_rx_desc *rxd, mb->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; } -/* Set NFD3 TX descriptor for TSO */ +/* nfp_net_nfd3_tx_tso() - Set NFD3 TX descriptor for TSO */ static inline void nfp_net_nfd3_tx_tso(struct nfp_net_txq *txq, struct nfp_net_nfd3_tx_desc *txd, @@ -420,7 +420,7 @@ nfp_net_nfd3_tx_tso(struct nfp_net_txq *txq, txd->mss = 0; } -/* Set TX CSUM offload flags in NFD3 TX descriptor */ +/* nfp_net_nfd3_tx_cksum() - Set TX CSUM offload flags in NFD3 TX descriptor */ static inline void nfp_net_nfd3_tx_cksum(struct nfp_net_txq *txq, struct nfp_net_nfd3_tx_desc *txd, struct rte_mbuf *mb) diff --git a/drivers/net/nfp/nfpcore/nfp_nffw.c b/drivers/net/nfp/nfpcore/nfp_nffw.c index 8bec0e3c9a..9bba8a4459 100644 --- a/drivers/net/nfp/nfpcore/nfp_nffw.c +++ b/drivers/net/nfp/nfpcore/nfp_nffw.c @@ -161,7 +161,7 @@ nfp_nffw_info_open(struct nfp_cpp *cpp) } /* - * nfp_nffw_info_release() - Release the lock on the NFFW table + * nfp_nffw_info_close() - Release the lock on the NFFW table * @state: NFP FW info state * * Return: 0, or -ERRNO