From patchwork Wed Feb 1 04:20:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalesh A P X-Patchwork-Id: 122774 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE03E41B96; Wed, 1 Feb 2023 05:23:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C11D42D29; Wed, 1 Feb 2023 05:23:19 +0100 (CET) Received: from relay.smtp-ext.broadcom.com (saphodev.broadcom.com [192.19.144.205]) by mails.dpdk.org (Postfix) with ESMTP id 636D542D0C for ; Wed, 1 Feb 2023 05:23:18 +0100 (CET) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 07C76C0000E8; Tue, 31 Jan 2023 20:23:16 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 07C76C0000E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1675225398; bh=ppXuhSU5iYBIV5puLNXvfFzAb38gdLEcWRx5HNr6r4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qNL6BeVUdZ2DFlkrvIa0JRNyqAch3k4YLr5h/ibyRp21IYDktlxRImfZiWYjVNAPE 9mOomaevvmmBCFKbnpBt15Q1hVUWLOJmmj5J4azEAFrXSYazJGcDyVMUVrMLIZD++P A4oLFgl7l/uIaYOysmZftSO4Xi7VAn7LRBQjX1vE= From: Kalesh A P To: dev@dpdk.org Cc: ferruh.yigit@amd.com, ajit.khaparde@broadcom.com Subject: [dpdk-dev] [PATCH 3/3] net/bnxt: do not corrupt RSS hash value in the mbuf Date: Wed, 1 Feb 2023 09:50:14 +0530 Message-Id: <20230201042014.23526-4-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20230201042014.23526-1-kalesh-anakkur.purayil@broadcom.com> References: <20230201042014.23526-1-kalesh-anakkur.purayil@broadcom.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Venkat Duvvuru By clearing mbuf->hash.fdir.id in the data path, the driver is corrupting the RSS hash value populated in the mbuf as they are defined as a union. This patch fixes the problem by removing the code that clears mbuf->hash.fdir.id. Fixes: 17b6c8386d73 ("net/bnxt: fix mark handling") Cc: stable@dpdk.org Signed-off-by: Venkat Duvvuru Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha --- drivers/net/bnxt/bnxt_rxr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index daaf9ff..0eebddb 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -813,7 +813,6 @@ bnxt_ulp_set_mark_in_mbuf(struct bnxt *bp, struct rx_pkt_cmpl_hi *rxcmp1, skip_mark: mbuf->hash.fdir.hi = 0; - mbuf->hash.fdir.id = 0; return 0; }