From patchwork Wed Jan 18 07:14:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liu, Mingxia" X-Patchwork-Id: 122252 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA3364240B; Wed, 18 Jan 2023 09:11:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 082F142D68; Wed, 18 Jan 2023 09:10:35 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A4EFF42D3E for ; Wed, 18 Jan 2023 09:10:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674029430; x=1705565430; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IDoUf6IqNbs8MTx9OdlOabiEsE2vYbR4Qo0i+ADc0k4=; b=cDGtIHNrc+skkACze8Kf81/r4TLmXqqZItCvaIa/QDEY3E9AlLgqnERs U5X7U12UJ6EPSGvmhmRaeEWPrEuObh2i+DbWtKnYJBFtCuG66/qX1BxNU LQwIDT3oTTFsJSoHxsZ/wMQVqzEmxRLPXULHWb2v7qq0thDPJ7gW/xfWO FmRSg6LxMzxB0AESI2f9tGbusj6HQIrmFPS+LP1jaOQ4rgqCMq2zZhHkY aF3/q146AXwUhUObFFSNAuSMJWwmtJJV+q1PbYoKE4DN9Od3g42lUsRcc wahxMSDaaq8VA7oRaa0mojCKWJpJw9egYBrDCe8T9xDWeNKDWsiSARL+n w==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="411166213" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="411166213" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 00:10:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="783577544" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="783577544" Received: from dpdk-mingxial-01.sh.intel.com ([10.67.119.167]) by orsmga004.jf.intel.com with ESMTP; 18 Jan 2023 00:10:28 -0800 From: Mingxia Liu To: dev@dpdk.org Cc: jingjing.wu@intel.com, beilei.xing@intel.com, Mingxia Liu Subject: [PATCH v3 6/6] common/idpf: add xstats ops Date: Wed, 18 Jan 2023 07:14:40 +0000 Message-Id: <20230118071440.902155-7-mingxia.liu@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230118071440.902155-1-mingxia.liu@intel.com> References: <20230111071545.504706-1-mingxia.liu@intel.com> <20230118071440.902155-1-mingxia.liu@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support for these device ops: -idpf_dev_xstats_get -idpf_dev_xstats_get_names -idpf_dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 80 ++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index b86f63f94e..bcd15db3c5 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -80,6 +80,30 @@ static const uint64_t idpf_ipv6_rss = RTE_ETH_RSS_NONFRAG_IPV6_UDP | RTE_ETH_RSS_NONFRAG_IPV6_OTHER | RTE_ETH_RSS_FRAG_IPV6; +struct rte_idpf_xstats_name_off { + char name[RTE_ETH_XSTATS_NAME_SIZE]; + unsigned int offset; +}; + +static const struct rte_idpf_xstats_name_off rte_idpf_stats_strings[] = { + {"rx_bytes", offsetof(struct virtchnl2_vport_stats, rx_bytes)}, + {"rx_unicast_packets", offsetof(struct virtchnl2_vport_stats, rx_unicast)}, + {"rx_multicast_packets", offsetof(struct virtchnl2_vport_stats, rx_multicast)}, + {"rx_broadcast_packets", offsetof(struct virtchnl2_vport_stats, rx_broadcast)}, + {"rx_dropped_packets", offsetof(struct virtchnl2_vport_stats, rx_discards)}, + {"rx_errors", offsetof(struct virtchnl2_vport_stats, rx_errors)}, + {"rx_unknown_protocol_packets", offsetof(struct virtchnl2_vport_stats, + rx_unknown_protocol)}, + {"tx_bytes", offsetof(struct virtchnl2_vport_stats, tx_bytes)}, + {"tx_unicast_packets", offsetof(struct virtchnl2_vport_stats, tx_unicast)}, + {"tx_multicast_packets", offsetof(struct virtchnl2_vport_stats, tx_multicast)}, + {"tx_broadcast_packets", offsetof(struct virtchnl2_vport_stats, tx_broadcast)}, + {"tx_dropped_packets", offsetof(struct virtchnl2_vport_stats, tx_discards)}, + {"tx_error_packets", offsetof(struct virtchnl2_vport_stats, tx_errors)}}; + +#define IDPF_NB_XSTATS (sizeof(rte_idpf_stats_strings) / \ + sizeof(rte_idpf_stats_strings[0])) + static int idpf_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) @@ -312,6 +336,59 @@ idpf_dev_stats_reset(struct rte_eth_dev *dev) return 0; } +static int idpf_dev_xstats_reset(struct rte_eth_dev *dev) +{ + idpf_dev_stats_reset(dev); + return 0; +} + +static int idpf_dev_xstats_get(struct rte_eth_dev *dev, + struct rte_eth_xstat *xstats, unsigned int n) +{ + struct idpf_vport *vport = + (struct idpf_vport *)dev->data->dev_private; + struct virtchnl2_vport_stats *pstats = NULL; + unsigned int i; + int ret; + + if (n < IDPF_NB_XSTATS) + return IDPF_NB_XSTATS; + + if (!xstats) + return 0; + + ret = idpf_query_stats(vport, &pstats); + if (ret) { + PMD_DRV_LOG(ERR, "Get statistics failed"); + return 0; + } + + idpf_update_stats(&vport->eth_stats_offset, pstats); + + /* loop over xstats array and values from pstats */ + for (i = 0; i < IDPF_NB_XSTATS; i++) { + xstats[i].id = i; + xstats[i].value = *(uint64_t *)(((char *)pstats) + + rte_idpf_stats_strings[i].offset); + } + return IDPF_NB_XSTATS; +} + +static int idpf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, + struct rte_eth_xstat_name *xstats_names, + __rte_unused unsigned int limit) +{ + unsigned int i; + + if (xstats_names) + for (i = 0; i < IDPF_NB_XSTATS; i++) { + snprintf(xstats_names[i].name, + sizeof(xstats_names[i].name), + "%s", rte_idpf_stats_strings[i].name); + } + return IDPF_NB_XSTATS; +} + static int idpf_config_rss_hf(struct idpf_vport *vport, uint64_t rss_hf) { uint64_t hena = 0, valid_rss_hf = 0; @@ -1158,6 +1235,9 @@ static const struct eth_dev_ops idpf_eth_dev_ops = { .reta_query = idpf_rss_reta_query, .rss_hash_update = idpf_rss_hash_update, .rss_hash_conf_get = idpf_rss_hash_conf_get, + .xstats_get = idpf_dev_xstats_get, + .xstats_get_names = idpf_dev_xstats_get_names, + .xstats_reset = idpf_dev_xstats_reset, }; static uint16_t