[11/11] common/cnxk: disable drop re in A1 chip revision

Message ID 20221128095442.3185112-11-ndabilpuram@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [01/11] common/cnxk: free pending sqe buffers |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation warning apply issues

Commit Message

Nithin Dabilpuram Nov. 28, 2022, 9:54 a.m. UTC
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Disable drop re in CN10KA A1 as enabling it would leak
event vector buffers.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/common/cnxk/roc_errata.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jerin Jacob Jan. 6, 2023, 1:22 p.m. UTC | #1
On Mon, Nov 28, 2022 at 3:25 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Disable drop re in CN10KA A1 as enabling it would leak
> event vector buffers.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Updated the git commits[2] and minor cleanup[1] in 1/11 as follows and
applied to dpdk-next-net-mrvl/for-next-net. Thanks

[1]

diff --git a/drivers/common/cnxk/roc_nix_irq.c
b/drivers/common/cnxk/roc_nix_irq.c
index 2e4bccb713..2b731302cd 100644
--- a/drivers/common/cnxk/roc_nix_irq.c
+++ b/drivers/common/cnxk/roc_nix_irq.c
@@ -328,9 +328,8 @@ nix_lf_q_irq(void *param)
        roc_nix_queues_ctx_dump(nix_priv_to_roc_nix(nix), NULL);

        /* Call reset callback */
-       if (intr_cb)
-               if (dev->ops->q_err_cb)
-                       dev->ops->q_err_cb(nix_priv_to_roc_nix(nix), NULL);
+       if (intr_cb && dev->ops->q_err_cb)
+               dev->ops->q_err_cb(nix_priv_to_roc_nix(nix), NULL);

[2]
commit 6141ebf5fbf3c2ccc4b78ab9491ccb43e570565b (HEAD -> for-next-net,
origin/for-next-net)
Author: Pavan Nikhilesh <pbhagavatula@marvell.com>
Date:   Mon Nov 28 15:24:42 2022 +0530

    common/cnxk: disable drop receive error in A1 revision

    Disable drop receive error in CN10KA A1 as enabling it would leak
    event vector buffers.

    Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

commit b7feb7d248072637d7143c6686ffc1ee7e04a3a7
Author: Pavan Nikhilesh <pbhagavatula@marvell.com>
Date:   Mon Nov 28 15:24:41 2022 +0530

    net/cnxk: mark HW errors as bad checksum

    Mark NIX packet parsing errors due to NPC/NPA errors as bad
    packets by setting L3/L4 checksum as BAD in olflags.
    Application can decide the fate of these packets.

    Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

commit 3dab27b88d5b367bf1d83f5ac6efc89bb9f0cc6d
Author: Kommula Shiva Shankar <kshankar@marvell.com>
Date:   Mon Nov 28 15:24:40 2022 +0530

    common/cnxk: fix aura ID handling

    Fix the  aura handle to aura id while initialising
    inline dev SSO XAQ aura

    Fixes: 6f30ac80ca6b ("common/cnxk: use XAQ create API for inline device")
    Cc: stable@dpdk.org

    Signed-off-by: Kommula Shiva Shankar <kshankar@marvell.com>

commit ff38e5da017d04760762fcb30227c91f338abb93
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Nov 28 15:24:39 2022 +0530

    common/cnxk: use lcore LMT line for CPT context write

    Use lcore LMT line for CPT context write as no one else
    is using it.

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

commit 9ac550f477b93c413d7dd57bf280d1d83a8436aa
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Nov 28 15:24:38 2022 +0530

    net/cnxk: support late backpressure for cn10kb

    Add late backpressure support for cn10kb and set it up
    to backpressure CPT.

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

commit a5d5985247aa3bda9790df6961d57ceeb62c9e54
Author: Nithin Dabilpuram <ndabilpuram@marvell.com>
Date:   Mon Nov 28 15:24:37 2022 +0530

    net/cnxk: fix packet type for IPv6 packets post decryption

    Update ptype properly for IPv6 packets post inline decryption.

    Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures")
    Cc: stable@dpdk.org

    Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

commit 323b51f6adb985711d38069d1390e0bfa2560a3b
Author: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Date:   Mon Nov 28 15:24:36 2022 +0530

    event/cnxk: net/cnxk: support transmit completion

    added support to call callback handler provided
    by user when external buffer is attached to mbuf
    and transmit completion is enabled.Added support to
    enable transmit completion as device args

    Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>

commit 8950250f5241d12f7b32f424dab74bdf67350183
Author: Satha Rao <skoteshwar@marvell.com>
Date:   Mon Nov 28 15:24:35 2022 +0530

    common/cnxk: split NIX TM hierarchy enable API

    roc_nix_tm_hierarchy_enable() API will do two things internally,
    1) Creation of all TM nodes, allocate HW resources and connect
       them as requested.
    2) Enable transmit by XON SMQ and start SQs

    In test cases where both steps called independently. In order
    to support this, patch split the functionality into two APIs.

    Signed-off-by: Satha Rao <skoteshwar@marvell.com>

commit 05faa3527fdb9ca1875b5dab61c2916d9f0e3239
Author: Satha Rao <skoteshwar@marvell.com>
Date:   Mon Nov 28 15:24:34 2022 +0530

    common/cnxk: set default SQ TC value

    Zero is valid TC, initialize SQ TC value to ROC_NIX_PFC_CLASS_INVALID.

    Signed-off-by: Satha Rao <skoteshwar@marvell.com>

commit e5b2caa96a0358d83efb0e495074f69f0c1de034
Author: Satha Rao <skoteshwar@marvell.com>
Date:   Mon Nov 28 15:24:33 2022 +0530

    net/cnxk: register callback to get queue errors

    Register a callback mechanism to get SQ error interrupts, add
    call ethdev event RTE_ETH_EVENT_INTR_RESET.

    Signed-off-by: Satha Rao <skoteshwar@marvell.com>

commit 5f0d6a1ab3b4ff73cdbce8158cabe6d9a42cdcf8
Author: Satha Rao <skoteshwar@marvell.com>
Date:   Mon Nov 28 15:24:32 2022 +0530

    common/cnxk: free pending SQE buffers

    This patch provides a callback mechanism when SQ receives MNQ_ERR.
    Even when SQ got MNQ_ERR interrupt application still enqueue
    packets for sending they will be struck at SQ, so we are freeing
    all these pending packets when we called SQ finish.

    Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> ---
>  drivers/common/cnxk/roc_errata.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_errata.h b/drivers/common/cnxk/roc_errata.h
> index a39796e894..36e6db467a 100644
> --- a/drivers/common/cnxk/roc_errata.h
> +++ b/drivers/common/cnxk/roc_errata.h
> @@ -9,7 +9,7 @@ static inline bool
>  roc_errata_nix_has_no_drop_re(void)
>  {
>         return (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||
> -               roc_model_is_cnf10kb_a0());
> +               roc_model_is_cnf10kb_a0() || roc_model_is_cn10ka_a1());
>  }
>
>  /* Errata NIX-34873 */
> --
> 2.25.1
>
  

Patch

diff --git a/drivers/common/cnxk/roc_errata.h b/drivers/common/cnxk/roc_errata.h
index a39796e894..36e6db467a 100644
--- a/drivers/common/cnxk/roc_errata.h
+++ b/drivers/common/cnxk/roc_errata.h
@@ -9,7 +9,7 @@  static inline bool
 roc_errata_nix_has_no_drop_re(void)
 {
 	return (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() ||
-		roc_model_is_cnf10kb_a0());
+		roc_model_is_cnf10kb_a0() || roc_model_is_cn10ka_a1());
 }
 
 /* Errata NIX-34873 */