From patchwork Mon Nov 21 20:40:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 120008 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E97A4A056B; Mon, 21 Nov 2022 21:40:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 533D542D49; Mon, 21 Nov 2022 21:40:37 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mails.dpdk.org (Postfix) with ESMTP id 1333542D34 for ; Mon, 21 Nov 2022 21:40:34 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9A0AB81609 for ; Mon, 21 Nov 2022 20:40:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AB65C433B5; Mon, 21 Nov 2022 20:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669063233; bh=oHaDV31fM9fCCpa5MAVlnIcPqzO80QaGThP4QaY/wWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZzqLwd73viIZGuUKgCvHk7gguu/ZfeiGhv8mdByJTZIBnm3mevT8oeiqh9q94waRc dWp9Kko+gTmiAogTooXJDTMTFG5CdJm/7ZLvanOxxHZ+tw/Tx5IVseFZrL+DnLXBFw xxq3azGA/tQhvoExGMPWoFtTfMzhvTLp8kIIV0yMHJ9KE3Q7Erz7BbHesD6WIfRO69 r103wA8ASR0A56vgtKwQCalDvAE8v9o4XfiI73bihK0Kx+eDNXotF+WrKtnvxxSp7L 9T7niD+AMgIxAmN8YO3lYdaiba6KnYdDaDq0fbIaB0/YXUbU+mQ3vzLIhiCt+w2nyX rtFoOD9zmKJ+A== From: okaya@kernel.org To: dev@dpdk.org Cc: Sinan Kaya Subject: [PATCH 05/11] malloc: malloc_elem_join_adjacent_free can return null Date: Mon, 21 Nov 2022 15:40:11 -0500 Message-Id: <20221121204015.1135573-6-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221121204015.1135573-1-okaya@kernel.org> References: <20221121204015.1135573-1-okaya@kernel.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index d7c410b786..d2ccc387bf 100644 --- a/lib/eal/common/malloc_heap.c +++ b/lib/eal/common/malloc_heap.c @@ -97,6 +97,9 @@ malloc_heap_add_memory(struct malloc_heap *heap, struct rte_memseg_list *msl, malloc_elem_insert(elem); elem = malloc_elem_join_adjacent_free(elem); + if (!elem) { + return NULL; + } malloc_elem_free_list_insert(elem);