net/nfp: fix the problem of mask table free

Message ID 20221115011308.12101-1-chaoyong.he@corigine.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/nfp: fix the problem of mask table free |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build fail github build: failed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Chaoyong He Nov. 15, 2022, 1:13 a.m. UTC
  The free process of mask table has problem, should use
'rte_has_free()' rather than 'rte_free()'.

Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload")

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 drivers/net/nfp/nfp_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit Nov. 18, 2022, 12:45 p.m. UTC | #1
On 11/15/2022 1:13 AM, Chaoyong He wrote:
> The free process of mask table has problem, should use
> 'rte_has_free()' rather than 'rte_free()'.

s/_has_/_hash_/

> 
> Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload")
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

Applied to dpdk-next-net/main, thanks.
  

Patch

diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index af56e7bef2..6f79d950db 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -4116,7 +4116,7 @@  nfp_flow_priv_init(struct nfp_pf_dev *pf_dev)
 free_flow_table:
 	rte_hash_free(priv->flow_table);
 free_mask_table:
-	rte_free(priv->mask_table);
+	rte_hash_free(priv->mask_table);
 free_stats:
 	rte_free(priv->stats);
 free_stats_id: