From patchwork Sun Nov 13 11:07:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 119811 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AF01A0567; Sun, 13 Nov 2022 12:07:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0D594014F; Sun, 13 Nov 2022 12:07:50 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2084.outbound.protection.outlook.com [40.107.95.84]) by mails.dpdk.org (Postfix) with ESMTP id 6A25B40041; Sun, 13 Nov 2022 12:07:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcDU3gNyIO9DXhoveOAEx1ZVYQRuhUwspwcX6n41Crp2fBgjGocyoTquNm4232vIn2u4Cr3l03Wqr1GzeoeCxAMlFUgxXMQ4uhIdguEBSxzbsGAw6IbDcEXL8kuqqRQGDMOlAJ0WtLsA/8TdIAEpDlqolAeDXsu3XIc2lNwYBjWAz4eKoiQewXwHBX6yw4yBD6xekTiPbe946nuPG4us0pEyTp5U9EVqbwbzWLXrPdahiDbBQVCeOjkuIb6K6RRYCiml0nN/rVRSD+oIizw9buUKN+eOBKyPN/Sjt3XocpSmy6NxH+EVqUf08J3by+YRfODXdKhjgJ3tUpAdtGVWBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZRswwO/R863qV6ffYt+SvB25gocljA/uZ8W/qW3r7w8=; b=FpxFsW6c66/quiJERchu5RxklAN5QjR/or25wt14ADhqVy47NYDSM0xO6hHOcR/G7XtjL8RSRV/4aSOwROA94ASrDDy4HqJgk/l73uMwvik5eo+XdpXxGztxQcLkCsSdF2vIljP0AU/5Fn2QiJOmHwp/3+kxK0OgqbYlX5XvsIXAuD+h7m0xwGnhfQSs0NAMFqinoF4Xu59lDQv3GeKSqcum3XO1Cr6cIsLVlN7uK0kWjpL1n2MuOpj+VXn3vnOWG3pVAWAzIo01BpHXuEuTXXwNqQv8933oIB8FMpBuXAb0kGr+uEhqeHdLwOlxoY/K0M6ScdcV64rT56ZIlyySsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRswwO/R863qV6ffYt+SvB25gocljA/uZ8W/qW3r7w8=; b=bmIhgXDWWFm0w1Z/iMS51GGLwSfYGWfR5nCYU9ImPLfY5jc5jExVPMx2jAxn7IzW/IJ4DmXr4FPYr1B099YryXgTnzmv6DSCZQ51cs2lAd/vmI3E+ZHDBu5j11RsNui1qCoft/MrFks1MBZkqPwzvqx+Dz3/oifj0ZkJPEp1gB3lNFQ7UUsCOGEzreCSv7A4DMRpFqWH0VgHiabJxlXqjgtLmXBCiuGzu1/zTK+hn33MxKtl8woxgceIxHlsJ+YWXKY5Zwljelka47nQXiYi82Na+F37JjF9uHc3p8beTkPtCSByC2rg0WIzX53UGZpgLkWElSZ8ggDKEIkzRqa7Qg== Received: from MN2PR04CA0035.namprd04.prod.outlook.com (2603:10b6:208:d4::48) by CH0PR12MB5217.namprd12.prod.outlook.com (2603:10b6:610:d0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Sun, 13 Nov 2022 11:07:47 +0000 Received: from BL02EPF0000EE3F.namprd05.prod.outlook.com (2603:10b6:208:d4:cafe::82) by MN2PR04CA0035.outlook.office365.com (2603:10b6:208:d4::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16 via Frontend Transport; Sun, 13 Nov 2022 11:07:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0000EE3F.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Sun, 13 Nov 2022 11:07:45 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Sun, 13 Nov 2022 03:07:35 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 13 Nov 2022 03:07:35 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36 via Frontend Transport; Sun, 13 Nov 2022 03:07:33 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , , Subject: [PATCH] net/mlx5: fix wrong error log in async flow destruction Date: Sun, 13 Nov 2022 13:07:27 +0200 Message-ID: <20221113110727.668671-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3F:EE_|CH0PR12MB5217:EE_ X-MS-Office365-Filtering-Correlation-Id: 024e11a9-7144-4787-318f-08dac5674ada X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FvTcCm5H1/5P/dFSGpfc6eZsAKCmdGol4ycsqbujXD/I9odHH0sy6OxkojyZ0GjsvpmBl1Dow1z5oBhCQqgH5pgWc6JOS3wtxLlebCnU0hD4qv4vchAQJ95o7uwZqukESWNv3zQJQFfKc1bq6JruwS4tdF7AYeA2j2d6Pt736h/k5I3/6nWZFGqqPukrjC59hssWxQYdvo7rsGQzqSTJQemOShMM4ofD1cL/oaNhjORiFt9pIyTuskEKinKPxa+EO5ii+JQEXFTVlbpDzjJzwUhvUTJD4KkIkSqtDw9rIPFT4bP52OMfu6bT6SyXd3nTE3SFHTcJpoJSqYUBy0BrCGAzt3wUlAMb6/JYIl/53zpPkoxgkRIazS9FrENFBCI116I3MyXzDLjV3nsEyx6bum8jjT8vvztLpULybbDaHpH8Sozq9CSVekXyDadmcn+IwTuNi7LKV7+b8tl31WJPuCt3fleD3BKgKmenQzMTc5EwCqoqJA3O8t0bZ4Tqeg8eV1gFvbF8h7tiw0qzRAg+++qky4p/Ams072KvtfFP1eykL0rtfR/QR3uY2vsDrY3Gh+MloTasmMabp1hgZg95aJBVHZvLGulD6MtgN7S4zKlAeuuwlmAd9LnLEcOkZHMdlXE+M78sFhIge03E7naQIz1hV2jJaZ7Ir8Gyu2D69paHEKcIgUK//9zzTcHM7ChMPt5htmBETLS34lnJV1MtsxoO966lOKDkCuqLh4Yk9bzz3rU1uKXDywm82IH5KuYhH+qRRsWmkCc4SGY7hANYTA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(40470700004)(36840700001)(46966006)(86362001)(36756003)(2906002)(36860700001)(4744005)(8936002)(83380400001)(47076005)(7636003)(356005)(82740400003)(2616005)(1076003)(426003)(336012)(186003)(316002)(6916009)(450100002)(54906003)(82310400005)(478600001)(40480700001)(55016003)(40460700003)(8676002)(4326008)(41300700001)(70586007)(70206006)(26005)(6286002)(6666004)(7696005)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2022 11:07:45.2275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 024e11a9-7144-4787-318f-08dac5674ada X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5217 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The flow_hw_async_flow_destroy() function fills the error structure in case of failure. The error log reported by function is "fail to create rte flow" while the correct failure is in destruction. This patch changes the error log to report "fail to destroy rte flow". Fixes: c40c061a022e ("net/mlx5: add basic flow queue operation") Cc: suanmingm@nvidia.com Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 537bcf141d..979eec8dc4 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -2623,7 +2623,7 @@ flow_hw_async_flow_destroy(struct rte_eth_dev *dev, error: return rte_flow_error_set(error, rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, - "fail to create rte flow"); + "fail to destroy rte flow"); } /**