diff mbox series

[v3,13/14] net/i40e: fix whitespace

Message ID 20221109232451.265059-14-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series whitespace after keywords |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Nov. 9, 2022, 11:24 p.m. UTC 
  Add space after keywords.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/i40e/i40e_pf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Zhang, Yuying Nov. 11, 2022, 6:23 a.m. UTC | #1 
Hi,

Could you add fix line and Cc: stable@dpdk.org?
The fix looks good to me.

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: 2022年11月10日 7:25
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Zhang, Yuying
> <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH v3 13/14] net/i40e: fix whitespace
> 
> Add space after keywords.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-off-by: Yuying Zhang <yuying.zhang@intel.com>


> ---
>  drivers/net/i40e/i40e_pf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index
> 15d9ff868f3a..7050e0057d8e 100644
> --- a/drivers/net/i40e/i40e_pf.c
> +++ b/drivers/net/i40e/i40e_pf.c
> @@ -956,7 +956,7 @@ i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf
> *vf,
> 
>  	for (i = 0; i < vlan_filter_list->num_elements; i++) {
>  		ret = i40e_vsi_add_vlan(vf->vsi, vid[i]);
> -		if(ret != I40E_SUCCESS)
> +		if (ret != I40E_SUCCESS)
>  			goto send_msg;
>  	}
> 
> @@ -996,7 +996,7 @@ i40e_pf_host_process_cmd_del_vlan(struct i40e_pf_vf
> *vf,
>  	vid = vlan_filter_list->vlan_id;
>  	for (i = 0; i < vlan_filter_list->num_elements; i++) {
>  		ret = i40e_vsi_delete_vlan(vf->vsi, vid[i]);
> -		if(ret != I40E_SUCCESS)
> +		if (ret != I40E_SUCCESS)
>  			goto send_msg;
>  	}
> 
> @@ -1577,12 +1577,12 @@ i40e_pf_host_init(struct rte_eth_dev *dev)
>  	 * return if SRIOV not enabled, VF number not configured or
>  	 * no queue assigned.
>  	 */
> -	if(!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0)
> +	if (!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps ==
> +0)
>  		return I40E_SUCCESS;
> 
>  	/* Allocate memory to store VF structure */
>  	pf->vfs = rte_zmalloc("i40e_pf_vf",sizeof(*pf->vfs) * pf->vf_num, 0);
> -	if(pf->vfs == NULL)
> +	if (pf->vfs == NULL)
>  		return -ENOMEM;
> 
>  	/* Disable irq0 for VFR event */
> --
> 2.35.1
Zhang, Yuying Nov. 11, 2022, 7:12 a.m. UTC | #2 
fix

> -----Original Message-----
> From: Zhang, Yuying
> Sent: 2022年11月11日 14:24
> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>
> Subject: RE: [PATCH v3 13/14] net/i40e: fix whitespace
> 
> Hi,
> 
> Could you add fix line and Cc: stable@dpdk.org?
> The fix looks good to me.
> 
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: 2022年11月10日 7:25
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>; Zhang, Yuying
> > <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Subject: [PATCH v3 13/14] net/i40e: fix whitespace
> >
> > Add space after keywords.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Yuying Zhang <yuying.zhang@intel.com>

> > ---
> >  drivers/net/i40e/i40e_pf.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
> > index 15d9ff868f3a..7050e0057d8e 100644
> > --- a/drivers/net/i40e/i40e_pf.c
> > +++ b/drivers/net/i40e/i40e_pf.c
> > @@ -956,7 +956,7 @@ i40e_pf_host_process_cmd_add_vlan(struct
> > i40e_pf_vf *vf,
> >
> >  	for (i = 0; i < vlan_filter_list->num_elements; i++) {
> >  		ret = i40e_vsi_add_vlan(vf->vsi, vid[i]);
> > -		if(ret != I40E_SUCCESS)
> > +		if (ret != I40E_SUCCESS)
> >  			goto send_msg;
> >  	}
> >
> > @@ -996,7 +996,7 @@ i40e_pf_host_process_cmd_del_vlan(struct
> > i40e_pf_vf *vf,
> >  	vid = vlan_filter_list->vlan_id;
> >  	for (i = 0; i < vlan_filter_list->num_elements; i++) {
> >  		ret = i40e_vsi_delete_vlan(vf->vsi, vid[i]);
> > -		if(ret != I40E_SUCCESS)
> > +		if (ret != I40E_SUCCESS)
> >  			goto send_msg;
> >  	}
> >
> > @@ -1577,12 +1577,12 @@ i40e_pf_host_init(struct rte_eth_dev *dev)
> >  	 * return if SRIOV not enabled, VF number not configured or
> >  	 * no queue assigned.
> >  	 */
> > -	if(!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0)
> > +	if (!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps ==
> > +0)
> >  		return I40E_SUCCESS;
> >
> >  	/* Allocate memory to store VF structure */
> >  	pf->vfs = rte_zmalloc("i40e_pf_vf",sizeof(*pf->vfs) * pf->vf_num, 0);
> > -	if(pf->vfs == NULL)
> > +	if (pf->vfs == NULL)
> >  		return -ENOMEM;
> >
> >  	/* Disable irq0 for VFR event */
> > --
> > 2.35.1
Stephen Hemminger Nov. 11, 2022, 4:48 p.m. UTC | #3 
On Fri, 11 Nov 2022 06:23:31 +0000
"Zhang, Yuying" <yuying.zhang@intel.com> wrote:

> Hi,
> 
> Could you add fix line and Cc: stable@dpdk.org?
> The fix looks good to me.

Whitespace changes don't belong in stable unless they are prerequisite for another change.
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
index 15d9ff868f3a..7050e0057d8e 100644
--- a/drivers/net/i40e/i40e_pf.c
+++ b/drivers/net/i40e/i40e_pf.c
@@ -956,7 +956,7 @@  i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf *vf,
 
 	for (i = 0; i < vlan_filter_list->num_elements; i++) {
 		ret = i40e_vsi_add_vlan(vf->vsi, vid[i]);
-		if(ret != I40E_SUCCESS)
+		if (ret != I40E_SUCCESS)
 			goto send_msg;
 	}
 
@@ -996,7 +996,7 @@  i40e_pf_host_process_cmd_del_vlan(struct i40e_pf_vf *vf,
 	vid = vlan_filter_list->vlan_id;
 	for (i = 0; i < vlan_filter_list->num_elements; i++) {
 		ret = i40e_vsi_delete_vlan(vf->vsi, vid[i]);
-		if(ret != I40E_SUCCESS)
+		if (ret != I40E_SUCCESS)
 			goto send_msg;
 	}
 
@@ -1577,12 +1577,12 @@  i40e_pf_host_init(struct rte_eth_dev *dev)
 	 * return if SRIOV not enabled, VF number not configured or
 	 * no queue assigned.
 	 */
-	if(!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0)
+	if (!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0)
 		return I40E_SUCCESS;
 
 	/* Allocate memory to store VF structure */
 	pf->vfs = rte_zmalloc("i40e_pf_vf",sizeof(*pf->vfs) * pf->vf_num, 0);
-	if(pf->vfs == NULL)
+	if (pf->vfs == NULL)
 		return -ENOMEM;
 
 	/* Disable irq0 for VFR event */