[v2] examples/fips_validation: fix typo

Message ID 20221107100330.2672470-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v2] examples/fips_validation: fix typo |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

De Lara Guarch, Pablo Nov. 7, 2022, 10:03 a.m. UTC
  Digest length is being printed out, not IV length.

Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
Cc: marko.kovacevic@intel.com
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
-v2: added missing "Signed-off"
---

 examples/fips_validation/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Brian Dooley Nov. 7, 2022, 2:37 p.m. UTC | #1
Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Monday, November 7, 2022 10:04 AM
> To: Dooley, Brian <brian.dooley@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] examples/fips_validation: fix typo
> 
> Digest length is being printed out, not IV length.
> 
> Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
> Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> Cc: marko.kovacevic@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> -v2: added missing "Signed-off"
> ---
> 
>  examples/fips_validation/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/fips_validation/main.c
> b/examples/fips_validation/main.c index 404a29d7b6..9a9babb53a 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -1210,7 +1210,7 @@ prepare_hmac_xform(struct
> rte_crypto_sym_xform *xform)
>  	if (rte_cryptodev_sym_capability_check_auth(cap,
>  			auth_xform->key.length,
>  			auth_xform->digest_length, 0) != 0) {
> -		RTE_LOG(ERR, USER1, "PMD %s key length %u IV length
> %u\n",
> +		RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length
> %u\n",
>  				info.device_name, auth_xform->key.length,
>  				auth_xform->digest_length);
>  		return -EPERM;
> @@ -1339,7 +1339,7 @@ prepare_cmac_xform(struct
> rte_crypto_sym_xform *xform)
>  	if (rte_cryptodev_sym_capability_check_auth(cap,
>  			auth_xform->key.length,
>  			auth_xform->digest_length, 0) != 0) {
> -		RTE_LOG(ERR, USER1, "PMD %s key length %u IV length
> %u\n",
> +		RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length
> %u\n",
>  				info.device_name, auth_xform->key.length,
>  				auth_xform->digest_length);
>  		return -EPERM;
> --
> 2.34.1

Reviewed-by: Brian Dooley <brian.dooley@intel.com>
  
Akhil Goyal Nov. 8, 2022, 5:20 a.m. UTC | #2
> > Subject: [PATCH v2] examples/fips_validation: fix typo
> >
> > Digest length is being printed out, not IV length.
> >
> > Fixes: ac026f4668d0 ("examples/fips_validation: support CMAC parsing")
> > Fixes: f64adb6714e0 ("examples/fips_validation: support HMAC parsing")
> > Cc: marko.kovacevic@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> Reviewed-by: Brian Dooley <brian.dooley@intel.com>
Applied to dpdk-next-crypto
  

Patch

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 404a29d7b6..9a9babb53a 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1210,7 +1210,7 @@  prepare_hmac_xform(struct rte_crypto_sym_xform *xform)
 	if (rte_cryptodev_sym_capability_check_auth(cap,
 			auth_xform->key.length,
 			auth_xform->digest_length, 0) != 0) {
-		RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+		RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n",
 				info.device_name, auth_xform->key.length,
 				auth_xform->digest_length);
 		return -EPERM;
@@ -1339,7 +1339,7 @@  prepare_cmac_xform(struct rte_crypto_sym_xform *xform)
 	if (rte_cryptodev_sym_capability_check_auth(cap,
 			auth_xform->key.length,
 			auth_xform->digest_length, 0) != 0) {
-		RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+		RTE_LOG(ERR, USER1, "PMD %s key length %u Digest length %u\n",
 				info.device_name, auth_xform->key.length,
 				auth_xform->digest_length);
 		return -EPERM;