From patchwork Fri Nov 4 16:23:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tadhg Kearney X-Patchwork-Id: 119501 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32286A034C; Fri, 4 Nov 2022 17:24:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE2A042D12; Fri, 4 Nov 2022 17:24:20 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B6EB742D10 for ; Fri, 4 Nov 2022 17:24:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667579059; x=1699115059; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TDzyf670MVmsmPISyo0sCjgOLbHys5p1rm0TuoszrOg=; b=bL3mDw+SXJXY+Osx/800LjtGk03O1118lVUAkrRDvff7aYIXRMbOzaP5 W3+iZzBxuOkFWUlmNcmH/ZRmtgnB5I8SNAw6ZxoJ0M3CPsYXgLYnilcdj MMAWACOrW0SE2UMU7PtU/Otv4e6/xH6YVP4Qt53niV8BnzRNouNJ1349X M3o9lhCx2qLOrxSUtntWsyuOX0Uh73jQiLAhZ3rc9a2u+Cbc4GiJ39Oee HIugjUh+lRNcckibI1Oi/zyMQkPFJcbpRUPkXR8xQ6AtvGQ/apZmuPbz+ 1qxIq2vLvTUgkQ7NjwupgIdzXnQb0PSR1JNETR8E8IxlOOyPUCySVtnMp A==; X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="290398444" X-IronPort-AV: E=Sophos;i="5.96,138,1665471600"; d="scan'208";a="290398444" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2022 09:23:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10521"; a="880348037" X-IronPort-AV: E=Sophos;i="5.96,138,1665471600"; d="scan'208";a="880348037" Received: from silpixa00401183.ir.intel.com ([10.55.129.36]) by fmsmga006.fm.intel.com with ESMTP; 04 Nov 2022 09:23:56 -0700 From: Tadhg Kearney To: dev@dpdk.org Cc: david.hunt@intel.com, anatoly.burakov@intel.com, reshma.pattan@intel.com, chris.macnamara@intel.com, Tadhg Kearney Subject: [PATCH] power: fix double free of opened files Date: Fri, 4 Nov 2022 16:23:53 +0000 Message-Id: <20221104162353.187145-1-tadhg.kearney@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221012082928.2171562-1-tadhg.kearney@intel.com> References: <20221012082928.2171562-1-tadhg.kearney@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix double free of f_min and f_max by reverting the flcose() for f_min and f_max. As f_min and f_max are stored for further use and closed in uncore deinitialization. Fixes: b127e74 ("power: fix open file descriptors leak") Signed-off-by: Tadhg Kearney Acked-by: Reshma Pattan --- lib/power/rte_power_intel_uncore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/power/rte_power_intel_uncore.c b/lib/power/rte_power_intel_uncore.c index f86e1c8b7a..3b8724385f 100644 --- a/lib/power/rte_power_intel_uncore.c +++ b/lib/power/rte_power_intel_uncore.c @@ -194,8 +194,7 @@ power_init_for_setting_uncore_freq(struct uncore_power_info *ui) fclose(f_base_min); fclose(f_base_max); - fclose(f_max); - fclose(f_min); + /* f_min and f_max are stored, no need to close */ return 0;