[v1] examples/fips_validation: fix IV generation for gmac

Message ID 20221102120117.381696-1-brian.dooley@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v1] examples/fips_validation: fix IV generation for gmac |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed

Commit Message

Brian Dooley Nov. 2, 2022, 12:01 p.m. UTC
  Replace rand() call in fips validation example with rte_rand().

Coverity issue: 381668
Fixes: e27268bd2103 ("examples/fips_validation: add parsing for AES-GMAC")

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
---
 examples/fips_validation/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Akhil Goyal Nov. 3, 2022, 11:22 a.m. UTC | #1
> Replace rand() call in fips validation example with rte_rand().
> 
> Coverity issue: 381668
> Fixes: e27268bd2103 ("examples/fips_validation: add parsing for AES-GMAC")
> 
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
Applied to dpdk-next-crypto

Thanks.
  

Patch

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 40a5b70e07..404a29d7b6 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -12,6 +12,7 @@ 
 #include <rte_mempool.h>
 #include <rte_mbuf.h>
 #include <rte_string_fns.h>
+#include <rte_random.h>
 
 #include "fips_validation.h"
 #include "fips_dev_self_test.h"
@@ -761,7 +762,7 @@  prepare_auth_op(void)
 		}
 
 		for (i = 0; i < vec.iv.len; i++) {
-			int random = rand();
+			int random = rte_rand();
 			vec.iv.val[i] = (uint8_t)random;
 		}
 	}