diff mbox series

[1/1] test/bbdev: use helper function to set IOVA addr

Message ID 20221101095325.23348-1-syalavarthi@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [1/1] test/bbdev: use helper function to set IOVA addr |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Srikanth Yalavarthi Nov. 1, 2022, 9:53 a.m. UTC 
  Use helper function rte_mbuf_iova_set to set IOVA address
to fix compilation failures.

Below error was observed:

dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
‘struct rte_mbuf’ has no member named ‘buf_iova’
 1145 |     m_head->buf_iova = rte_malloc_virt2iova(data);
      |           ^~

Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")

Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 app/test-bbdev/test_bbdev_perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jerin Jacob Nov. 3, 2022, 6:31 a.m. UTC | #1 
On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> Use helper function rte_mbuf_iova_set to set IOVA address
> to fix compilation failures.
>
> Below error was observed:
>
> dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> ‘struct rte_mbuf’ has no member named ‘buf_iova’
>  1145 |     m_head->buf_iova = rte_malloc_virt2iova(data);
>       |           ^~
>
> Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")

Is this change came after rte_mbuf_iova_set() API introduction?

>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  app/test-bbdev/test_bbdev_perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 8cf4359a2c..b285d3f3a7 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs,
>                                         "rte malloc failed with %u bytes",
>                                         seg->length + 1024);
>                                 m_head->buf_addr = data;
> -                               m_head->buf_iova = rte_malloc_virt2iova(data);
> +                               rte_mbuf_iova_set(m_head, rte_malloc_virt2iova(data));
>                                 m_head->data_off = 0;
>                                 m_head->data_len = seg->length;
>                         } else {
> --
> 2.17.1
>
Srikanth Yalavarthi Nov. 3, 2022, 7:24 a.m. UTC | #2 
> On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> <syalavarthi@marvell.com> wrote:
> >
> > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > compilation failures.
> >
> > Below error was observed:
> >
> > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> >  1145 |     m_head->buf_iova = rte_malloc_virt2iova(data);
> >       |           ^~
> >
> > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
> 
> Is this change came after rte_mbuf_iova_set() API introduction?
Yes,  the change is need after rte_mbuf_iova_set API is added. Build failure is observed on x86 and ARM64.
> 
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 
> 
> > ---
> >  app/test-bbdev/test_bbdev_perf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-bbdev/test_bbdev_perf.c
> > b/app/test-bbdev/test_bbdev_perf.c
> > index 8cf4359a2c..b285d3f3a7 100644
> > --- a/app/test-bbdev/test_bbdev_perf.c
> > +++ b/app/test-bbdev/test_bbdev_perf.c
> > @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data
> *bufs,
> >                                         "rte malloc failed with %u bytes",
> >                                         seg->length + 1024);
> >                                 m_head->buf_addr = data;
> > -                               m_head->buf_iova = rte_malloc_virt2iova(data);
> > +                               rte_mbuf_iova_set(m_head,
> > + rte_malloc_virt2iova(data));
> >                                 m_head->data_off = 0;
> >                                 m_head->data_len = seg->length;
> >                         } else {
> > --
> > 2.17.1
> >
Jerin Jacob Nov. 3, 2022, 7:36 a.m. UTC | #3 
On Thu, Nov 3, 2022 at 12:54 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> > On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> > <syalavarthi@marvell.com> wrote:
> > >
> > > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > > compilation failures.
> > >
> > > Below error was observed:
> > >
> > > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> > >  1145 |     m_head->buf_iova = rte_malloc_virt2iova(data);
> > >       |           ^~
> > >
> > > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
> >
> > Is this change came after rte_mbuf_iova_set() API introduction?
> Yes,  the change is need after rte_mbuf_iova_set API is added. Build failure is observed on x86 and ARM64.

Then, Please change Fixes: as the changeset introduced the rte_mbuf_iova_set()


> >
> > >
> > > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> >
> >
> > > ---
> > >  app/test-bbdev/test_bbdev_perf.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/app/test-bbdev/test_bbdev_perf.c
> > > b/app/test-bbdev/test_bbdev_perf.c
> > > index 8cf4359a2c..b285d3f3a7 100644
> > > --- a/app/test-bbdev/test_bbdev_perf.c
> > > +++ b/app/test-bbdev/test_bbdev_perf.c
> > > @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data
> > *bufs,
> > >                                         "rte malloc failed with %u bytes",
> > >                                         seg->length + 1024);
> > >                                 m_head->buf_addr = data;
> > > -                               m_head->buf_iova = rte_malloc_virt2iova(data);
> > > +                               rte_mbuf_iova_set(m_head,
> > > + rte_malloc_virt2iova(data));
> > >                                 m_head->data_off = 0;
> > >                                 m_head->data_len = seg->length;
> > >                         } else {
> > > --
> > > 2.17.1
> > >
Akhil Goyal Nov. 3, 2022, 8:01 a.m. UTC | #4 
> 
> On Thu, Nov 3, 2022 at 12:54 PM Srikanth Yalavarthi
> <syalavarthi@marvell.com> wrote:
> >
> > > On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> > > <syalavarthi@marvell.com> wrote:
> > > >
> > > > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > > > compilation failures.
> > > >
> > > > Below error was observed:
> > > >
> > > > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > > > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > > > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> > > >  1145 |     m_head->buf_iova = rte_malloc_virt2iova(data);
> > > >       |           ^~
> > > >
> > > > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
> > >
> > > Is this change came after rte_mbuf_iova_set() API introduction?
> > Yes,  the change is need after rte_mbuf_iova_set API is added. Build failure is
> observed on x86 and ARM64.
> 
> Then, Please change Fixes: as the changeset introduced the rte_mbuf_iova_set()
> 
FFT patch was added after the new API was introduced. So Fixes should be the FFT patch only.

Applied to dpdk-next-crypto
diff mbox series

Patch

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 8cf4359a2c..b285d3f3a7 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1142,7 +1142,7 @@  init_op_data_objs(struct rte_bbdev_op_data *bufs,
 					"rte malloc failed with %u bytes",
 					seg->length + 1024);
 				m_head->buf_addr = data;
-				m_head->buf_iova = rte_malloc_virt2iova(data);
+				rte_mbuf_iova_set(m_head, rte_malloc_virt2iova(data));
 				m_head->data_off = 0;
 				m_head->data_len = seg->length;
 			} else {