From patchwork Fri Oct 7 17:43:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 117584 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCFDDA04FD; Fri, 7 Oct 2022 19:44:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C38F42B70; Fri, 7 Oct 2022 19:44:30 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2046.outbound.protection.outlook.com [40.107.93.46]) by mails.dpdk.org (Postfix) with ESMTP id 55A2A4281C; Fri, 7 Oct 2022 19:44:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NuYy7csKoigPtXbMT9zBcv+n2XEf2E1ts2e1rfgb0wvyssva/HyDdP7028AyTWcXr1rkGcu5acy/+ZyRrCMGwOYz5T+u/8oGqtVcAtrtxMuB4Nl/DZcmqLYur9PjjRsOP0mQdFG5uuKtO2T9AgjYQMETqVGo4l2qGby05ELYZQ4Fb+suqFL8YJ2Elf76HKK51yf/FyfrW58ZSUbVGg79tYopErdFmlP6UPo+B//FZdnAZ2jZgnx1PBTA0/ybVk66RqNBA/s66gBtKH6KO1it7eshxrIOHsB5MIKgLDTu1zhJgkH0A4UUCDhCo5Iq5tWg7syNr+T++pp2vY1UrDMizw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2D9kgK+HW6LulQg52lNcgajhCK4gktTz9uKrqFgyWmA=; b=jnPfkerz+dklFi/WjPIQT6/Fl0uJ1iRTK7CZBe05f5tmdX9tBueS4UDz2G7MlxAscsTOKqm/FhcxYDYGgDIhWn5pZFwqUkRsjaVD8nbo2bkHLPRYGvscvixwjtJgF5NH3EVPCWi5UXMhFPs/5rwFcc0xoAXAmtAZaJ4nCafUNVPDleIcjn+oKI+CRvlG6aUhLQgylpRZuBy2YpRdts2GxpR/SssmnytiQmdhUeHI3Ypx7qJF2yq/czU1IhmE5CjPPayOCBvjKpyAMA4Yv8WZhx9by+AAotWi34XVb/W6i3Buw/UUg3OzzrTvw+HDbeZU2RIuPcT1GGdz5orX7Ao8qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2D9kgK+HW6LulQg52lNcgajhCK4gktTz9uKrqFgyWmA=; b=LLj9SdJj+ZybPzkU2hNIN7n56vZtnBVnMEhc2zR8cN9iC7f0j3W/HshGreEjKwTmnSOez51ojlB+Ropl9p+gBpWnznUY4O9/9MweArEJpfVu1gvNv9lQ3DBRWThkz2J62ZHw0IvYGpg2PIra9FUxR9g0bWNzqbr4zLFzBeRSxnc= Received: from MW4PR03CA0005.namprd03.prod.outlook.com (2603:10b6:303:8f::10) by BL1PR12MB5224.namprd12.prod.outlook.com (2603:10b6:208:319::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct 2022 17:44:26 +0000 Received: from CO1NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::6e) by MW4PR03CA0005.outlook.office365.com (2603:10b6:303:8f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24 via Frontend Transport; Fri, 7 Oct 2022 17:44:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT055.mail.protection.outlook.com (10.13.175.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:44:25 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct 2022 12:44:23 -0500 From: Andrew Boyer To: CC: Andrew Boyer , Subject: [PATCH 04/35] net/ionic: fix up the Rx filter save API Date: Fri, 7 Oct 2022 10:43:05 -0700 Message-ID: <20221007174336.54354-5-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221007174336.54354-1-andrew.boyer@amd.com> References: <20221007174336.54354-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT055:EE_|BL1PR12MB5224:EE_ X-MS-Office365-Filtering-Correlation-Id: c860a688-4c65-45e9-2d65-08daa88b939b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ared/WTBTXN37w1yC+gIiB/+Kq5q3MXyK2DpTTzAkD3T14hcyfx92jwV1AW3Y9GaWn/wpfR8ItWUaiivGhLDA8mKAlF9AyIMoKrT5eC5Zg5FedwJ5CEPgljNTQtle5CUb3tK8vauSdfim5o8gXpMT+2An2SQs8lewKZRu50UMgYV/ps5d26POzCIi0QxlKw67yQFztCn+w2bgtKCqjiT7kSkm45NC7L9Cz5XD5fK4U+BkSc9IWUo5ODDfFqx/nRfnC5vucOs6tBZl0I0TCeirQg9h284JjAlUx/rOuJTnFYcuM7uviBzGObLhx/9OGLt6n31FpJTPGxG42keif9LvBYftQUMncA645N9gMMzBJmfV8puuTYikhJHNetaHFxIuBO/tJsMlxcCWUdB7jQ01GrPCSlkQlMTN4uxeequxkPrTqkJD62WIJ+1MMrVPtaBPHzQQPWgUJUWiwy3f5hFGmryyKp0t8eAN1fbZ/kvnlv/Yb7jbWBOz68UuyLClf9ag8d112mLw6QIwcdsi14thRzFa7yQ8Qutsu5TxJuds4kqzAPxp1zdQzavVqqvPkN40UM1kWIqUNWt4ZVRCEHGHGEpt7ZPdc2jLio6NT8/Ak0iM5DUKGLVHr8KH8U9r2/b34VCoXrjl1HvcMGSU1yi3dJjX6liLodPQinagcalgIgRPuRPye+PgwTN2sV98AAFmfCTRWbmmLaU9Ep4nxpXQ6Mou3hDh2YJZex+9Kag/Kdhv8T4DWUcbfak6hcZzDJie+DH1/FP4esH0DBM8eTKmLxuwK6F/t/97pBn1xwczkbec6W1bFfKtlmLr3Zdshgm X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(40460700003)(478600001)(356005)(316002)(8936002)(4744005)(5660300002)(47076005)(44832011)(40480700001)(426003)(1076003)(336012)(16526019)(86362001)(83380400001)(82740400003)(2616005)(36756003)(6666004)(41300700001)(2906002)(26005)(36860700001)(81166007)(82310400005)(186003)(8676002)(4326008)(6916009)(70586007)(54906003)(70206006)(450100002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 17:44:25.4968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c860a688-4c65-45e9-2d65-08daa88b939b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5224 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check the match variable after copying cmd info, or else there can be unexpected results. Fixes: a27e0e96ab77 ("net/ionic: observe endianness in Rx filter") Cc: andrew.boyer@amd.com Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rx_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c index bf57a9fa52..4b2e907f9f 100644 --- a/drivers/net/ionic/ionic_rx_filter.c +++ b/drivers/net/ionic/ionic_rx_filter.c @@ -63,8 +63,8 @@ ionic_rx_filter_save(struct ionic_lif *lif, uint32_t flow_id, f->flow_id = flow_id; f->filter_id = rte_le_to_cpu_32(ctx->comp.rx_filter_add.filter_id); f->rxq_index = rxq_index; - f->match = rte_le_to_cpu_16(f->cmd.match); memcpy(&f->cmd, &ctx->cmd, sizeof(f->cmd)); + f->match = rte_le_to_cpu_16(f->cmd.match); switch (f->match) { case IONIC_RX_FILTER_MATCH_VLAN: