From patchwork Thu Sep 29 11:43:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Prakash Shukla X-Patchwork-Id: 117131 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 630E7A00C4; Thu, 29 Sep 2022 13:43:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1913840694; Thu, 29 Sep 2022 13:43:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B00F340395 for ; Thu, 29 Sep 2022 13:43:32 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28TBfHWU022993; Thu, 29 Sep 2022 04:43:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=khtsnSVoo0Lc1dlLx3SFWOQXyKLz1ZZ72Z5SMkNGKvc=; b=DpG44jWzNIh2ti1mOs4d1bN7DenOpqj35b4Fv0/lk/5SG+sdWjmEWRIXbhZmTjAvaMfG HGDb+txa8NWKySZXNVDVUkmiXk8I50TMtGmEUiZyfqb8BIoTvVt8vw5eQb/kKlwlPshI K1gYoEN+0/le7BuXSaf1RMu9A3UxrNEUm2QPuqHXjdfr2uk/O4TwZPsIYPA4A0oCT1yk xT9bVMj2O90JNGnMBsfnXp4TcZoHvhyuvZyLQqnZqH3vRo612nxyrJOz940xaXiuEB8r OFlG9jiFjgv5U1rIITJvJsGzDPkcyN10991JbOdcPl9AYRKym2ERgSti/TwE2/Z6TinM sA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jw1rt21kd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Sep 2022 04:43:31 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Sep 2022 04:43:29 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Thu, 29 Sep 2022 04:43:29 -0700 Received: from localhost.localdomain (unknown [10.28.36.157]) by maili.marvell.com (Postfix) with ESMTP id 747AB3F70E1; Thu, 29 Sep 2022 04:43:27 -0700 (PDT) From: Amit Prakash Shukla To: Anatoly Burakov CC: , , , , , , Amit Prakash Shukla Subject: [PATCH v5 1/2] mem: telemetry support for memseg and element information Date: Thu, 29 Sep 2022 17:13:12 +0530 Message-ID: <20220929114313.1346972-1-amitprakashs@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220525103352.1806937-1-amitprakashs@marvell.com> References: <20220525103352.1806937-1-amitprakashs@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: hqC5-5v4VeR5Oy3MdreBQOCs8jlgYMKI X-Proofpoint-ORIG-GUID: hqC5-5v4VeR5Oy3MdreBQOCs8jlgYMKI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_06,2022-09-29_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Changes adds telemetry support to display memory occupancy in memseg and the information of the elements allocated from a memseg based on arguments provided by user. This patch adds following endpoints: 1. /eal/memseg_list_array The command displays the memseg list from which the memory has been allocated. Example: --> /eal/memseg_list_array {"/eal/memseg_list_array": [0, 1]} 2. /eal/memseg_list_info, The command outputs the memsegs, from which the memory is allocated, for the memseg_list given as input. Example: --> /eal/memseg_list_info,1 {"/eal/memseg_list_info": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, \ 12, 13, 14, 15]} 3. /eal/memseg_info,, The command outputs the memseg information based on the memseg-list and the memseg-id given as input. Example: --> /eal/memseg_info,0,10 {"/eal/memseg_info": {"Memseg_list_index": 0, \ "Memseg_index": 10, "Memseg_list_len": 64, \ "Start_addr": "0x260000000", "End_addr": "0x280000000", \ "Size": 536870912}} --> /eal/memseg_info,1,15 {"/eal/memseg_info": {"Memseg_list_index": 1, \ "Memseg_index": 15, "Memseg_list_len": 64, \ "Start_addr": "0xb20000000", "End_addr": "0xb40000000", \ "Size": 536870912}} 4. /eal/element_list,,, The command outputs number of elements in a memseg based on the heap-id, memseg-list-id and memseg-id given as input. Example: --> /eal/element_list,0,0,63 {"/eal/element_list": {"Element_count": 52}} --> /eal/element_list,0,1,15 {"/eal/element_list": {"Element_count": 52}} 5. /eal/element_info,,,, \ , The command outputs element information like element start address, end address, to which memseg it belongs, element state, element size. User can give a range of elements to be printed. Example: --> /eal/element_info,0,1,15,1,2 {"/eal/element_info": {"element.1": {"msl_id": 1, \ "ms_id": 15, "memseg_start_addr": "0xb20000000", \ "memseg_end_addr": "0xb40000000", \ "element_start_addr": "0xb201fe680", \ "element_end_addr": "0xb20bfe700", \ "element_size": 10485888, "element_state": "Busy"}, \ "element.2": {"msl_id": 1, "ms_id": 15, \ "memseg_start_addr": "0xb20000000", \ "memseg_end_addr": "0xb40000000", \ "element_start_addr": "0xb20bfe700", \ "element_end_addr": "0xb215fe780", "element_size": 10485888, \ "element_state": "Busy"}, "Element_count": 2}} Signed-off-by: Amit Prakash Shukla --- v2: - Fixed compilation error related int-to-pointer-cast - Changes for code review suggestions v3: - Commit message changes - Renaming end-points - Changing input parameters to comma-seperated - Reverting telemetry output buffer size v4: - Patch-2 adds telemetry support to display system memory v5: - Removed command help related changes lib/eal/common/eal_common_memory.c | 447 ++++++++++++++++++++++++++++- 1 file changed, 442 insertions(+), 5 deletions(-) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c index 688dc615d7..6b863979e9 100644 --- a/lib/eal/common/eal_common_memory.c +++ b/lib/eal/common/eal_common_memory.c @@ -3,6 +3,7 @@ */ #include +#include #include #include #include @@ -26,6 +27,7 @@ #include "eal_memcfg.h" #include "eal_options.h" #include "malloc_heap.h" +#include "malloc_elem.h" /* * Try to mmap *size bytes in /dev/zero. If it is successful, return the @@ -1113,11 +1115,17 @@ rte_eal_memory_init(void) } #ifndef RTE_EXEC_ENV_WINDOWS -#define EAL_MEMZONE_LIST_REQ "/eal/memzone_list" -#define EAL_MEMZONE_INFO_REQ "/eal/memzone_info" -#define EAL_HEAP_LIST_REQ "/eal/heap_list" -#define EAL_HEAP_INFO_REQ "/eal/heap_info" -#define ADDR_STR 15 +#define EAL_MEMZONE_LIST_REQ "/eal/memzone_list" +#define EAL_MEMZONE_INFO_REQ "/eal/memzone_info" +#define EAL_HEAP_LIST_REQ "/eal/heap_list" +#define EAL_HEAP_INFO_REQ "/eal/heap_info" +#define EAL_MEMSEG_LIST_ARR_REQ "/eal/memseg_list_array" +#define EAL_MEMSEG_LIST_INFO_REQ "/eal/memseg_list_info" +#define EAL_MEMSEG_INFO_REQ "/eal/memseg_info" +#define EAL_ELEMENT_LIST_REQ "/eal/element_list" +#define EAL_ELEMENT_INFO_REQ "/eal/element_info" +#define ADDR_STR 15 + /* Telemetry callback handler to return heap stats for requested heap id. */ static int @@ -1265,6 +1273,418 @@ handle_eal_memzone_list_request(const char *cmd __rte_unused, return 0; } +static int +handle_eal_memseg_list_array_request(const char *cmd __rte_unused, + const char *params __rte_unused, + struct rte_tel_data *d) +{ + struct rte_mem_config *mcfg; + int i; + + rte_tel_data_start_array(d, RTE_TEL_INT_VAL); + + rte_mcfg_mem_read_lock(); + mcfg = rte_eal_get_configuration()->mem_config; + + for (i = 0; i < RTE_MAX_MEMSEG_LISTS; i++) { + struct rte_memseg_list *msl = &mcfg->memsegs[i]; + if (msl->memseg_arr.count == 0) + continue; + + rte_tel_data_add_array_int(d, i); + } + rte_mcfg_mem_read_unlock(); + + return 0; +} + +static int +handle_eal_memseg_list_info_request(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + struct rte_mem_config *mcfg; + struct rte_memseg_list *msl; + struct rte_fbarray *arr; + uint32_t ms_list_idx; + int ms_idx; + + if (params == NULL || strlen(params) == 0) + return -1; + + if (!isdigit(*params)) + return -1; + + ms_list_idx = strtoul(params, NULL, 10); + if (ms_list_idx >= RTE_MAX_MEMSEG_LISTS) + return -1; + + rte_tel_data_start_array(d, RTE_TEL_INT_VAL); + + rte_mcfg_mem_read_lock(); + mcfg = rte_eal_get_configuration()->mem_config; + msl = &mcfg->memsegs[ms_list_idx]; + if (msl->memseg_arr.count == 0) + goto done; + + arr = &msl->memseg_arr; + + ms_idx = rte_fbarray_find_next_used(arr, 0); + while (ms_idx >= 0) { + rte_tel_data_add_array_int(d, ms_idx); + ms_idx = rte_fbarray_find_next_used(arr, ms_idx + 1); + } + +done: + rte_mcfg_mem_read_unlock(); + + return 0; +} + +static int +handle_eal_memseg_info_request(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + struct rte_mem_config *mcfg; + uint64_t ms_start_addr, ms_end_addr, ms_size; + struct rte_memseg_list *msl; + const struct rte_memseg *ms; + struct rte_fbarray *arr; + char addr[ADDR_STR]; + uint32_t ms_list_idx = 0; + uint32_t ms_idx = 0; + uint32_t msl_len; + char dlim[2] = ","; + char *token; + char *params_args; + + if (params == NULL || strlen(params) == 0) + return -1; + + /* strtok expects char * and param is const char *. Hence on using + * params as "const char *" compiler throws warning. + */ + params_args = strdup(params); + token = strtok(params_args, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + ms_list_idx = strtoul(token, NULL, 10); + if (ms_list_idx >= RTE_MAX_MEMSEG_LISTS) { + free(params_args); + return -1; + } + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + ms_idx = strtoul(token, NULL, 10); + + free(params_args); + + rte_mcfg_mem_read_lock(); + + mcfg = rte_eal_get_configuration()->mem_config; + msl = &mcfg->memsegs[ms_list_idx]; + if (msl->memseg_arr.count == 0) { + rte_mcfg_mem_read_unlock(); + return -1; + } + + arr = &msl->memseg_arr; + msl_len = arr->len; + + ms = rte_fbarray_get(arr, ms_idx); + if (ms == NULL) { + rte_mcfg_mem_read_unlock(); + RTE_LOG(DEBUG, EAL, "Error fetching requested memseg.\n"); + return -1; + } + + ms_start_addr = ms->addr_64; + ms_end_addr = (uint64_t)RTE_PTR_ADD(ms_start_addr, ms->len); + ms_size = ms->hugepage_sz; + + rte_mcfg_mem_read_unlock(); + + rte_tel_data_start_dict(d); + rte_tel_data_add_dict_int(d, "Memseg_list_index", ms_list_idx); + rte_tel_data_add_dict_int(d, "Memseg_index", ms_idx); + rte_tel_data_add_dict_int(d, "Memseg_list_len", msl_len); + snprintf(addr, ADDR_STR, "0x%"PRIx64, ms_start_addr); + rte_tel_data_add_dict_string(d, "Start_addr", addr); + snprintf(addr, ADDR_STR, "0x%"PRIx64, ms_end_addr); + rte_tel_data_add_dict_string(d, "End_addr", addr); + rte_tel_data_add_dict_int(d, "Size", ms_size); + + return 0; +} + +static int +handle_eal_element_list_request(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + struct rte_mem_config *mcfg; + struct rte_memseg_list *msl; + const struct rte_memseg *ms; + struct malloc_elem *elem; + struct malloc_heap *heap; + uint64_t ms_start_addr, ms_end_addr; + uint64_t elem_start_addr, elem_end_addr; + uint32_t ms_list_idx = 0; + uint32_t heap_id = 0; + uint32_t ms_idx = 0; + char dlim[2] = ","; + int elem_count = 0; + char *token; + char *params_args; + + if (params == NULL || strlen(params) == 0) + return -1; + + /* strtok expects char * and param is const char *. Hence on using + * params as "const char *" compiler throws warning. + */ + params_args = strdup(params); + token = strtok(params_args, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + heap_id = strtoul(token, NULL, 10); + if (heap_id >= RTE_MAX_HEAPS) { + free(params_args); + return -1; + } + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + ms_list_idx = strtoul(token, NULL, 10); + if (ms_list_idx >= RTE_MAX_MEMSEG_LISTS) { + free(params_args); + return -1; + } + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + ms_idx = strtoul(token, NULL, 10); + + free(params_args); + + rte_mcfg_mem_read_lock(); + + mcfg = rte_eal_get_configuration()->mem_config; + msl = &mcfg->memsegs[ms_list_idx]; + ms = rte_fbarray_get(&msl->memseg_arr, ms_idx); + if (ms == NULL) { + rte_mcfg_mem_read_unlock(); + RTE_LOG(DEBUG, EAL, "Error fetching requested memseg.\n"); + return -1; + } + + ms_start_addr = ms->addr_64; + ms_end_addr = (uint64_t)RTE_PTR_ADD(ms_start_addr, ms->len); + rte_mcfg_mem_read_unlock(); + + rte_tel_data_start_dict(d); + + heap = &mcfg->malloc_heaps[heap_id]; + rte_spinlock_lock(&heap->lock); + + elem = heap->first; + while (elem) { + elem_start_addr = (uint64_t)elem; + elem_end_addr = + (uint64_t)RTE_PTR_ADD(elem_start_addr, elem->size); + + if ((uint64_t)elem_start_addr >= ms_start_addr && + (uint64_t)elem_end_addr <= ms_end_addr) + elem_count++; + elem = elem->next; + } + + rte_spinlock_unlock(&heap->lock); + + rte_tel_data_add_dict_int(d, "Element_count", elem_count); + + return 0; +} + +static int +handle_eal_element_info_request(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + struct rte_mem_config *mcfg; + struct rte_memseg_list *msl; + const struct rte_memseg *ms; + struct malloc_elem *elem; + struct malloc_heap *heap; + struct rte_tel_data *c; + uint64_t ms_start_addr, ms_end_addr; + uint64_t elem_start_addr, elem_end_addr; + uint32_t ms_list_idx = 0; + uint32_t heap_id = 0; + uint32_t ms_idx = 0; + uint32_t start_elem = 0, end_elem = 0; + uint32_t count = 0, elem_count = 0; + char dlim[2] = ","; + char str[ADDR_STR]; + char *params_args; + char *token; + + if (params == NULL || strlen(params) == 0) + return -1; + + /* strtok expects char * and param is const char *. Hence on using + * params as "const char *" compiler throws warning. + */ + params_args = strdup(params); + token = strtok(params_args, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + heap_id = strtoul(token, NULL, 10); + if (heap_id >= RTE_MAX_HEAPS) { + free(params_args); + return -1; + } + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + ms_list_idx = strtoul(token, NULL, 10); + if (ms_list_idx >= RTE_MAX_MEMSEG_LISTS) { + free(params_args); + return -1; + } + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + ms_idx = strtoul(token, NULL, 10); + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + start_elem = strtoul(token, NULL, 10); + + token = strtok(NULL, dlim); + if (token == NULL || !isdigit(*token)) { + free(params_args); + return -1; + } + + end_elem = strtoul(token, NULL, 10); + + free(params_args); + + if (end_elem < start_elem) + return -1; + + rte_mcfg_mem_read_lock(); + + mcfg = rte_eal_get_configuration()->mem_config; + msl = &mcfg->memsegs[ms_list_idx]; + ms = rte_fbarray_get(&msl->memseg_arr, ms_idx); + if (ms == NULL) { + rte_mcfg_mem_read_unlock(); + RTE_LOG(DEBUG, EAL, "Error fetching requested memseg.\n"); + return -1; + } + + ms_start_addr = ms->addr_64; + ms_end_addr = (uint64_t)RTE_PTR_ADD(ms_start_addr, ms->len); + + rte_mcfg_mem_read_unlock(); + + rte_tel_data_start_dict(d); + + heap = &mcfg->malloc_heaps[heap_id]; + rte_spinlock_lock(&heap->lock); + + elem = heap->first; + while (elem) { + elem_start_addr = (uint64_t)elem; + elem_end_addr = + (uint64_t)RTE_PTR_ADD(elem_start_addr, elem->size); + + if (elem_start_addr < ms_start_addr || + elem_end_addr > ms_end_addr) { + elem = elem->next; + continue; + } + + if (count < start_elem) { + elem = elem->next; + count++; + continue; + } + + c = rte_tel_data_alloc(); + if (c == NULL) + break; + + rte_tel_data_start_dict(c); + rte_tel_data_add_dict_int(c, "msl_id", ms_list_idx); + rte_tel_data_add_dict_int(c, "ms_id", ms_idx); + snprintf(str, ADDR_STR, "0x%"PRIx64, ms_start_addr); + rte_tel_data_add_dict_string(c, "memseg_start_addr", str); + snprintf(str, ADDR_STR, "0x%"PRIx64, ms_end_addr); + rte_tel_data_add_dict_string(c, "memseg_end_addr", str); + snprintf(str, ADDR_STR, "0x%"PRIx64, elem_start_addr); + rte_tel_data_add_dict_string(c, "element_start_addr", str); + snprintf(str, ADDR_STR, "0x%"PRIx64, elem_end_addr); + rte_tel_data_add_dict_string(c, "element_end_addr", str); + rte_tel_data_add_dict_int(c, "element_size", elem->size); + snprintf(str, ADDR_STR, "%s", elem->state == 0 ? "Free" : + elem->state == 1 ? "Busy" : elem->state == 2 ? + "Pad" : "Error"); + rte_tel_data_add_dict_string(c, "element_state", str); + + snprintf(str, ADDR_STR, "%s.%u", "element", count); + if (rte_tel_data_add_dict_container(d, str, c, 0) != 0) { + rte_tel_data_free(c); + break; + } + + elem_count++; + count++; + if (count > end_elem) + break; + + elem = elem->next; + } + + rte_spinlock_unlock(&heap->lock); + + rte_tel_data_add_dict_int(d, "Element_count", elem_count); + + return 0; +} + RTE_INIT(memory_telemetry) { rte_telemetry_register_cmd( @@ -1279,5 +1699,22 @@ RTE_INIT(memory_telemetry) rte_telemetry_register_cmd( EAL_HEAP_INFO_REQ, handle_eal_heap_info_request, "Returns malloc heap stats. Parameters: int heap_id"); + rte_telemetry_register_cmd( + EAL_MEMSEG_LIST_ARR_REQ, + handle_eal_memseg_list_array_request, + "Returns hugepage list. Takes no parameters"); + rte_telemetry_register_cmd( + EAL_MEMSEG_LIST_INFO_REQ, + handle_eal_memseg_list_info_request, + "Returns memseg list. Parameters: int memseg_list_id"); + rte_telemetry_register_cmd( + EAL_MEMSEG_INFO_REQ, handle_eal_memseg_info_request, + "Returns memseg info. Parameter: int memseg_list_id,int memseg_id"); + rte_telemetry_register_cmd(EAL_ELEMENT_LIST_REQ, + handle_eal_element_list_request, + "Returns element info. Parameters: int heap_id, int memseg_list_id, int memseg_id"); + rte_telemetry_register_cmd(EAL_ELEMENT_INFO_REQ, + handle_eal_element_info_request, + "Returns element info. Parameters: int heap_id, memseg_list_id, memseg_id, start_elem_id, end_elem_id"); } #endif