diff mbox series

app/eventdev: fix incorrect cleanup check

Message ID 20220926150548.5076-1-pbhagavatula@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series app/eventdev: fix incorrect cleanup check |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS

Commit Message

Pavan Nikhilesh Bhagavatula Sept. 26, 2022, 3:05 p.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

During cleanup `rte_event_port_quiesce` should be called
irrespective of whether an event has been dequeued or not
to flush any prefetched events.

Fixes: 7da008df0c8d ("app/eventdev: use port quiescing")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test-eventdev/test_pipeline_common.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Jerin Jacob Sept. 28, 2022, 1:50 p.m. UTC | #1 
On Mon, Sep 26, 2022 at 8:35 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> During cleanup `rte_event_port_quiesce` should be called
> irrespective of whether an event has been dequeued or not
> to flush any prefetched events.
>
> Fixes: 7da008df0c8d ("app/eventdev: use port quiescing")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied to dpdk-next-net-eventdev/for-main. Thanks


> ---
>  app/test-eventdev/test_pipeline_common.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 4f40d37659..22a3918ed8 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -696,9 +696,6 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],
>  {
>         int i;
>
> -       if (!(deq - enq))
> -               return;
> -
>         if (deq) {
>                 for (i = enq; i < deq; i++) {
>                         if (ev[i].op == RTE_EVENT_OP_RELEASE)
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index 4f40d37659..22a3918ed8 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -696,9 +696,6 @@  pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],
 {
 	int i;
 
-	if (!(deq - enq))
-		return;
-
 	if (deq) {
 		for (i = enq; i < deq; i++) {
 			if (ev[i].op == RTE_EVENT_OP_RELEASE)