[v5,1/3] ethdev: add IPsec SA expiry event subtypes
Checks
Commit Message
From: Vamsi Attunuru <vattunuru@marvell.com>
Patch adds new event subtypes for notifying expiry
events upon reaching IPsec SA soft packet expiry and
hard packet/byte expiry limits.
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
lib/ethdev/rte_ethdev.h | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
Comments
Hi Thomas,
> Subject: [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes
>
> From: Vamsi Attunuru <vattunuru@marvell.com>
>
> Patch adds new event subtypes for notifying expiry
> events upon reaching IPsec SA soft packet expiry and
> hard packet/byte expiry limits.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
Can you ack this patch if no further comments?
This patch is from last release deferred to 22.11.
https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/
Regards,
Akhil
24/09/2022 15:57, Akhil Goyal:
> From: Vamsi Attunuru <vattunuru@marvell.com>
>
> Patch adds new event subtypes for notifying expiry
> events upon reaching IPsec SA soft packet expiry and
> hard packet/byte expiry limits.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -3875,8 +3875,26 @@ enum rte_eth_event_ipsec_subtype {
> RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW,
> /** Soft time expiry of SA */
> RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
> - /** Soft byte expiry of SA */
> + /**
> + * Soft byte expiry of SA determined by @ref bytes_soft_limit
> + * defined in @ref rte_security_ipsec_lifetime
> + */
> RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
> + /**
> + * Soft packet expiry of SA determined by @ref packets_soft_limit
> + * defined in @ref rte_security_ipsec_lifetime
> + */
> + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
> + /**
> + * Hard byte expiry of SA determined by @ref bytes_hard_limit
> + * defined in @ref rte_security_ipsec_lifetime
> + */
> + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY,
> + /**
> + * Hard packet expiry of SA determined by @ref packets_hard_limit
> + * defined in @ref rte_security_ipsec_lifetime
> + */
> + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY,
> /** Max value of this enum */
> RTE_ETH_EVENT_IPSEC_MAX
I would prefer we remove this MAX value, but it would be another patch.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
You can merge this patch in the crypto tree.
> 24/09/2022 15:57, Akhil Goyal:
> > From: Vamsi Attunuru <vattunuru@marvell.com>
> >
> > Patch adds new event subtypes for notifying expiry
> > events upon reaching IPsec SA soft packet expiry and
> > hard packet/byte expiry limits.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > --- a/lib/ethdev/rte_ethdev.h
> > +++ b/lib/ethdev/rte_ethdev.h
> > @@ -3875,8 +3875,26 @@ enum rte_eth_event_ipsec_subtype {
> > RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW,
> > /** Soft time expiry of SA */
> > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
> > - /** Soft byte expiry of SA */
> > + /**
> > + * Soft byte expiry of SA determined by @ref bytes_soft_limit
> > + * defined in @ref rte_security_ipsec_lifetime
> > + */
> > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
> > + /**
> > + * Soft packet expiry of SA determined by @ref packets_soft_limit
> > + * defined in @ref rte_security_ipsec_lifetime
> > + */
> > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
> > + /**
> > + * Hard byte expiry of SA determined by @ref bytes_hard_limit
> > + * defined in @ref rte_security_ipsec_lifetime
> > + */
> > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY,
> > + /**
> > + * Hard packet expiry of SA determined by @ref packets_hard_limit
> > + * defined in @ref rte_security_ipsec_lifetime
> > + */
> > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY,
> > /** Max value of this enum */
> > RTE_ETH_EVENT_IPSEC_MAX
>
> I would prefer we remove this MAX value, but it would be another patch.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> You can merge this patch in the crypto tree.
>
Series Applied to dpdk-next-crypto
@@ -3875,8 +3875,26 @@ enum rte_eth_event_ipsec_subtype {
RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW,
/** Soft time expiry of SA */
RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
- /** Soft byte expiry of SA */
+ /**
+ * Soft byte expiry of SA determined by @ref bytes_soft_limit
+ * defined in @ref rte_security_ipsec_lifetime
+ */
RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
+ /**
+ * Soft packet expiry of SA determined by @ref packets_soft_limit
+ * defined in @ref rte_security_ipsec_lifetime
+ */
+ RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY,
+ /**
+ * Hard byte expiry of SA determined by @ref bytes_hard_limit
+ * defined in @ref rte_security_ipsec_lifetime
+ */
+ RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY,
+ /**
+ * Hard packet expiry of SA determined by @ref packets_hard_limit
+ * defined in @ref rte_security_ipsec_lifetime
+ */
+ RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY,
/** Max value of this enum */
RTE_ETH_EVENT_IPSEC_MAX
};
@@ -3898,6 +3916,9 @@ struct rte_eth_event_ipsec_desc {
* - @ref RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW
* - @ref RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY
* - @ref RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY
+ * - @ref RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY
+ * - @ref RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY
+ * - @ref RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY
*
* @see struct rte_security_session_conf
*